wanderer/gitea
1
0
Fork 0
forked from mirror/gitea
Code Issues Pull Requests Releases Activity
13,533 Commits 2 Branches 0 Tags 167 MiB
931c02d152
Commit Graph

13533 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tyrone Yeh
931c02d152
Add order by for assignee no sort issue (#20053) 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-07-14 18:00:10 +02:00
a1012112796
f85bb6f70b
Make sure repo_dir is an empty directory or doesn't exist before 'dump-repo' (#20205) 2022-07-14 21:52:18 +08:00
Jeremy
725f9e40b3
Fix English mistakes in some Markdown documents (#20274) 2022-07-14 19:15:35 +08:00
silverwind
7740779b28
Fix versions check for busybox sh (#20358) 
`printf` in busybox emits a ugly 'invalid number' error when formatting
string variables are present. Avoid that by reducing the go version
check to just two digits, which ought to be enough as patch-level go
versions are meant to be compatible. Avoid error on node-check as well.
 2022-07-14 16:58:14 +08:00
silverwind
aec6b30e2a
Unbreak release pipeline (#20356) 
Downgrade release pipeline to node 16 until xgo updates its base OS to a
version with a compatible glibc.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-07-14 16:09:26 +08:00
zeripath
bffa303020
Add option to purge users (#18064) 
Add the ability to purge users when deleting them.

Close #15588

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-14 08:22:09 +01:00
Baoshuo Ren
175705356c
Fix icon margin in user/settings/repos (#20281) 2022-07-14 11:03:31 +08:00
Tyrone Yeh
715042c5bb
Fix org label open count, including close count issue (#20353) 
Fixed using organization tags to see open issues in the tag list including closed issues count
 2022-07-14 04:09:03 +02:00
zeripath
ed094dbab9 [skip ci] Updated translations via Crowdin 2022-07-14 00:21:35 +00:00
zeripath
fe09ee564d
Prevent context deadline error propagation in GetCommitsInfo (#20346) 
* Prevent context deadline error propagation in GetCommitsInfo

Although `WalkGitLog` tries to test for `context.DeadlineExceededErr`
there is a small chance that the error will propagate to the reader
before it is recognised. This will cause the error to propagate up to
`renderDirectoryFiles` and cause a http status 500.

Here we check that the error passed is a `DeadlineExceededErr` via error.Is

Fix #20329

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-14 00:24:29 +02:00
Gusted
07ec8288bf
Add missing return for when topic isn't found (#20351) 
Add missing return to DeleteTopic API when the topic is not found.
 2022-07-13 18:39:19 +01:00
silverwind
9cd1f38f70
Upgrade to Node 18 on CI (#20340) 
* Upgrade to Node 18 on CI

Should be pretty stable now.

* restart ci

Co-authored-by: 6543 <6543@obermui.de>
 2022-07-13 11:45:08 -04:00
Ing. Jaroslav Šafka
8420c1bf4c
Fix checks in PR for empty commits #19603 (#20290) 
* Fixes issue #19603 (Not able to merge commit in PR when branches content is same, but different commit id)
* fill HeadCommitID in PullRequest
* compare real commits ID as check for merging
* based on @zeripath patch in #19738
 2022-07-13 16:22:51 +08:00
Gusted
b7c6ec91ba
Use default values when provided values are empty (#20318) 
* Use default values when provided values are empty

- When provided values are empty like `:3000` would imply that host is
empty, use the default value.
- Resolves #20316

* Update database.go

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-07-13 13:33:31 +08:00
wxiaoguang
f67a1030b3
Add tests for the host checking logic, clarify the behaviors (#20328) 
Before, the combination of AllowedDomains/BlockedDomains/AllowLocalNetworks is confusing.

This PR adds tests for the logic, clarify the behaviors.
 2022-07-13 09:07:16 +08:00
6543
d94f517643
Changelog for 1.16.9 (update) (#20341) (#20343) 
* Changelog for 1.16.9 (update)
 2022-07-13 00:27:35 +02:00
luzpaz
d29d6d1991
Fix various typos (#20338) 
* Fix various typos

Found via `codespell -q 3 -S ./options/locale,./options/license,./public/vendor -L actived,allways,attachements,ba,befores,commiter,pullrequest,pullrequests,readby,splitted,te,unknwon`

Co-authored-by: zeripath <art27@cantab.net>
 2022-07-12 23:32:37 +02:00
Chongyi Zheng
966e7bdc9b
Correctly handle draft releases without a tag (#20314) 
Fixes #20313.

`errors.Is(err, git.ErrNotExist{})` is not working
 2022-07-12 13:57:38 +01:00
Gusted
3aec32ad16
Add write check for creating Commit status (#20332) 
- Add write code checks for creating new commit status
- Regression #5314

Co-authored-by: zeripath <art27@cantab.net>
 2022-07-12 14:51:06 +02:00
silverwind
e24c238ecc
Remove blue text on migrate page (#20273) 
* Remove blue text on migrate page

* remove Safe

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-07-12 17:04:15 +08:00
BurritoVoid
4ce07a00e5
Updated dead link to Madeleine.js source (#20322) 2022-07-11 23:51:14 -04:00
silverwind
734e81d48c [skip ci] Updated translations via Crowdin 2022-07-12 00:10:13 +00:00
silverwind
c8e0fd0bcc
Add spectral linter for Swagger (#20321) 
[spectral](https://github.com/stoplightio/spectral) lints
openapi/swagger files for mistakes of which it has identified a few and
which I've fixed.

I had to put it into `lint-frontend` because it depends on node_modules
so can not run on Drone during the backend target. I plan to refactor
these targets later to `lint-js` and `lint-go` so that they are
categorized based on the tool dependencies.
 2022-07-11 18:07:16 -05:00
Gusted
8a7d1a3516
Store read access in access for team repo's (#20275) 
- Currently when a Team has read access to a organization's non-private
repository, their access won't be stored in the database. This caused
issue for code that rely on read access being stored. So from now-on if
we see that the repository is owned by a organization don't increase the
minMode to write permission.
- Resolves #20083
 2022-07-11 13:48:43 +02:00
Gusted
cb6c5f8193 [skip ci] Updated translations via Crowdin 2022-07-11 00:10:08 +00:00
Gusted
2399b5900a
Vertical align avatar at middle (#20302) 
- Currently the avatar in the navbar is being vertically aligned to the
top, this caused that the icon besides it isn't being at the middle of
the avatar. Use the `vm` helper class to force the `vertical-align` to
be `middle`.
- Resolves #20292
 2022-07-10 19:49:13 +01:00
KN4CK3R
e24b0fc7b8
Changed scroll to auto for some UI elements. (#20294) 
Addition to: Show scrollbar when necessary #20142
Fixes the "empty" scrollbars with Firefox.
 2022-07-10 20:58:26 +08:00
Steven Kriegler
9f3906b2a3
Add hint to GNUPGHOME environment variable (#20134) 
* Add hint for GNUPGHOME environment variable

With #19732, the default location for the `.gnupg` folder has changed. To mitigate this breaking change, users can specify the home directory for gnupg via `$GNUPGHOME` environment variable to keep using their current location.

* Update docs/content/doc/advanced/signing.en-us.md

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
 2022-07-10 17:04:46 +08:00
wxiaoguang
27e2def5f0
Refactor SSH init code, fix directory creation for TrustedUserCAKeys file (#20299) 
* Refactor SSH init code, fix directory creation for TrustedUserCAKeys file

* Update modules/ssh/init.go

Co-authored-by: zeripath <art27@cantab.net>

* fix lint copyright

* Update modules/ssh/init.go

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-07-10 14:50:26 +08:00
Gusted
a9e66cfdad [skip ci] Updated translations via Crowdin 2022-07-10 00:10:33 +00:00
Gusted
87c563b706
Use dedicated draft PR icon when possible (#20303) 
* Use dedicated draft PR icon when possible

- Currently the generic pull-request icon is used for draft PR's. This
patch changes that by using the dedicated icon for this.
- Resolves #20296

* Use draft title
 2022-07-09 17:17:04 -05:00
Gusted
11c0748146
Update goldmark (#20300) 
Update goldmark to v1.4.13 to fix a issue with quotes after a empty
list item(See https://github.com/yuin/goldmark/issues/313) and
downstream issue https://codeberg.org/Codeberg/Community/issues/645
 2022-07-09 19:58:22 +01:00
wxiaoguang
36353e27e6
Do not create empty ".ssh" directory when loading config (#20289) 
Creating the directory automatically is not correct.
In other places for ssh key writing (RewriteAllPrincipalKeys / appendAuthorizedKeysToFile, etc), the directory will still be created when updating the keys.
This PR will resolve the confusing and annoying problem: the dummy and empty ".ssh" directory in new git home.
 2022-07-09 22:32:18 +08:00
Chongyi Zheng
49f9d43afe
Implement sync push mirror on commit (#19411) 
Support synchronizing with the push mirrors whenever new commits are pushed or synced from pull mirror.

Related Issues: #18220

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-07-08 20:45:12 +01:00
wxiaoguang
496b8e3990
Use git.HOME_PATH for Git HOME directory (#20114) 
* Add git.HOME_PATH

* add legacy file check

* Apply suggestions from code review

Co-authored-by: zeripath <art27@cantab.net>

* pass env GNUPGHOME to git command, move the existing .gitconfig to new home, make the fix for 1.17rc more clear.

* set git.HOME_PATH for docker images to default HOME

* Revert "set git.HOME_PATH for docker images to default HOME"

This reverts commit f120101ddc267cef74e4f4b92c783d5fc8e275a1.

* force Gitea to use a stable GNUPGHOME directory

* extra check to ensure only process dir or symlink for legacy files

* refactor variable name

* The legacy dir check (for 1.17-rc1) could be removed with 1.18 release, since users should have upgraded from 1.17-rc to 1.17-stable

* Update modules/git/git.go

Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>

* remove initFixGitHome117rc

* Update git.go

* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-07-08 16:09:07 +08:00
Baoshuo Ren
c273dea508
Add tooltip to repo icons in explore page (#20241) 
* Add label to repo icons in explore page

Co-authored-by: silverwind <me@silverwind.io>
 2022-07-07 22:17:41 +02:00
Gusted
3f513f9e54
Fix NPE when using non-numeric (#20277) 
- This code is only valid when `refNumeric` exist(otherwise we didn't find
such numeric PR and can skip that check) and give a free-pas to the  "BEFORE" check when
`ref` is nil.
- Resolves #20109
 2022-07-07 17:46:49 +02:00
Tyrone Yeh
970288f0b2
Modify milestone search keywords to be case insensitive (#20266) 
Milestone search keywords are now sensitive, this modification is changed to insensitive
 2022-07-06 22:05:12 +01:00
zeripath
a704e4b547
Fix toolip on mobile notification bell (#20270) 
Unfortunately there is a bug in #20108 where the translation call was
not updated to use `.locale` from `.i18n`.

This PR updates the template to use `.locale`.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-06 22:03:52 +01:00
zeripath
354bfbe779
Allow RSA 2047 bit keys (#20272) 
Unfortunately it appears that 2048 bit RSA keys can occasionally be created in such
a way that they appear to have 2047 bit length. This PR simply changes our defaults to
allow these.

Fix #20249

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-06 16:49:27 -04:00
zeripath
1e43a88578
Refix notification bell placement (#20251) 
The use of `m-4 text black` for the notification bell results in this
icon being shifted upwards. Instead we should use the `item` class but
adjust `not-mobile` and `mobile-only` to make their `display: none`
settings `!important`.

(As an aside: This is probably one of the only times we should use
`!important` in our less files and the rest should be avoided or
removed.)

Ref #20069
Revert #20236

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-06 18:33:10 +01:00
dependabot[bot]
acbbbbfaf6
Bump mermaid from 9.1.1 to 9.1.2 (#20256) 
Bumps [mermaid](https://github.com/knsv/mermaid) from 9.1.1 to 9.1.2.
- [Release notes](https://github.com/knsv/mermaid/releases)
- [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/knsv/mermaid/compare/9.1.1...9.1.2)

---
updated-dependencies:
- dependency-name: mermaid
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-07-06 09:41:54 +08:00
zeripath
6efbe49439
EscapeFilter the group dn membership (#20200) 
The uid provided to the group filter must be properly escaped using the provided
ldap.EscapeFilter function.

Fix #20181

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-05 16:59:27 +01:00
zeripath
45f17528a8
Only show Followers that current user can access (#20220) 
Users who are following or being followed by a user should only be
displayed if the viewing user can see them.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-07-05 16:47:45 +01:00
Gusted
ed13d7aadf
Init popup for new code comment (#20234) 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix #20068
 2022-07-05 13:28:31 +01:00
wxiaoguang
f5c97172f0
Bypass Firefox (iOS) bug (#20244) 
* https://github.com/go-gitea/gitea/issues/20240

At the moment, Firefox (iOS) (10x) has an engine bug. See https://github.com/go-gitea/gitea/issues/20240
If a script inserts a newly created (and content changed) element into DOM, there will be a nonsense error event reporting: Script error: line 0, col 0.

This PR ignores such nonsense error event.

Fix #20240
 2022-07-05 13:27:13 +01:00
zeripath
8ee823037f
Adjust max-widths for the repository file table (#20243) 
Adjust the max-widths for the repository file table to allow for nicer
resizing of the names and commit messages.

Fix #20040

Signed-off-by: Andrew Thornton <art27@cantab.net>

## Screenshots

## MediaXL
![Screenshot from 2022-07-05 10-22-12](https://user-images.githubusercontent.com/1824502/177295867-7ba8cf60-8f61-4227-892f-e5a0477e4146.png)

## MediaLg
![Screenshot from 2022-07-05 10-24-37](https://user-images.githubusercontent.com/1824502/177296301-e066e206-10f7-4a15-a68b-0f772a95f369.png)

## MediaMd
![Screenshot from 2022-07-05 10-23-03](https://user-images.githubusercontent.com/1824502/177295965-69397649-16ca-456a-bc0c-ed507fcb7f44.png)

## MediaSm
![Screenshot from 2022-07-05 10-26-44](https://user-images.githubusercontent.com/1824502/177296700-ca2a853b-c47b-4592-baf4-4bc08a7e1c9c.png)
 2022-07-05 12:33:05 +01:00
Baekjun Kim
c4368fc6bc
Display full name (#20171) 
The setting `DEFAULT_SHOW_FULL_NAME` promises to use the user's full name everywhere it can be used.

Unfortunately the function `*user_model.User.ShortName()` currently uses the `.Name` instead - but this should also use the `.FullName()`.

Therefore we should make `*user_model.User.ShortName()` base its pre-shortened name on the `.FullName()` function.
 2022-07-05 12:30:05 +01:00
Tyrone Yeh
a168609e84
Adjust class for mobile has the problem of double small bells (#20236) 
* Adjust class for mobile has the problem of double small bells

* Update templates/base/head_navbar.tmpl

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
 2022-07-05 14:12:53 +08:00
Tyrone Yeh
c174bdc494
Adjust template for #20069 smallbell (#20108) 
* Adjust template for #20069 smallbell

* Adjust notification Unread Count variable to global and count bell position with mobile

* Adjust bell icon style

* Adjust smallbell to middle

* Avoid using inline styles

* move notificationUnreadCount to a general code block, reduce changed lines

* Solved conflicts

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
 2022-07-04 22:44:34 +08:00