Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spectral linter for Swagger #20321

Merged
merged 1 commit into from Jul 11, 2022
Merged

Conversation

silverwind
Copy link
Member

spectral lints openapi/swagger files for mistakes of which it has identified a few and which I've fixed.

I had to put it into lint-frontend because it depends on node_modules so can not run on Drone during the backend target. I plan to refactor these targets later to lint-js and lint-go so that they are categorized based on the tool dependencies.

[spectral](https://github.com/stoplightio/spectral) lints
openapi/swagger files for mistakes of which it has identified a few and
which I've fixed.

I had to put it into `lint-frontend` because it depends on node_modules
so can not run on Drone during the backend target. I plan to refactor
these targets later to `lint-js` and `lint-go` so that they are
categorized based on the tool dependencies.
@silverwind silverwind added this to the 1.18.0 milestone Jul 11, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 11, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 11, 2022
@jolheiser jolheiser merged commit c8e0fd0 into go-gitea:main Jul 11, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 12, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Add spectral linter for Swagger (go-gitea#20321)
  Store read access in access for team repo's (go-gitea#20275)
@silverwind silverwind deleted the spectral branch July 12, 2022 16:53
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
[spectral](https://github.com/stoplightio/spectral) lints
openapi/swagger files for mistakes of which it has identified a few and
which I've fixed.

I had to put it into `lint-frontend` because it depends on node_modules
so can not run on Drone during the backend target. I plan to refactor
these targets later to `lint-js` and `lint-go` so that they are
categorized based on the tool dependencies.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants