dotya.ml/gitea-templates
dotya.ml/gitea-templates
2
1
Fork 0
Code Issues 2 Pull Requests 1 Projects 2 Releases Activity

Invert logo colour based on current theme #9

Manually merged
dalahast merged 1 commits from dynamic-logo-color into master 2021-01-22 16:37:19 +01:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
custom/templates/base/head_navbar.tmpl
View File

@ -1,7 +1,7 @@
<div class="ui container" id="navbar">
<div class="item brand" style="justify-content: space-between;">
<a href="/">
<img class="ui mini image" src="/img/logo.svg" alt="git.dotya.ml icon">
<img class="ui mini image" {{if .SignedUser}}{{if not (eq .SignedUser.Theme "arc-green" "42l-dark" "42l-light")}}style="filter: invert(.8);"{{end}}{{else if not (eq DefaultTheme "arc-green" "42l-dark" "42l-light")}}style="filter: invert(.8);"{{end}} src="/img/logo.svg" alt="git.dotya.ml icon">
dalahast marked this conversation as resolved
dalahast commented 2021-01-22 15:08:18 +01:00
Review
Copy Link

Isn't there a dark/light parameter that could be used instead of an excplicit theme name? This is by all means ok for the current theme selection, but it would be better if this could be "set and forget".

Isn't there a dark/light parameter that could be used instead of an excplicit theme name? This is by all means ok for the current theme selection, but it would be better if this could be "set and forget".
wanderer commented 2021-01-22 15:51:57 +01:00
Review
Copy Link

this would of course be better served as part of each theme but that would require maintaining a fork for each theme whereas this is not too elegant but still easier - at least as a hotfix.

this would of course be better served as part of each theme but that would require maintaining a fork for each theme whereas this is not too elegant but still easier - at least as a hotfix.
dalahast commented 2021-01-22 16:36:50 +01:00
Review
Copy Link

Right, the themes are not expected to change for the foreseeable future so this is perfectly fine and indeed certainly better than maintaining a fork of each theme.

Right, the themes are not expected to change for the foreseeable future so this is perfectly fine and indeed certainly better than maintaining a fork of each theme.
wanderer commented 2021-01-22 20:19:11 +01:00
Review
Copy Link

it is kind of hacky but for now it's still better than the other solution :D or at least quicker.
it might take its toll on the server, since it needs to evaluate DefaultTheme and .SignedUser.Theme for each request, but that would be a bigger problem under different loads..
it's good to know what potential bottlenecks are, though.

it is kind of hacky but for now it's still better than the other solution :D or at least quicker. it might take its toll on the server, since it needs to evaluate `DefaultTheme` and `.SignedUser.Theme` for each request, but that would be a bigger problem under different loads.. it's *good* to know what potential bottlenecks are, though.
</a>
<div class="ui basic icon button mobile-only" id="navbar-expand-toggle">
<i class="sidebar icon"></i>