Isn't there a dark/light parameter that could be used instead of an excplicit theme name? This is by all means ok for the current theme selection, but it would be better if this could be "set and forget".
Isn't there a dark/light parameter that could be used instead of an excplicit theme name? This is by all means ok for the current theme selection, but it would be better if this could be "set and forget".
this would of course be better served as part of each theme but that would require maintaining a fork for each theme whereas this is not too elegant but still easier - at least as a hotfix.
this would of course be better served as part of each theme but that would require maintaining a fork for each theme whereas this is not too elegant but still easier - at least as a hotfix.
Right, the themes are not expected to change for the foreseeable future so this is perfectly fine and indeed certainly better than maintaining a fork of each theme.
Right, the themes are not expected to change for the foreseeable future so this is perfectly fine and indeed certainly better than maintaining a fork of each theme.
it is kind of hacky but for now it's still better than the other solution :D or at least quicker.
it might take its toll on the server, since it needs to evaluate DefaultTheme and .SignedUser.Theme for each request, but that would be a bigger problem under different loads..
it's good to know what potential bottlenecks are, though.
it is kind of hacky but for now it's still better than the other solution :D or at least quicker.
it might take its toll on the server, since it needs to evaluate `DefaultTheme` and `.SignedUser.Theme` for each request, but that would be a bigger problem under different loads..
it's *good* to know what potential bottlenecks are, though.
dalahast marked this conversation as resolved
dalahast
approved these changes 2021-01-22 16:37:06 +01:00
dalahast
manually merged commit 8ad2672dbe into master2021-01-22 16:37:19 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
dalahast
impacts visibility.
on light navbar inverts the logo colour (originally white) adding inline
style="filter: invert(.8);".screenshot light:
screenshot dark:
@dalahast please review an merge if ok.
@@ -2,3 +2,3 @@<div class="item brand" style="justify-content: space-between;"><a href="/"><img class="ui mini image" src="/img/logo.svg" alt="git.dotya.ml icon"><img class="ui mini image" {{if .SignedUser}}{{if not (eq .SignedUser.Theme "arc-green" "42l-dark" "42l-light")}}style="filter: invert(.8);"{{end}}{{else if not (eq DefaultTheme "arc-green" "42l-dark" "42l-light")}}style="filter: invert(.8);"{{end}} src="/img/logo.svg" alt="git.dotya.ml icon">Isn't there a dark/light parameter that could be used instead of an excplicit theme name? This is by all means ok for the current theme selection, but it would be better if this could be "set and forget".
this would of course be better served as part of each theme but that would require maintaining a fork for each theme whereas this is not too elegant but still easier - at least as a hotfix.
Right, the themes are not expected to change for the foreseeable future so this is perfectly fine and indeed certainly better than maintaining a fork of each theme.
it is kind of hacky but for now it's still better than the other solution :D or at least quicker.
it might take its toll on the server, since it needs to evaluate
DefaultThemeand.SignedUser.Themefor each request, but that would be a bigger problem under different loads..it's good to know what potential bottlenecks are, though.