16830 Commits

All Branches

Search

Author	SHA1	Message	Date
Lunny Xiao	df1e7d0067	Use db.Find instead of writing methods for every object (#28084) ... For those simple objects, it's unnecessary to write the find and count methods again and again.	2023-11-24 03:49:41 +00:00
NintenHero	d24a8223ce	Edit Discord Badge (#28188) ... Use white Discord icon. Label the badge as "Discord". Use the official Discord logo's color value of 5865F2.	2023-11-23 19:58:12 -05:00
Earl Warren	1075ff74b5	Use restricted sanitizer for repository description (#28141) ... - Currently the repository description uses the same sanitizer as a normal markdown document. This means that element such as heading and images are allowed and can be abused. - Create a minimal restricted sanitizer for the repository description, which only allows what the postprocessor currently allows, which are links and emojis. - Added unit testing. - Resolves https://codeberg.org/forgejo/forgejo/issues/1202 - Resolves https://codeberg.org/Codeberg/Community/issues/1122 (cherry picked from commit 631c87cc2347f0036a75dcd21e24429bbca28207) Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-11-23 16:34:25 +00:00
Nanguan Lin	7d1933717d	Use full width for PR comparison (#28182) ... Follow-up #22844 close #28142 Before  After  Co-authored-by: Giteabot <teabot@gitea.io>	2023-11-23 15:52:57 +00:00
wxiaoguang	7c0ab8b974	Make CORS work for oauth2 handlers (#28184) ... Fix #25473 Although there was `m.Post("/login/oauth/access_token", CorsHandler()...`, it never really worked, because it still lacks the "OPTIONS" handler.	2023-11-23 21:19:26 +08:00
Nanguan Lin	778d604346	Fix missing buttons (#28179) ... fix #28173 regression #25948 That PR is supposed to only change the style but somehow delete a code snippet. See the diff(https://github.com/go-gitea/gitea/pull/25948/files#diff-7c36d66fe058f4ff9f2beaac73cf710dca45b350d0dd98daf806828a4745fe62L125-L129) for details. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-11-23 11:36:52 +01:00
Nanguan Lin	37ed92d6fd	Revert "Fix EOL handling in web editor" (#28101) ... Reverts go-gitea/gitea#27141 close #28097	2023-11-22 09:14:16 +00:00
yp05327	4d0eba8e0a	Fix swagger title (#28164) ...  Don't know why there's a `.` behind. 🤔	2023-11-22 08:09:19 +00:00
yp05327	2d9b91aa24	Fix the description about the default setting for action in quick start document (#28160) ... Since #27054, Actions are enabled by default. so we should also edit the document. 😃 ps: I think this should be backport to 1.21.0.	2023-11-22 02:11:22 +00:00
yp05327	d1acd7e9de	Do not display search box when there's no packages yet (#28146) ... Before:  After:   	2023-11-21 20:03:19 +00:00
yp05327	a6a674e26a	Add guide page to actions when there's no workflows (#28145) ... Before:  After: 	2023-11-21 08:27:33 +00:00
yp05327	976a9926d7	Fix no ActionTaskOutput table waring (#28149) ... Reproduce: - Create a new Gitea instance - Register a runner - Create a repo and add a workflow - Check the log, you will see warnings:  It comes from:  The reason is that we forgot registering `ActionTaskOutput` model. So `action_table_output` table will be missing in your db.	2023-11-21 08:02:51 +00:00
Lunny Xiao	0c0d17f17e	Fix empty action run title (#28113) ... Fix #27901	2023-11-21 03:00:59 +00:00
wxiaoguang	247927a9b5	Use "is-loading" to avoid duplicate form submit for code comment (#28143) ... When the form is going to be submitted, add the "is-loading" class to show an indicator and avoid user UI events. When the request finishes (success / error), remove the "is-loading" class to make user can interact the UI.	2023-11-21 02:12:31 +00:00
Jason Song	0c72256ab4	Fix typo in `packages.cleanup.success` (#28133) ... Follow https://github.com/go-gitea/gitea/pull/28129#discussion_r1398971596	2023-11-20 15:41:10 +02:00
JakobDev	08552f0076	Add edit option for README.md (#28071) ... Fix #28059 	2023-11-20 11:47:55 +00:00
yp05327	eae555ff23	Remove autofocus in search box (#28033) ... Mentioned here: https://github.com/go-gitea/gitea/pull/27982#issuecomment-1807923026	2023-11-20 08:57:46 +00:00
Jason Song	0e1b381ff6	Add missing `packages.cleanup.success` (#28129) ... Used at a3348bfc4d/routers/web/admin/packages.go (L111) <img width="1325" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/60edc1fa-eea8-4d74-a7ec-96bd5461a53f">	2023-11-20 08:33:58 +00:00
John Olheiser	30b46fb6fa	Update docs for docusaurus v3 (#28125) ... Updates the docs for usage with docusaurus v3 Signed-off-by: jolheiser <john.olheiser@gmail.com>	2023-11-20 00:25:47 -05:00
GiteaBot	a3348bfc4d	[skip ci] Updated translations via Crowdin	2023-11-20 00:25:03 +00:00
silverwind	06dcb251f3	Update JS and PY dependencies (#28120) ... - Update all JS and PY dependencies minus `@mcaptcha/vanilla-glue` - Adapt to eslint rule rename - Regenerate all SVGs because of [new optimizations](https://github.com/svg/svgo/releases/tag/v3.0.4) from svgo. - Tested mentions, mermaid, vue, api docs	2023-11-20 01:02:57 +01:00
KazzmanK	2de05f9432	Decrease issue font size in project template (#28054) ... I propose to decrease font size. 18 is too big and looks ugly, on windows. 14 is on par with other elements and save a bit of space.   Co-authored-by: Nikolay Kobzarev <n.kobzarev@aeronavigator.ru>	2023-11-19 02:02:26 +00:00
delvh	0bf021d7c6	Require clear descriptions both for feature and breaking PRs prior to the merge (#28112) ... When writing the release blog, it is really annoying and time-consuming to re-discover and write down how a feature behaves and capture a screenshot of it, for every single feature merged since the last release. This should not be the responsibility of maintainers, but rather of the person implementing a feature in the first place. They know best how to use the feature and how to gather screenshots for it. Similarly for breaking changes and their effects. As such, let's require everything to be up-to-date and easily understandable before merging features or breaking changes.	2023-11-19 09:53:31 +08:00
Denys Konovalov	816e46ee7c	add skip ci functionality (#28075) ... Adds the possibility to skip workflow execution if the commit message contains a string like [skip ci] or similar. The default strings are the same as on GitHub, users can also set custom ones in app.ini Reference: https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs Close #28020	2023-11-18 13:37:08 +02:00
yp05327	e88377470a	Fix project counter in organization/individual profile (#28068) ... Fix #28052 Before:   After:  	2023-11-18 11:02:42 +08:00
sebastian-sauer	e31c6cfe6e	Fix Show/hide filetree button on small displays (#27881) ... the gt-df's display:flex !important did override the display:none on small displays --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-11-17 18:35:51 +00:00
Nanguan Lin	f63b116697	Change default size of attachments and repo files (#28100) ... https://github.com/go-gitea/gitea/pull/27946 forgets to change them in code. Sorry about that.	2023-11-17 11:42:00 +00:00
KN4CK3R	58f5fa6536	Fix Matrix and MSTeams nil dereference (#28089) ... Fixes #28088 Fixes #28094 Added missing tests. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-11-17 12:17:33 +01:00
wxiaoguang	17d246cdcc	Fix incorrect pgsql conn builder behavior (#28085) ... Fix #28083 and fix the tests	2023-11-17 02:30:57 +00:00
wxiaoguang	fce1d5d7dc	Fix system config cache expiration timing (#28072) ... To avoid unnecessary database access, the `cacheTime` should always be set if the revision has been checked. Fix #28057	2023-11-16 12:53:42 +00:00
sebastian-sauer	49dddd87b1	Improve PR diff view on mobile (#27883) ... 1. Show diff stats only on large screens these are already shown in tabs, so no need for this duplicate information on small screens   2. Hide viewed files information on small screens Github does the same and this gives us more free space on small screens   3. Review bar now doesn't wrap so we don't need the 77px even on very small screens (the sticky headers are still working) 	2023-11-16 11:58:53 +08:00
wxiaoguang	79394b340d	Improve graceful manager code/comment (#28063) ... The graceful manager has some bugs (#27643, #28062). This is a preparation for further fixes.	2023-11-15 22:02:46 +08:00
Lunny Xiao	f65977df3a	Revert "packages: Calculate package size quota using package creator ID instead of owner ID (#28007)" (#28049) ... This reverts commit #28007 60522fc96f.	2023-11-14 16:03:56 +01:00
6543	5ab3782f11	Restricted users only see repos in orgs which their team was assigned to (#28025) ... --- *Sponsored by Kithara Software GmbH*	2023-11-14 15:23:04 +01:00
6543	d4d05f9f1b	Fix release link in changelog for v1.21.0	2023-11-14 15:03:49 +01:00
Denys Konovalov	58b2779986	Add v1.21.0 changelog (#28005) ... Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: silverwind <me@silverwind.io>	2023-11-14 14:55:16 +01:00
JakobDev	48b9d98593	Fix viewing wiki commit on empty repo (#28040) ... Fixes https://codeberg.org/forgejo/forgejo/issues/1758 For some weird reason we need to cast this nil.	2023-11-14 19:42:23 +08:00
yp05327	83c30634a4	Add word break to the repo list in admin settings page (#28034) ... Before:  After: 	2023-11-14 04:58:01 +00:00
Anudeep Reddy	5380fd5d6d	fixed duplicate attachments on dump on windows (#28019) ... Hi, This PR fixes #27988. The use of `path.join`(which uses `/` as the file separator) to construct paths and comparing them with paths constructed using `filepath.join`(which uses platform specific file separator) is the root cause of this issue. The desired behavior is to ignore attachments when dumping data directory. Due to the what's mentioned above, the function `addRecursiveExclude` is not actually ignoring the attachments directory and is being written to the archive. The attachment directory is again added to the archive (with different file separator as mentioned in the issue) causing a duplicate entry on windows. The solution is to use `filepath.join` in `addResursiveExclude` to construct `currentAbsPath`.	2023-11-14 02:15:45 +01:00
GiteaBot	f586937297	[skip ci] Updated translations via Crowdin	2023-11-14 00:23:48 +00:00
Danila Fominykh	60522fc96f	packages: Calculate package size quota using package creator ID instead of owner ID (#28007) ... Changed behavior to calculate package quota limit using package `creator ID` instead of `owner ID`. Currently, users are allowed to create an unlimited number of organizations, each of which has its own package limit quota, resulting in the ability for users to have unlimited package space in different organization scopes. This fix will calculate package quota based on `package version creator ID` instead of `package version owner ID` (which might be organization), so that users are not allowed to take more space than configured package settings. Also, there is a side case in which users can publish packages to a specific package version, initially published by different user, taking that user package size quota. Version in fix should be better because the total amount of space is limited to the quota for users sharing the same organization scope.	2023-11-14 00:38:50 +01:00
6543	c6366089df	Dont leak private users via extensions (#28023)	2023-11-13 16:30:24 -06:00
yp05327	089ac06969	Improve profile for Organizations (#27982) ... Fixes some problems in #27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In #26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: https://github.com/go-gitea/gitea/pull/27955#issuecomment-1803178239 But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>	2023-11-13 15:33:22 +01:00
Earl Warren	340055ab6c	Enable system users search via the API (#28013) ... Refs: https://codeberg.org/forgejo/forgejo/issues/1403 (cherry picked from commit dd4d17c159eaf8b642aa9e6105b0532e25972bb7)	2023-11-13 15:31:38 +01:00
Earl Warren	f2ea31de36	Enable system users for comment.LoadPoster (#28014) ... System users (Ghost, ActionsUser, etc) have a negative id and may be the author of a comment, either because it was created by a now deleted user or via an action using a transient token. The GetPossibleUserByID function has special cases related to system users and will not fail if given a negative id. Refs: https://codeberg.org/forgejo/forgejo/issues/1425 (cherry picked from commit 6a2d2fa24390116d31ae2507c0a93d423f690b7b)	2023-11-13 15:30:08 +01:00
Nanguan Lin	0678c82265	Change default size of issue/pr attachments and repo file (#27946) ... As title. Some attachments and file sizes can easily be larger than these limits	2023-11-13 14:19:22 +00:00
KN4CK3R	3081e7e153	Fix missing mail reply address (#27997) ... Fixes https://codeberg.org/forgejo/forgejo/issues/1458 Some mails such as issue creation mails are missing the reply-to-comment address. This PR fixes that and specifies which comment types should get a reply-possibility.	2023-11-13 03:20:34 +00:00
GiteaBot	024fe11cd3	[skip ci] Updated licenses and gitignores	2023-11-13 00:24:40 +00:00
Nanguan Lin	d95102d650	Fix wrong xorm Delete usage (#27995) ... ## Bug in Gitea I ran into this bug when I accidentally used the wrong redirect URL for the oauth2 provider when using mssql. But the oauth2 provider still got added. Most of the time, we use `Delete(&some{id: some.id})` or `In(condition).Delete(&some{})`, which specify the conditions. But the function uses `Delete(source)` when `source.Cfg` is a `TEXT` field and not empty. This will cause xorm `Delete` function not working in mssql. 61ff91f960/models/auth/source.go (L234-L240) ## Reason Because the `TEXT` field can not be compared in mssql, xorm doesn't support it according to [this PR](https://gitea.com/xorm/xorm/pulls/2062) [related code](b23798dc98/internal/statements/statement.go (L552-L558)) in xorm ```go if statement.dialect.URI().DBType == schemas.MSSQL && (col.SQLType.Name == schemas.Text ||   col.SQLType.IsBlob() || col.SQLType.Name == schemas.TimeStampz) {   if utils.IsValueZero(fieldValue) {   continue   }   return nil, fmt.Errorf("column %s is a TEXT type with data %#v which cannot be as compare condition", col.Name, fieldValue.Interface())   } } ``` When using the `Delete` function in xorm, the non-empty fields will auto-set as conditions(perhaps some special fields are not?). If `TEXT` field is not empty, xorm will return an error. I only found this usage after searching, but maybe there is something I missing. --------- Co-authored-by: delvh <dev.lh@web.de>	2023-11-12 07:38:45 +00:00
wxiaoguang	f860fe31d9	Move some JS code from `fomantic.js` to standalone files (#27994) ... To improve maintainability, this PR: 1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic` (the code there are all for aria of fomantic) 2. Move api/transition related code to `web_src/js/modules/fomantic/api.js` and `web_src/js/modules/fomantic/transition.js` No logic is changed.	2023-11-12 07:15:00 +00:00