17042 Commits

All Branches

Search

Author	SHA1	Message	Date
yp05327	b60a7c3358	Return `responseText` instead of string in some functions (#28836) ... Follow https://github.com/go-gitea/gitea/pull/28796#issuecomment-1891727591	2024-01-19 10:45:23 +08:00
yp05327	4674aea25b	Fix display latest sync time for pull mirrors on the repo page (#28841) ... Follow #28712 1. Missing Locale word `mirror_sync` 2. Maybe forgot checking the conflict from #27760 Before:  After: 	2024-01-18 18:27:07 +08:00
Lunny Xiao	eba9c0ce48	Add testing for CalcCommitStatus (#28823)	2024-01-17 13:27:59 +00:00
Lunny Xiao	c8ba17c73f	Remove duplicated checkinit on git module (#28824) ... `checkInit` has been invoked in `InitSimple`. So it's unnecessary to invoke it twice in `InitFull`.	2024-01-17 09:56:00 +00:00
Lunny Xiao	2bdab948cb	Add missing migration (#28827) ... Missed from #28498	2024-01-17 17:26:45 +08:00
FuXiaoHei	ad98ea63ee	Fix uploaded artifacts should be overwritten (#28726) ... Fix `Uploaded artifacts should be overwritten` https://github.com/go-gitea/gitea/issues/28549 When upload different content to uploaded artifact, it checks that content size is not match in db record with previous artifact size, then the new artifact is refused. Now if it finds uploading content size is not matching db record when receiving chunks, it updates db records to follow the latest size value.	2024-01-17 11:21:16 +08:00
Viktor Kuzmin	49eb168677	Retarget depending pulls when the parent branch is deleted (#28686) ... Sometimes you need to work on a feature which depends on another (unmerged) feature. In this case, you may create a PR based on that feature instead of the main branch. Currently, such PRs will be closed without the possibility to reopen in case the parent feature is merged and its branch is deleted. Automatic target branch change make life a lot easier in such cases. Github and Bitbucket behave in such way. Example: $PR_1$: main <- feature1 $PR_2$: feature1 <- feature2 Currently, merging $PR_1$ and deleting its branch leads to $PR_2$ being closed without the possibility to reopen. This is both annoying and loses the review history when you open a new PR. With this change, $PR_2$ will change its target branch to main ($PR_2$: main <- feature2) after $PR_1$ has been merged and its branch has been deleted. This behavior is enabled by default but can be disabled. For security reasons, this target branch change will not be executed when merging PRs targeting another repo. Fixes #27062 Fixes #18408 --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: delvh <dev.lh@web.de>	2024-01-17 01:44:56 +01:00
Yarden Shoham	9c869b10b5	Bump `@github/relative-time-element` to 4.3.1 (#28819) ... - Fixes https://github.com/go-gitea/gitea/issues/28747 # Before  # After  Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2024-01-16 22:52:19 +01:00
Mihir Joshi	b8270240bf	Fix reverting a merge commit failing (#28794) ... Fixes #22236 --- Error occurring currently while trying to revert commit using read-tree -m approach: > 2022/12/26 16:04:43 ...rvices/pull/patch.go:240:AttemptThreeWayMerge() [E] [63a9c61a] Unable to run read-tree -m! Error: exit status 128 - fatal: this operation must be run in a work tree > - fatal: this operation must be run in a work tree We need to clone a non-bare repository for `git read-tree -m` to work. bb371aee6e adds support to create a non-bare cloned temporary upload repository. After cloning a non-bare temporary upload repository, we [set default index](https://github.com/go-gitea/gitea/blob/main/services/repository/files/cherry_pick.go#L37) (`git read-tree HEAD`). This operation ends up resetting the git index file (see investigation details below), due to which, we need to call `git update-index --refresh` afterward. Here's the diff of the index file before and after we execute SetDefaultIndex: https://www.diffchecker.com/hyOP3eJy/ Notice the **ctime**, **mtime** are set to 0 after SetDefaultIndex. You can reproduce the same behavior using these steps: ```bash $ git clone https://try.gitea.io/me-heer/test.git -s -b main $ cd test $ git read-tree HEAD $ git read-tree -m 1f085d7ed8 1f085d7ed8 9933caed00 error: Entry '1' not uptodate. Cannot merge. ``` After which, we can fix like this: ``` $ git update-index --refresh $ git read-tree -m 1f085d7ed8 1f085d7ed8 9933caed00 ```	2024-01-16 15:06:51 +00:00
JakobDev	edfb57e699	Render code block in activity tab (#28816) ... This is a little bugfix. Inline code is usually rendered in issue titles, but it is missing in the activity tab. Before:  After: 	2024-01-16 22:38:09 +08:00
Lunny Xiao	c08d263a19	Remove trust model selection from repository creation on web page because it can be changed in settings later (#28814) ... As more and more options can be set for creating the repository, I don't think we should put all of them into the creation web page which will make things look complicated and confusing. And I think we need some rules about how to decide which should/should not be put in creating a repository page. One rule I can imagine is if this option can be changed later and it's not a MUST on the creation, then it can be removed on the page. So I found trust model is the first one. This PR removed the trust model selections on creating a repository web page and kept others as before. This is also a preparation for #23894 which will add a choice about SHA1 or SHA256 that cannot be changed once the repository created.	2024-01-16 20:54:48 +08:00
Lunny Xiao	930e38d010	Use refname:strip-2 instead of refname:short when syncing tags (#28797) ... Fix #28694 Generally, `refname:short` should be equal to `refname:lstrip=2` except `core.warnAmbiguousRefs is used to select the strict abbreviation mode.` ref: https://git-scm.com/docs/git-for-each-ref#Documentation/git-for-each-ref.txt-refname	2024-01-16 08:13:07 +01:00
crapStone	5374d29aa9	Add gist to comparison (#28809) ... This PR adds a section to the documentation that links to the project [Opengist](https://github.com/thomiceli/opengist) on GitHub. The feature was proposed in #16670 but didn't resonate well with the maintainers.	2024-01-15 23:37:32 +01:00
Denys Konovalov	d971dfbae1	Fix links in issue card (#28806) ... Fixes_ https://github.com/go-gitea/gitea/issues/23318#issuecomment-1611086747	2024-01-15 22:38:13 +02:00
JakobDev	885cc32b14	Show latest commit for file (#28067) ... If you view a file, you can now see the latest commit that changed that file.  --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de>	2024-01-15 17:42:15 +01:00
Gwyneth Morgan	2c3da59e27	Add ability to see open and closed issues at the same time (#28757) ... By clicking the currently active "Open" or "Closed" filter button in the issue list, the user can toggle that filter off in order to see all issues regardless of state. The URL "state" parameter will be set to "all" and the "Open"/"Closed" button will not show as active.	2024-01-15 15:07:22 +00:00
Dmitry Sharshakov	2d343f8987	Display latest sync time for pull mirrors on the repo page (#28712) ... Fixes #25168 --------- Co-authored-by: delvh <dev.lh@web.de>	2024-01-15 14:37:14 +00:00
KN4CK3R	3793ec4d14	Fix `GetCommitStatuses` (#28787) ... Fixes #28764.	2024-01-15 14:07:32 +00:00
wxiaoguang	b0e6c25535	Caller should check the ResponseExtra.HasError() first to see whether the request fails (#28796) ... `resp != nil` doesn't mean the request really succeeded. Add a comment for requestJSONResp to clarify the behavior.	2024-01-15 11:15:31 +00:00
KN4CK3R	637451a45e	Rework markup link rendering (#26745) ... Fixes #26548 This PR refactors the rendering of markup links. The old code uses `strings.Replace` to change some urls while the new code uses more context to decide which link should be generated. The added tests should ensure the same output for the old and new behaviour (besides the bug). We may need to refactor the rendering a bit more to make it clear how the different helper methods render the input string. There are lots of options (resolve links / images / mentions / git hashes / emojis / ...) but you don't really know what helper uses which options. For example, we currently support images in the user description which should not be allowed I think: <details> <summary>Profile</summary> https://try.gitea.io/KN4CK3R  </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-01-15 08:49:24 +00:00
yp05327	c7e4629c02	Fix nil pointer panic when exec some gitea cli command (#28791) ... panic:  After: 	2024-01-15 07:43:53 +00:00
Jimmy Praet	5d3fdd1212	Add branch protection setting for ignoring stale approvals (#28498) ... Fixes #27114. * In Gitea 1.12 (#9532), a "dismiss stale approvals" branch protection setting was introduced, for ignoring stale reviews when verifying the approval count of a pull request. * In Gitea 1.14 (#12674), the "dismiss review" feature was added. * This caused confusion with users (#25858), as "dismiss" now means 2 different things. * In Gitea 1.20 (#25882), the behavior of the "dismiss stale approvals" branch protection was modified to actually dismiss the stale review. For some users this new behavior of dismissing the stale reviews is not desirable. So this PR reintroduces the old behavior as a new "ignore stale approvals" branch protection setting. --------- Co-authored-by: delvh <dev.lh@web.de>	2024-01-15 07:20:01 +00:00
yp05327	ce0225c1b8	Forbid removing the last admin user (#28337) ... Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2024-01-15 06:51:43 +00:00
yp05327	b820019fec	Fix when private user following user, private user will not be counted in his own view (#28037) ... Doer: asdasasdasasdasasdasasdasasdasasdasasdas (private user) Followed: TestUser (public user) Before: (From doer's view)  (From followed user's view, can see doer)  After: (From doer's view) 	2024-01-15 05:43:14 +00:00
Chongyi Zheng	fee80a1847	Update github.com/cloudflare/circl (#28789) ... cloudflare/circl: https://github.com/advisories/GHSA-9763-4f94-gfch Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2024-01-15 11:14:26 +08:00
Lunny Xiao	70c4aad8e1	Move more functions to db.Find (#28419) ... Following #28220 This PR move more functions to use `db.Find`. --------- Co-authored-by: delvh <dev.lh@web.de>	2024-01-15 02:19:25 +00:00
Gwyneth Morgan	e5313248a8	Add non-JS fallback for reaction tooltips (#28785) ... When JavaScript is not loaded, fall back to displaying reaction tooltips with the default browser `title` attribute. An element with a present but empty `data-tooltip-content` will use the `title` attribute for its tippy.js tooltip content, so when JavaScript is enabled, this functions the same as the current behavior.	2024-01-15 09:42:59 +08:00
Earl Warren	3f342d6dff	Modernize merge button (#28140) ... - Make use of the `form-fetch-action` for the merge button, which will automatically prevent the action from happening multiple times and show a nice loading indicator as user feedback while the merge request is being processed by the server. - Adjust the merge PR code to JSON response as this is required for the `form-fetch-action` functionality. - Resolves https://codeberg.org/forgejo/forgejo/issues/774 - Likely resolves the cause of https://codeberg.org/forgejo/forgejo/issues/1688#issuecomment-1313044 (cherry picked from commit 4ec64c19507caefff7ddaad722b1b5792b97cc5a) Co-authored-by: Gusted <postmaster@gusted.xyz>	2024-01-15 00:00:47 +02:00
Yarden Shoham	5a7bacb005	Warn that `DISABLE_QUERY_AUTH_TOKEN` is false only if it's explicitly defined (#28783) ... So we don't warn on default behavior - Fixes https://github.com/go-gitea/gitea/issues/28758 - Follows https://github.com/go-gitea/gitea/pull/28390 Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2024-01-14 21:20:18 +01:00
Lunny Xiao	fa8c3beb26	Speed up loading the dashboard on mysql/mariadb (#28546) ... Fixes #28155	2024-01-14 15:34:25 +01:00
Lunny Xiao	97292da960	Fix schedule tasks bugs (#28691) ... Fix #28157 This PR fix the possible bugs about actions schedule. ## The Changes - Move `UpdateRepositoryUnit` and `SetRepoDefaultBranch` from models to service layer - Remove schedules plan from database and cancel waiting & running schedules tasks in this repository when actions unit has been disabled or global disabled. - Remove schedules plan from database and cancel waiting & running schedules tasks in this repository when default branch changed.	2024-01-12 21:50:38 +00:00
Jack Hay	6c6823935c	Add tests for #28765 (#28773) ... Adds tests to cover changes made in #28765	2024-01-12 17:15:42 +00:00
Nanguan Lin	9b59af37e7	Fix issue dependencies (#27736) ... Fix #27722 Fix #27357 Fix #25837 1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the `not permitted message` not to show. The correct one is `Blocking` or `BlockedBy` 2. Rewrite the perm check. The perm check uses a very tricky way to avoid duplicate checks for a slice of issues, which is confusing. In fact, it's also the reason causing the bug. It uses `lastRepoID` and `lastPerm` to avoid duplicate checks, but forgets to assign the `lastPerm` at the end of the code block. So I rewrote this to avoid this trick.  3. It also reuses the `blocks` slice, which is even more confusing. So I rewrote this too. 	2024-01-12 16:49:02 +00:00
Denys Konovalov	4f8f5f6e25	Assign pull request to project during creation (#28227) ... When creating a pull request, allow directly assigning it to a project, as it is already possible for issues. After: 	2024-01-12 15:25:15 +00:00
wxiaoguang	ad0b637d46	Fix button size in "attached header right" (#28770) ... Before: <details>   </details> After:  	2024-01-12 14:43:40 +00:00
wxiaoguang	34a0684397	Improve CSS helper naming (#28769) ... * `gt-w-100` => `gt-w-full` to match tailwind * clarify `gt-hidden` priority	2024-01-12 20:28:01 +08:00
Denys Konovalov	7d62615513	Revamp repo header (#27760) ... Redesign repo header with following new aspects: - responsive & better-looking repo title - hide repo button text instead of icons in mobile view - use same tab style as on explore and org page <details> <summary>Before:</summary>     </details> <details> <summary>After:</summary>    	2024-01-12 03:44:06 +00:00
Exploding Dragon	ba4d0b8ffb	Support for grouping RPMs using paths (#26984) ... The current rpm repository places all packages in the same repository, and different systems (el7,f34) may hit packages that do not belong to this distribution ( #25304 ) , which now supports grouping of rpm.  Fixes #25304 . Fixes #27056 . Refactor: [#25866](https://github.com/go-gitea/gitea/pull/25866)	2024-01-12 03:16:05 +00:00
Jack Hay	7c2f093e85	Require token for GET subscription endpoint (#28765) ... Fixes #28756 ## Changes - Require and check API token for `GET /repos/{owner}/{repo}/subscription` in order to populate `ctx.Doer`.	2024-01-12 01:57:58 +00:00
KN4CK3R	595a9291b6	Fix `convert.ToTeams` on empty input (#28426) ... Fixes #28420 Don't return `nil` if the input was empty.	2024-01-11 22:12:08 +00:00
delvh	abfdaef5bd	Show description as tooltip instead of title for labels (#28754) ... Follow GitHubs behavior of showing the label description as a tooltip instead of the browser native title. ## Before  ## After 	2024-01-12 00:21:52 +08:00
Mihir Joshi	669bbbaf24	Integration Test for Commit Search containing Square Brackets (#28751) ... Integration test for #28744 Change keywords commit search flag from `-F` to `--fixed-strings` for readability	2024-01-11 11:04:45 +08:00
Lunny Xiao	c65f8623e6	Hide code related setting options in repository when code unit is disabled (#28631) ... Since #20805, code can be hidden. However, the related settings are still shown even though they don't have any meaning then. https://github.com/go-gitea/gitea/assets/81045/5fdee54d-ac81-418a-82f7-eadff048cedd	2024-01-10 11:55:59 +00:00
Mihir Joshi	839cd26b1a	Add -F to commit search to treat keywords as strings (#28744) ... Fixes #28269 The [default behavior](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp) of --grep in git log is to interpret the keyword as a regular expression. This causes the search to fail in the cases where the search keyword contains a `[`, since `[` is a special character used in grep. If we want our keywords to be interpreted as 'strings', we should use [-F flag](https://git-scm.com/docs/git-log#Documentation/git-log.txt---basic-regexp).	2024-01-10 11:28:20 +00:00
wxiaoguang	2df7563f31	Recommend/convert to use case-sensitive collation for MySQL/MSSQL (#28662) ... Mainly for MySQL/MSSQL. It is important for Gitea to use case-sensitive database charset collation. If the database is using a case-insensitive collation, Gitea will show startup error/warning messages, and show the errors/warnings on the admin panel's Self-Check page. Make `gitea doctor convert` work for MySQL to convert the collations of database & tables & columns. * Fix #28131 ## ⚠️ BREAKING ⚠️ It is not quite breaking, but it's highly recommended to convert the database&table&column to a consistent and case-sensitive collation.	2024-01-10 11:03:23 +00:00
JakobDev	a80debc208	Add download attribute to release attachments (#28739) ... Fixes #28736	2024-01-09 16:51:20 +08:00
Earl Warren	aa4d78431f	Concatenate error in `checkIfPRContentChanged` (#28731) ... - If there's a error with the Git command in `checkIfPRContentChanged` the stderr wasn't concatendated to the error, which results in still not knowing why an error happend. - Adds concatenation for stderr to the returned error. - Ref: https://codeberg.org/forgejo/forgejo/issues/2077 Co-authored-by: Gusted <postmaster@gusted.xyz>	2024-01-09 10:32:14 +08:00
GiteaBot	f4ea8d9a6c	[skip ci] Updated licenses and gitignores	2024-01-08 00:26:06 +00:00
wxiaoguang	a04f8c0f81	Move the captcha script loader to the template which really needs it (#28718) ... It improves the maintainability for the templates. Now `base/footer.tmpl` doesn't need to depend on "captcha" feature.	2024-01-07 15:41:46 +00:00
wxiaoguang	79da4bbc56	Suggest to use Type=simple for systemd service (#28717) ... Although the systemd notify support was added, it seems that there are some problems (#28553, for the "non-installed" instance)	2024-01-07 15:18:04 +00:00