1
0
Fork 0
mirror of https://github.com/containers/youki synced 2024-05-25 08:56:07 +02:00
youki/crates/libcontainer/src/container/init_builder.rs
Yashodhan 601df9ecd3
Fix cgroups determination in exec implementation (#2720)
* Set cgroups path for tenant containers from main container

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Ignore new_user_ns for creating cgroups path

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Remove user_ns param completely

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Add tests in podman rootless for exec

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Fix add_task implementation for cgroups v2 and systemd

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* minor refactor in tenant builder

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Add unit test for systemd add_task function

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Fix task addition to properly add tasks via dbus api

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

* Fix cross cotainers for tests running

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>

---------

Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
2024-04-27 21:49:58 +09:00

213 lines
7.0 KiB
Rust

use nix::unistd;
use oci_spec::runtime::Spec;
use std::{
fs,
path::{Path, PathBuf},
rc::Rc,
};
use user_ns::UserNamespaceConfig;
use crate::{
apparmor,
config::YoukiConfig,
error::{ErrInvalidSpec, LibcontainerError, MissingSpecError},
notify_socket::NOTIFY_FILE,
process::args::ContainerType,
tty, user_ns, utils,
};
use super::{
builder::ContainerBuilder, builder_impl::ContainerBuilderImpl, Container, ContainerStatus,
};
// Builder that can be used to configure the properties of a new container
pub struct InitContainerBuilder {
base: ContainerBuilder,
bundle: PathBuf,
use_systemd: bool,
detached: bool,
}
impl InitContainerBuilder {
/// Generates the base configuration for a new container from which
/// configuration methods can be chained
pub(super) fn new(builder: ContainerBuilder, bundle: PathBuf) -> Self {
Self {
base: builder,
bundle,
use_systemd: true,
detached: true,
}
}
/// Sets if systemd should be used for managing cgroups
pub fn with_systemd(mut self, should_use: bool) -> Self {
self.use_systemd = should_use;
self
}
pub fn with_detach(mut self, detached: bool) -> Self {
self.detached = detached;
self
}
/// Creates a new container
pub fn build(self) -> Result<Container, LibcontainerError> {
let spec = self.load_spec()?;
let container_dir = self.create_container_dir()?;
let mut container = self.create_container_state(&container_dir)?;
container
.set_systemd(self.use_systemd)
.set_annotations(spec.annotations().clone());
unistd::chdir(&container_dir).map_err(|err| {
tracing::error!(
?container_dir,
?err,
"failed to chdir into the container directory"
);
LibcontainerError::OtherSyscall(err)
})?;
let notify_path = container_dir.join(NOTIFY_FILE);
// convert path of root file system of the container to absolute path
let rootfs = fs::canonicalize(spec.root().as_ref().ok_or(MissingSpecError::Root)?.path())
.map_err(LibcontainerError::OtherIO)?;
// if socket file path is given in commandline options,
// get file descriptors of console socket
let csocketfd = if let Some(console_socket) = &self.base.console_socket {
Some(tty::setup_console_socket(
&container_dir,
console_socket,
"console-socket",
)?)
} else {
None
};
let user_ns_config = UserNamespaceConfig::new(&spec)?;
let config = YoukiConfig::from_spec(&spec, container.id())?;
config.save(&container_dir).map_err(|err| {
tracing::error!(?container_dir, "failed to save config: {}", err);
err
})?;
let mut builder_impl = ContainerBuilderImpl {
container_type: ContainerType::InitContainer,
syscall: self.base.syscall,
container_id: self.base.container_id,
pid_file: self.base.pid_file,
console_socket: csocketfd,
use_systemd: self.use_systemd,
spec: Rc::new(spec),
rootfs,
user_ns_config,
notify_path,
container: Some(container.clone()),
preserve_fds: self.base.preserve_fds,
detached: self.detached,
executor: self.base.executor,
};
builder_impl.create()?;
container.refresh_state()?;
Ok(container)
}
fn create_container_dir(&self) -> Result<PathBuf, LibcontainerError> {
let container_dir = self.base.root_path.join(&self.base.container_id);
tracing::debug!("container directory will be {:?}", container_dir);
if container_dir.exists() {
tracing::error!(id = self.base.container_id, dir = ?container_dir, "container already exists");
return Err(LibcontainerError::Exist);
}
std::fs::create_dir_all(&container_dir).map_err(|err| {
tracing::error!(
?container_dir,
"failed to create container directory: {}",
err
);
LibcontainerError::OtherIO(err)
})?;
Ok(container_dir)
}
fn load_spec(&self) -> Result<Spec, LibcontainerError> {
let source_spec_path = self.bundle.join("config.json");
let mut spec = Spec::load(source_spec_path)?;
Self::validate_spec(&spec)?;
spec.canonicalize_rootfs(&self.bundle).map_err(|err| {
tracing::error!(bundle = ?self.bundle, "failed to canonicalize rootfs: {}", err);
err
})?;
Ok(spec)
}
fn validate_spec(spec: &Spec) -> Result<(), LibcontainerError> {
let version = spec.version();
if !version.starts_with("1.") {
tracing::error!(
"runtime spec has incompatible version '{}'. Only 1.X.Y is supported",
spec.version()
);
Err(ErrInvalidSpec::UnsupportedVersion)?;
}
if let Some(process) = spec.process() {
if let Some(profile) = process.apparmor_profile() {
let apparmor_is_enabled = apparmor::is_enabled().map_err(|err| {
tracing::error!(?err, "failed to check if apparmor is enabled");
LibcontainerError::OtherIO(err)
})?;
if !apparmor_is_enabled {
tracing::error!(?profile,
"apparmor profile exists in the spec, but apparmor is not activated on this system");
Err(ErrInvalidSpec::AppArmorNotEnabled)?;
}
}
if let Some(io_priority) = process.io_priority() {
let priority = io_priority.priority();
let iop_class_res = serde_json::to_string(&io_priority.class());
match iop_class_res {
Ok(iop_class) => {
if !(0..=7).contains(&priority) {
tracing::error!(?priority, "io priority '{}' not between 0 and 7 (inclusive), class '{}' not in (IO_PRIO_CLASS_RT,IO_PRIO_CLASS_BE,IO_PRIO_CLASS_IDLE)",priority, iop_class);
Err(ErrInvalidSpec::IoPriority)?;
}
}
Err(e) => {
tracing::error!(?priority, ?e, "failed to parse io priority class");
Err(ErrInvalidSpec::IoPriority)?;
}
}
}
}
utils::validate_spec_for_new_user_ns(spec)?;
Ok(())
}
fn create_container_state(&self, container_dir: &Path) -> Result<Container, LibcontainerError> {
let container = Container::new(
&self.base.container_id,
ContainerStatus::Creating,
None,
&self.bundle,
container_dir,
)?;
container.save()?;
Ok(container)
}
}