mirror/sway
1
1
Fork 0
mirror of https://github.com/swaywm/sway synced 2024-11-18 14:53:52 +01:00
Code Issues
5,073 Commits 11 Branches 96 Tags 43 MiB
000d96e525
Commit Graph

5073 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ian Fan
000d96e525 commands: clean-up checkarg function 
Consolidates logic and fixes mistake that used argc instead of val for
determining plural.
 2018-10-23 10:51:08 +01:00
Ian Fan
5364255f26 commands: remove EXPECTED_MORE_THAN 
Its uses have been replaced with EXPECTED_AT_LEAST.
 2018-10-23 10:17:58 +01:00
Ian Fan
a9fdd5dd2a commands: print correct command on error for exec and opacity 2018-10-23 10:14:50 +01:00
emersion
970501f05e
Merge pull request #2940 from RyanDwyer/fix-swaybar-crash 
Fix swaybar crash when there's no status_command
 2018-10-23 10:50:36 +02:00
Ryan Dwyer
851b442f73 Fix swaybar crash when there's no status_command 2018-10-23 18:38:01 +10:00
Arnaud Vallette d'Osia
a5cb4cca15 Advertize dependency on git 2018-10-23 09:56:56 +02:00
emersion
7583b0b8a5
Merge pull request #2936 from RedSoxFan/fix-swaynag-command 
cmd_swaynag_command: fix typo in variable
 2018-10-23 09:09:29 +02:00
Brian Ashworth
6a9930f451 cmd_swaynag_command: fix typo in variable 
The custom swaynag_command was being stored as config->swaybg_command
instead of config->swaynag_command.
 2018-10-22 21:19:22 -04:00
Drew DeVault
5c6240a906
Merge pull request #2935 from mteyssier/ref-output-docs 
Add references to sway-output(5) in sway(5)
 2018-10-23 01:55:58 +02:00
Ryan Dwyer
6e0097b6da
Merge pull request #2934 from RedSoxFan/config-log-cleanup 
config: remove peeked + expanded line log entries
 2018-10-23 08:23:29 +10:00
mteyssier
f530ac6459 Add references to sway-output(5) in sway(5) 
- update ref in the swaybg_command description
- add ref to sway-output(5) in See Also
- add an `output` command description
 2018-10-23 00:00:36 +02:00
Brian Ashworth
31f82830b2 config: remove peeked + expanded line log entries 
The peeked and expanded line log entries were useful during the switch
to generic code blocks and subcommands. However, it has been a while
since those were introduced and the log entries are no longer helpful
for any remaining issues with config parsing. Instead of keeping them
as clutter in the log, they can just be removed.
 2018-10-22 17:52:41 -04:00
Drew DeVault
40c98768e1
Merge pull request #2929 from RyanDwyer/fix-scratchpad-resize 
Fix crash when resizing container hidden in the scratchpad
 2018-10-22 23:45:22 +02:00
Brian Ashworth
bb06a57a71
Merge branch 'master' into fix-scratchpad-resize 2018-10-22 17:32:39 -04:00
Drew DeVault
d9ed9445de
Merge pull request #2926 from RyanDwyer/fix-xwayland-floating-logic 
Fix xwayland wants_floating logic
 2018-10-22 22:12:57 +02:00
Ryan Dwyer
662466e8db Fix crash when resizing container hidden in the scratchpad 
Firstly, the container was wrongly identifying as a tiling container
because it had no workspace.

Secondly, when calculating the maximum possible size we can't use the
workspace if it's not there, so we'll allow unlimited size in this case.
 2018-10-23 00:02:08 +10:00
Drew DeVault
cdbfc3338b
Merge pull request #2924 from RyanDwyer/fix-qt-menu-crash 
Fix crash when quitting a QT app on the wayland backend using menu
 2018-10-22 14:55:32 +02:00
Drew DeVault
ef532154c3
Merge pull request #2923 from RyanDwyer/fix-move-to-fullscreen-crash 
Fix crash when moving a container to a fullscreen workspace
 2018-10-22 14:53:48 +02:00
Ryan Dwyer
db2b545550
Merge pull request #2922 from RedSoxFan/fix-2905 
cmd_reload: recalc font sizing + rebuild textures
 2018-10-22 22:40:26 +10:00
Ryan Dwyer
16ef702645 Fix xwayland wants_floating logic 2018-10-22 21:51:10 +10:00
Ryan Dwyer
6deb726873 Fix crash when quitting a QT app on the wayland backend using menu 
QT unmaps the view before destroying the popup. We destroyed the popup
in response to the view unmapping, but then we'd attempt to destroy it a
second time which caused a crash.

The patch removes the listener.

I tested it with GTK as well, and can confirm the popup is still being
destroyed.
 2018-10-22 18:36:47 +10:00
Ryan Dwyer
f04b8f0061 Fix crash when moving a container to a fullscreen workspace 
Setting normal focus to the fullscreen view causes the old workspace to
start destroying. We then set focus to the old workspace which is no
longer attached in the tree.

As we are only setting focus_inactive on the fullscreen container, the
fix uses seat_set_raw_focus to avoid all the additional behaviour that
comes with it such as destroying the old workspace.
 2018-10-22 18:02:33 +10:00
Brian Ashworth
80e8be71a3 cmd_reload: recalc font sizing + rebuild textures 
When the config gets reloaded, the font height and baseline get reset to
0. If the config does not have a font command in it, the variables will
remain at 0 causing a transparent area where the title would be
rendered.

This makes it so the font height and baseline are recalculated. Additionally,
since the font height and baseline may have changed due to the reload, the
title and marks textures are rebuilt.
 2018-10-21 22:57:29 -04:00
Drew DeVault
a918844e52
Merge pull request #2913 from emersion/fix-swaybar-hotplug 
swaybar: fix hotplug
 2018-10-21 18:35:02 +02:00
emersion
2a32701b78
swaybar: fix hotplug 2018-10-21 17:46:40 +02:00
Drew DeVault
429787510e
Merge pull request #2909 from makepanic/issues/2906 
Parse missing i3 window types
 2018-10-21 16:40:53 +02:00
Christian
989bddc765 Parse missing i3 window types 
fixes the parsing part of #2906
 2018-10-21 15:59:04 +02:00
emersion
a4d6835881
Merge pull request #2903 from RyanDwyer/seat-specific-backandforth 
Make workspace back_and_forth seat-specific
 2018-10-21 08:59:59 +02:00
Ryan Dwyer
c5a6c37275 Make workspace back_and_forth seat-specific 
* When using multiple seats, each seat has its own prev_workspace_name
for the purpose of workspace back_and_forth.
* Removes prev_workspace_name global variable.
* Removes unused next_name_map function in tree/workspace.c.
* Fixes memory leak in seat_destroy (seat was not freed).
 2018-10-21 11:26:22 +10:00
emersion
3f02218b54
Merge pull request #2901 from ianyfan/swaybar 
swaybar: render with minimum height, nominally text height
1.0-beta.1 		2018-10-20 22:52:56 +02:00
Ian Fan
1844a5bafb swaybar: render with minimum height, nominally text height 2018-10-20 21:21:57 +01:00
Drew DeVault
6e6476c3d5
Merge pull request #2900 from Hi-Angel/master 
A script to make inactive windows transparent
 2018-10-20 21:06:38 +02:00
Konstantin Kharlamov
0d5aaf5359 A script to make inactive windows transparent 
Sway has ability to apply transparency to arbitrary windows. This script
wires up this functional to one of popular use-cases from
i3+<compositor_name>.

Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
 2018-10-20 21:58:00 +03:00
Drew DeVault
a41b77ef29
Merge pull request #2896 from RyanDwyer/abort-proprietary 
Abort if proprietary drivers are in use
 2018-10-20 16:18:58 +02:00
Ryan Dwyer
ebeb759873 Abort if proprietary drivers are in use 
The idea here is we don't want users to be blissfully unaware that they
are running unsupported drivers. So we abort on startup, and force the
user to add a specific argument to bypass the check.
 2018-10-21 00:01:09 +10:00
Drew DeVault
64534d2fd1
Merge pull request #2895 from RyanDwyer/fix-popup-damage 
Fix popup damage issues when toplevel and/or popup uses geometry
 2018-10-20 15:38:25 +02:00
Drew DeVault
551e05ba90
Merge pull request #2888 from RyanDwyer/remove-raise-floating 
Remove raise_floating directive
 2018-10-20 15:30:54 +02:00
Ryan Dwyer
93ec1af4d9 Fix popup damage issues when toplevel and/or popup uses geometry 
The wlr_xdg_popup_get_toplevel_coords function has the following quirks:

* It does not do anything with the coordinates of the passed popup.
Instead, we are required to add them ourselves, which we do by passing
them to the function as the surface local values.
* It adds the geometry (shadows etc) of the toplevel itself, so the
coordinates are surface local rather than content local. For this
reason, we have to negate the toplevel's geometry
(child->view->geometry).
* I may be wrong, but the popup positions appear to be stored in surface
local coordinates rather than content local coordinates. The geometry
(shadows etc) of the popup itself must be negated (surface->geometry).
 2018-10-20 23:18:56 +10:00
Drew DeVault
c75098e96f
Merge pull request #2887 from RyanDwyer/bar-overlay 
Put swaybar in overlay layer when using mode hide
 2018-10-20 15:17:51 +02:00
Ryan Dwyer
cafb1ff4f7
Merge pull request #2890 from mihaicmn/create-default-seat 
Fix crash when defaut seat is not created
 2018-10-20 19:43:58 +10:00
Mihai Coman
3daf963d4d Fix crash when defaut seat is not created 
Function input_manager_get_default_seat should always return a seat.
 2018-10-20 11:48:49 +03:00
Ryan Dwyer
b9b1b0e566 Remove raise_floating directive 
The directive controlled whether floating views should raise to the top
when the cursor is moved over it while using focus_follows_mouse. The
default was enabled, which is undesirable. For example, if you have two
floating views where one completely covers the other, the smaller one
would be inaccessible because moving the mouse over the bigger one would
raise it above the smaller one.

There is no known use case for having raise_floating enabled, so this
patch removes the directive and implements the raise_floating disabled
behaviour instead.
 2018-10-20 17:51:32 +10:00
Ryan Dwyer
a4ce5227c2 Put swaybar in overlay layer when using mode hide 
This allows the bar to render over fullscreen views.
 2018-10-20 16:48:43 +10:00
emersion
75ea19c71b
Merge pull request #2870 from RyanDwyer/refactor-input-manager 
Minor refactor of input manager
 2018-10-20 08:42:56 +02:00
emersion
fe6aea1d02
Merge pull request #2886 from RyanDwyer/fix-headless-unmap-crash 
Fix crash when view unmaps while no outputs connected
 2018-10-20 08:37:48 +02:00
emersion
4bde0eb911
Merge pull request #2879 from Emantor/fix/swaybar_position 
swaybar: disallow left and right position and print error on default
 2018-10-20 08:35:20 +02:00
Rouven Czerwinski
17fb3b6994 commands/bar: remove left and right from allowed positions 
"left" and "right" are not allowed positions for swaybar, remove them.
 2018-10-20 08:21:44 +02:00
Rouven Czerwinski
f52825336c swaybar: disallow left and right position and print error on default 
The positions "left" and "right" are not allowed by the man page, remove them
from the allowed positions. Also print an error to stderr if we default to the
bottom position.

Fixes #2878
 2018-10-20 08:21:44 +02:00
Ryan Dwyer
c006717910 Minor refactor of input manager 
The input manager is a singleton object. Passing the sway_input_manager
argument to each of its functions is unnecessary, while removing the
argument makes it obvious to the caller that it's a singleton. This
patch removes the argument and makes the input manager use server.input
instead.

On a similar note:

* sway_input_manager.server is removed in favour of using the server
global.
* seat.input is removed because it can get it from server.input.

Due to a circular dependency, creating seat0 is now done directly in
server_init rather than in input_manager_create. This is because
creating seats must be done after server.input is set.

Lastly, it now stores the default seat name using a constant and removes
a second reference to seat0 (in input_manager_get_default_seat).
 2018-10-20 13:11:43 +10:00
Ryan Dwyer
ed771a6a6e Fix crash when view unmaps while no outputs connected 
When a view unmaps, we call workspace_consider_destroy. This function
assumed the workspace would always have an output, but this is not the
case when hotplugged down to zero. The function now handles this and
allows itself to be destroyed when there is no output.

This means that workspace_begin_destroy must remove the workspace from
the root->saved_workspaces list to avoid an eventual dangling pointer,
so it does that now.

Lastly, when an output is plugged in again and it has to create a new
initial workspace for it, we must emit the workspace::init IPC event
otherwise swaybar shows no workspaces at all. I guess when you start
sway, swaybar is started after the workspace has been created which is
why this hasn't been needed earlier.
 2018-10-20 13:07:33 +10:00