Fix crash on lsp text edits with invalid ranges (#9649)

2024-04-30 09:15:08 +02:00 · 2024-04-05 23:17:22 -03:00 · 2024-04-05 23:17:22 -03:00 · d3bfa3e063
parent 1ba5763a0c
commit d3bfa3e063
1 changed files with 10 additions and 0 deletions
--- a/helix-lsp/src/lib.rs
+++ b/helix-lsp/src/lib.rs
@ -539,6 +539,16 @@ pub fn generate_transaction_from_edits(
                } else {
                    return (0, 0, None);
                };
+
+                if start > end {
+                    log::error!(
+                        "Invalid LSP text edit start {:?} > end {:?}, discarding",
+                        start,
+                        end
+                    );
+                    return (0, 0, None);
+                }
+
                (start, end, replacement)
            }),
        )