mirror/helix
1
0
Fork 0
mirror of https://github.com/helix-editor/helix synced 2024-11-10 10:34:45 +01:00
Code Issues

Fix panic when using set-language on a scratch (#1996)

Browse Source 
Skip launching a language server if a document doesn't have a valid URL.
This commit is contained in:
Roland Kovacs 2022-04-13 03:02:14 +02:00 committed by GitHub
parent 3deb1c9230
commit a0c6c45c1b
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
helix-view/src/editor.rs
View File

@ -453,6 +453,9 @@ impl Editor {
/// Launch a language server for a given document
fn launch_language_server(ls: &mut helix_lsp::Registry, doc: &mut Document) -> Option<()> {
// if doc doesn't have a URL it's a scratch buffer, ignore it
let doc_url = doc.url()?;
// try to find a language server based on the language name
let language_server = doc.language.as_ref().and_then(|language| {
ls.get(language)
@ -476,7 +479,7 @@ impl Editor {
// TODO: this now races with on_init code if the init happens too quickly
tokio::spawn(language_server.text_document_did_open(
doc.url().unwrap(),
doc_url,
doc.version(),
doc.text(),
language_id,