mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-20 08:14:29 +01:00
Code Issues
10,598 Commits 17 Branches 213 Tags 610 MiB
b1cf7f4df1
Commit Graph

10598 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
silverwind
b1cf7f4df1
Add class to page content to unify top margin (#13766) 
* Add class to page content to unify top margin

Previously pages would individually set this margin but some didn't so
content would stick to the header without any space. Resolve this by
adding a new class that is added on all pages. The only place where we
remove this margin again is on the pages with menu or wrapper in the
header.

* fix admin notices

* fix team pages

* fix loading segment on gitgraph for arc-green

* fix last missing case

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-30 23:00:14 -05:00
silverwind
14e8ef9ecb
Flip RUN_MODE detection in router (#13768) 
Missed that part in https://github.com/go-gitea/gitea/pull/13765. It's
already in the 1.13 backport so this forward-ports that change again.
 2020-12-01 09:54:44 +08:00
silverwind
bc455ed257
Set RUN_MODE prod by default (#13765) 
I think it's a bad default to have "dev" as the default run mode which
enables debugging and now also disables HTTP caching. It's better to
just default to a value suitable for general deployments.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-30 14:52:04 -05:00
Jeremie Deray
870fd53320
set git-core paths in snap (#13711) 
Signed-off-by: artivis <deray.jeremie@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-30 13:49:11 -05:00
silverwind
21cf205dc7
Fix bogus http requests on diffs (#13760) 
The .blob-excerpt elements don't have these data attributes in some
cases resulting in bogus http request when expanding a diff and clicking
into the expanded area. This prevents those.

Should backport to 1.13.

Fixes: https://github.com/go-gitea/gitea/issues/13759
 2020-11-30 12:47:01 -05:00
Cirno the Strongest
d7ab72681d
Fix avatar offset on PR/issue timeline view (#13753) 
* Fix avatar offset on PR/issue timeline view

* Apply suggestions from code review

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
 2020-11-30 18:11:17 +02:00
silverwind
63aeb0a859
Fix webpack build warnings (#13752) 
Turns out some of the dependencies make use of optional dependencies
like the vue-template-compiler. Install them again and install
fomantic-ui only when it's being build to fix webpack warnings.
 2020-11-30 01:16:04 +02:00
silverwind
e81edc02b9
Update JS dependencies and misc tweaks (#13741) 
* Update JS dependencies and misc tweaks

- Update all JS dependencies minus webpack
- Adapt CodeMirrors styling to new CSS parent introduced by EasyMDE
- Set eslint parser to latest and add new eslint 7.14 rule
- Speed up npm install by disabling audit and fund checks
- Move fomantic-ui to optional dependencies to further speed up npm
- Enable syntax highlighting on GH for .eslintrc and .stylelintrc
- Makefile cleanups

* disable audit in npmrc

* add missing dash

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-29 16:39:36 -05:00
6543
c4deb97ed1
[Vendor] Update Batch 2020-11 (#13746) 
* github.com/alecthomas/chroma v0.8.1 -> v0.8.2

Changelog: https://github.com/alecthomas/chroma/releases/tag/v0.8.2

* github.com/blevesearch/bleve v1.0.12 -> v1.0.13

Changelog: https://github.com/blevesearch/bleve/releases/tag/v1.0.13

* github.com/editorconfig/editorconfig-core-go v2.3.8 -> v2.3.9

Changelog: https://github.com/editorconfig/editorconfig-core-go/releases/tag/v2.3.9

* github.com/klauspost/compress v1.11.2 -> v1.11.3

Changelog: https://github.com/klauspost/compress/releases/tag/v1.11.3

* github.com/minio/minio-go v7.0.5 -> v7.0.6

Changelog: https://github.com/minio/minio-go/releases/tag/v7.0.6

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-29 15:54:08 -05:00
hana
e8a6c425ec
Update discord domain (#13747) 
Update discord domain in webhook repository settings.
 2020-11-29 18:33:33 +01:00
GiteaBot
c2ac1c73f2 [skip ci] Updated translations via Crowdin 2020-11-29 15:53:10 +00:00
silverwind
295fc99607
Markdown and Repo header tweaks (#13744) 
* Markdown and Repo header tweaks

- Use CSS vars for all markdown colors
- Tweak repo header, removing double borders and adjust sizes
- Use menu instead of buttons for issue open/close switcher
- Add emoji inversion for select emoji glyphs in arc-green
- Use border over box-shadow for all buttons
- Add spacing element to login form without openid

* repo settings navbar fix

* use shared template in more places and adjust dashboard

* fix remaining open/close combos
 2020-11-29 17:52:11 +02:00
silverwind
e00a355427
Dropdowns, Labels fixes and more CSS tweaks (#13733) 
* Dropdowns and Labels fixes

- Rework dropdown, menu and label styles
- Improve issue sidebar milestone and label sections
- Fix archived repo and private org badge
- Move more colors to CSS vars
- Move issue number to end of title on issue page

* more dropdown fixes

* fix basic blue labels - fixes #13731

* improve class setting on svg

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-29 01:22:04 -05:00
silverwind
da4bb6fc4e
Fix label styles affecting shabox (#13734) 
* Fix label styles affecting shabox

Add common parent .labels-list to issue labels lists to prevent
affecting other elements.

Fixes: https://github.com/go-gitea/gitea/issues/13704

* Update templates/shared/issuelist.tmpl

* Update templates/shared/issuelist.tmpl

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2020-11-28 22:26:03 -05:00
6543
b2435af9be
Add Allow-/Block-List for Migrate & Mirrors (#13610) 
* add black list and white list support for migrating repositories

* fix fmt

* fix lint

* fix vendor

* fix modules.txt

* clean diff

* specify log message

* use blocklist/allowlist

* allways use lowercase to match url

* Apply allow/block

* Settings: use existing "migrations" section

* convert domains lower case

* dont store unused value

* Block private addresses for migration by default

* fix lint

* use proposed-upstream func to detect private IP addr

* a nit

* add own error for blocked migration, add tests, imprufe api

* fix test

* fix-if-localhost-is-ipv4

* rename error & error message

* rename setting options

* Apply suggestions from code review

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-28 19:37:58 -05:00
6543
0f14f69e60
Verify password for local-account activation (#13631) 
* Verify passwords for activation

This is to prevent 3rd party activation

* Fix function comment

* only veify password on local-account aktivation

* fix lint

* Update templates/user/auth/activate.tmpl

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: Andreas Shimokawa <shimokawa@fsfe.org>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-28 17:41:06 -05:00
silverwind
e82150d41b
Reduce number of docker pulls on ci (#13739) 
Should reduce errors like https://drone.gitea.io/go-gitea/gitea/32989/7/2
by only pulling each distinct image once per pipeline.

Co-authored-by: zeripath <art27@cantab.net>
 2020-11-28 16:59:05 -05:00
GiteaBot
4f82a0b12e [skip ci] Updated translations via Crowdin 2020-11-28 21:01:53 +00:00
zeripath
911d370dad
Push HEAD instead of master when initialising repositories (#13719) 
* Push HEAD instead of master when initialising repositories

It is possible on modern gits to change the initial branch to something other than
master. This breaks initialising repositories because we assume that the initial
branch is going to be master unless specifically changed.

This PR simply bypasses this issue by pushing the HEAD rather than the master branch.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update modules/repository/init.go

Co-authored-by: mrsdizzie <info@mrsdizzie.com>

Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-28 16:00:38 -05:00
a1012112796
9c26dc1f3a
Add block on official review requests branch protection (#13705) 
Signed-off-by: a1012112796 <1012112796@qq.com>

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-28 21:30:46 +02:00
silverwind
7ed5bf8cbe
Fix .editorconfig (#13735) 
These whitespaces introduced in #13698 seem to break my editorconfig
plugin in sublime text resulting in tab-indented files getting converted
to spaces on save.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-28 20:29:46 +02:00
Simon
8c996c6505
Fix missing stylesheets on installation page (#13736) 
When running gitea for the first time, the stylesheets for the
installation page are broken since the middleware that statically serves
stylesheets does not get executed by chi. This is because if no handlers
are registered in chi, it will drop all middleware.

This commit introduces a "dummy" handler to deal with that quirk.

Closes #13725

Thanks: Lunny Xiao <xiaolunwen@gmail.com> for finding the quirk

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2020-11-28 19:52:30 +02:00
a1012112796
1e5247d424
ui: show 'owner' tag for real owner (#13689) 
* ui: show 'owner' tag for real owner

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update custom/conf/app.example.ini

* simplify logic

fix logic
fix a small bug about original author

* remove system manager tag

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-28 17:52:29 +02:00
Jimmy Praet
48c9865fce
Fix review request notification issue link when external issue tracker is enabled (#13723) 
The issue.HTMLURL() automatically gets converted to the expected #issue format by the post processors
 2020-11-28 13:06:59 +02:00
6543
e7b47c5215
Format files (#13698) 
* align "make help"

* format

* untouch build/generate-svg.js

* untouch .eslintrc

* combine editorconfig's

* rm editorconfig

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-28 01:12:22 -05:00
zeripath
742e21aeba
Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 
* Ensure errors from IsDir propagate

* Handle errors when checking IsFile

* Handle and propagate errors from IsExist

* Update modules/templates/static.go

* Update modules/templates/static.go

* Return after ctx.ServerError

* Apply suggestions from code review

* Fix tests

The previous merge managed to break repo_form.go

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-27 21:42:08 -05:00
Jesse Laprade
5b75f17043
Fixed the log path on fail2ban page (#13726) 
* Changed path from /home/git/gitea/log/gitea.log to
  /var/lib/gitea/log/gitea.log on the fail2ban page, so the log matches
  the instructions found on the following binary installation page:
  https://docs.gitea.io/en-us/install-from-binary/#create-required-directory-structure
 2020-11-27 20:08:23 -05:00
silverwind
7ab3633598
Enable linting of JS inside templates (#13708) 
Indentation-related rules are disabled because indent templates with
tabs but our lint rules expect spaces.

Also had to exclude a few files where using template variables in the JS
is causing syntax errors for the JS parser. I don't think there's a way
to solve this otherwise.

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-28 01:01:33 +02:00
Jimmy Praet
3f13e07849
Use trashcan icon for remove review request (#13722) 2020-11-27 22:55:59 +02:00
John Olheiser
979fbe086c
Increment skip to avoid infini-loop (#13703) 
Signed-off-by: jolheiser <john.olheiser@gmail.com>

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-27 22:00:52 +02:00
silverwind
7bc0c8cff6
Prevent clone protocol button flash on page load (#13626) 
* Prevent clone protocol button flash on page load

Previously, the saved active buttons would flash on page load because if
delay involved in JS execution. Prevent these flashes bydisabling
transitions on page load and run the script right after. It's not an
ideal solution (which would require server-side storage of user
settings like this) but I'd say better than before.

* add defer

Co-authored-by: zeripath <art27@cantab.net>
 2020-11-26 22:31:09 +02:00
silverwind
b2de034278
CSS navbar and color tweaks (#13609) 
* CSS and color tweaks

- Unify navbar-style menus
- Fix admin bar overlapping menu bar
- Fixes file edit comment box
- Fix double border on review box
- Fix review timeline icons

* Many fixes to new-menu and navbar layout enhancements

* misc settings fixes

* navbar tweak

* fix pr tabs

* branch tag and arc color tweaks
 2020-11-26 19:33:28 +00:00
Jimmy Praet
03fa2eccbc
Use chronological commit order in default squash message (#13661) (#13696) 2020-11-25 15:08:17 -05:00
Lauris BH
57fa9b0f25
Support shortened commit SHAs in URLs (#13686) 
* Support shortened commit SHAs in URLs and API

* Add test case for short sha

* Fix format

* Revert API support

* Add canonical link headers for short commit ID URLs
 2020-11-25 15:07:39 -05:00
GiteaBot
72e62ac12b [skip ci] Updated translations via Crowdin 2020-11-25 11:21:50 +00:00
silverwind
6d93a3ab18
Issue and Pulls lists rework (#13594) 
* Issue and Pulls lists rework

Reorganized and restyled the issue and pull request lists.

* color and layout tweaks

* use new issue list on dashboard as well

* move pagination into template

* misc tweaks

* fix label hover

* fix milestone list

* fix discrepancies between issue and milestone list, add new 'merge' helper

* fmt

* simplify merge helper

* remove whitespace

* fix startIndex

* further simplify dict merging

* rename helper to 'mergeinto' for clarity

* allow bottom-row to wrap

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-25 13:20:40 +02:00
silverwind
00ec651270
CSS table fixes (#13692) 
* CSS table fixes

Override the right fomantic selectors.

Fixes: https://github.com/go-gitea/gitea/issues/13690

* use flexbox
 2020-11-24 21:27:10 +02:00
silverwind
24330f71b6
Fix heatmap rendering in Chrome and Safari (#13645) 
* Fix heatmap rendering in Chrome and Safari

Apparently SVG inside flexbox renders slightly different across browsers
where Firefox would stretch to fit the parent while Chrome and safari
wouldn't. Stretch the SVG to the width of the parent for consistent
rendering.

Also did a few minor tweaks on the min-height of the box so it takes up
less space on smaller responsive breakpoints.

Fixes: https://github.com/go-gitea/gitea/issues/13634
Fixes: https://github.com/go-gitea/gitea/pull/13637

* position tweak

Co-authored-by: zeripath <art27@cantab.net>
 2020-11-23 17:41:09 -05:00
6543
f88a2eae97
[API] Add more filters to issues search (#13514) 
* Add time filter for issue search

* Add limit option for paggination

* Add Filter for: Created by User, Assigned to User, Mentioning User

* update swagger

* Add Tests for limit, before & since
 2020-11-23 20:49:36 +00:00
Cirno the Strongest
78204a7a71
Update _repository.less (#13672) 
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-23 11:42:24 +02:00
Kevin Zúñiga
247ab6a922
Send error message when CSRF token is missing (#13676) 2020-11-23 07:56:04 +00:00
Jimmy Praet
2791cc139e
Don't show a dropdown menu when only 1 merge option is available (#13660) (#13670) 2020-11-22 15:58:12 +02:00
GiteaBot
de1e4b2da9 [skip ci] Updated translations via Crowdin 2020-11-21 22:42:26 +00:00
zeripath
45ca2e4605
Handle incomplete diff files properly (#13662) 
* Handle incomplete diff files properly

The code for parsing diff hunks has a bug whereby a very long line
in a very long diff would not be completely read leading to an unexpected
character.

This PR ensures that the line is completely cleared

Fix #13602

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Also allow git max line length <4096

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add test case

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-21 17:41:24 -05:00
Norwin
b651409c0a
Improve strings (#13548) 
* Correct oauth signup title

When linking accounts, a password is not required anymore,
so this string becomes confusing

* string "remenber me": be more precise

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2020-11-20 22:32:27 -05:00
Lunny Xiao
c5f6f8f2f1
Refactor combine label comments with tests (#13619) 
Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-20 17:29:09 -05:00
6543
f915161a2f
skip email validation on empty string (#13627) 
- move validation into its own function
- use a session for UpdateUserSetting
 2020-11-20 23:45:55 +02:00
6543
1bb5c09b5d
API: Admin EditUser: Make FullName, Email, Website & Location optional (#13562) 
* API: Admin EditUser: Make FullName, Email, Website & Location optional

* update swagger docs

* add Tests

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-19 20:56:42 -05:00
6543
24b3b2140a
finaly fix gitlab migration with subdir 2.0 (#13646) 
* final fix 2.0?

* ignore Approvals for pulls if not found

* CI.restart()

Co-authored-by: Lauris BH <lauris@nix.lv>
 2020-11-20 01:18:34 +02:00
Karl Heinz Marbaise
702e82d162
Fix issue/pull request list assignee filter (#13647) 
* Fixes #13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>

* Followup Fixes #13641 - Filtering in Pull Request kept all the time.
 - The URL contains all the time the assignee in cases
   where once a type has been selected.
 - The same behaviour was observed issues viewed via milestones.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
 2020-11-19 15:39:55 -06:00