14035 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
KN4CK3R	876ee8c3cd	Allow package version sorting (#21453)	2022-10-23 09:18:15 +08:00
Yarden Shoham	63ebb53fd5	Add link to user profile in markdown mention only if user exists (#21533) ... Previously mentioning a user would link to its profile, regardless of whether the user existed. This change tests if the user exists and only if it does - a link to its profile is added. * Fixes #3444 Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-23 01:15:52 +08:00
Ashley Nelson	82ecd3b19e	Update milestone counters when issue is deleted (#21459) ... When actions besides "delete" are performed on issues, the milestone counter is updated. However, since deleting issues goes through a different code path, the associated milestone's count wasn't being updated, resulting in inaccurate counts until another issue in the same milestone had a non-delete action performed on it. I verified this change fixes the inaccurate counts using a local docker build. Fixes #21254 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-22 23:08:10 +08:00
KN4CK3R	154efa59a5	Prevent Authorization header for presigned LFS urls (#21531) ... Fixes #21525 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-22 21:36:44 +08:00
Raymond	69fcca2d45	Remove deleted repos from searchresult (#21512) ... This prevents a 500 response, because null pointer exceptions in rendering the template. This happends bc the repoId is not in the repoMap because it is delete fix #19076 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-22 17:23:20 +08:00
Yarden Shoham	2c77d4b195	Remove unnecessary debug log (#21536) ... It distractingly shows up on unit tests * Looks like a leftover from #20571 Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-22 15:25:34 +08:00
rock2dust	cd33979f5a	Added check for disabled Packages (#21540) ... At the moment, If admin disable Packages, still show the Packages on the admin dashboard This patch added a check to hide the Packages entry Signed-off-by: baronbunny <its@baronbunny.cn> Signed-off-by: baronbunny <its@baronbunny.cn>	2022-10-22 11:24:09 +08:00
KN4CK3R	1887c95254	Decouple HookTask from Repository (#17940) ... At the moment a repository reference is needed for webhooks. With the upcoming package PR we need to send webhooks without a repository reference. For example a package is uploaded to an organization. In theory this enables the usage of webhooks for future user actions. This PR removes the repository id from `HookTask` and changes how the hooks are processed (see `services/webhook/deliver.go`). In a follow up PR I want to remove the usage of the `UniqueQueue´ and replace it with a normal queue because there is no reason to be unique. Co-authored-by: 6543 <6543@obermui.de>	2022-10-21 18:21:56 +02:00
Yarden Shoham	e828564445	Add color previews in markdown (#21474) ... * Resolves #3047 Every time a color code will be in \`backticks`, a cute little color preview will pop up [Inspiration](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#supported-color-models) #### Before  #### After  Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-21 20:00:53 +08:00
Lunny Xiao	16cbd5b59c	Fix generating compare link (#21519) ... Fix #6318 Co-authored-by: zeripath <art27@cantab.net>	2022-10-21 16:39:26 +08:00
Vladimir Yakovlev	da3b657c45	[skip ci] Updated translations via Crowdin	2022-10-21 00:21:01 +00:00
Vladimir Yakovlev	ffa4f4b570	Check for valid user token in integration tests (#21520) ... Added checks for logged user token. Some builds fail at unrelated tests, due to missing token. Example: https://drone.gitea.io/go-gitea/gitea/62011/2/14 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-20 19:20:01 +01:00
delvh	6a0330979f	Ignore error when retrieving changed PR review files (#21487) ... When a PR reviewer reviewed a file on a commit that was later gc'ed, they would always get a `500` response from then on when loading the PR. This PR simply ignores that error and instead marks all files as unchanged. This approach was chosen as the only feasible option without diving into **a lot** of error handling. Fixes #21392 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-20 16:29:40 +08:00
6543	bd272e416a	move invite by mail to services package (#21513) ... followup #20307 close #21511 -> make it easy to also add API equivalent later ...	2022-10-20 11:23:31 +08:00
silverwind	fe442dba4b	Enable Monaco automaticLayout (#21515) ... Enable [`automaticLayout`](https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.IDiffEditorOptions.html#automaticLayout) for monaco so it can reflow itself. Fixes: https://github.com/go-gitea/gitea/issues/21508	2022-10-20 02:54:18 +01:00
RainboWu	fbcf1ab477	Update macOS install command (#21507) ... Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-19 21:30:21 -04:00
KN4CK3R	99597dd76a	[skip ci] Updated translations via Crowdin	2022-10-20 00:20:58 +00:00
KN4CK3R	1713beb73b	Suppress ExternalLoginUserNotExist error (#21504) ... Fixes #21202 Closes #21276 An `ExternalLoginUser` is not mandatory if the current user account was created with/by the external login source.	2022-10-19 20:07:21 +01:00
Gusted	6b712465a8	Revert increased width on pull pages (#21470) ... - Revert a behavior from #21012, which liberally added `fluid padded` to non-split style pull pages, this caused it to take up the whole screen(such in split-style pull pages) on pull pages where the diff was shown. - Resolves #21460 ### Before   ### After  	2022-10-19 15:48:29 +01:00
KN4CK3R	c3b2e44392	Add team member invite by email (#20307) ... Allows to add (not registered) team members by email. related #5353 Invite by mail:  Pending invitations:  Email:  Join form:  Co-authored-by: Jack Hay <jjphay@gmail.com>	2022-10-19 14:40:28 +02:00
silverwind	7d1aed83f4	Disable the 'Add File' button when not able to edit repo (#21503) ... Previously, the button would render a dropdown with zero items when `.CanEnableEditor` was false (for example on a mirror repo). Now it disables the button instead which is better UX. <img width="310" alt="image" src="https://user-images.githubusercontent.com/115237/196546655-7262070d-dd8f-4fbe-ad5c-ecb443a9caef.png"> <img width="292" alt="image" src="https://user-images.githubusercontent.com/115237/196546694-51ef5792-16d4-463d-aae8-7ef22dba6bb4.png"> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-19 16:08:33 +08:00
silverwind	37ca4cb7d6	Remove vitest globals (#21505) ... Explicitly import them instead which is cleaner and enables better editor integration. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-19 14:50:19 +08:00
silverwind	e27d52b276	Fix branch dropdown shifting on page load (#21428) ... Removed the "tag/branch" prefix and did some misc tweaks like changing to `<button>` for a11y and adding a bit of margin besides repo path.	2022-10-19 13:39:55 +08:00
wxiaoguang	522dfd5425	[skip ci] Updated translations via Crowdin	2022-10-19 00:21:12 +00:00
wxiaoguang	0614ae1c44	Remove unnecessary misspell ignore pattern (#21475) ... It doesn't make sense to ignore the pattern again and again.	2022-10-18 12:52:25 -04:00
Lunny Xiao	f0182d8840	Fix read system configuration bug when installing (#21489) ... Fix https://github.com/go-gitea/gitea/pull/18058#issuecomment-1280944311 Co-authored-by: 6543 <6543@obermui.de>	2022-10-18 23:16:58 +08:00
zenofile	20a5452ea6	Fix viewing user subscriptions (#21482) ... Fix enumeration of user subscriptions. `watch.mode` is not a boolean but a smallint. Fixes #21447 Regression of #17156	2022-10-18 10:01:02 +02:00
zeripath	716fcfcf72	Make every not exist error unwrappable to a fs.ErrNotExist (#20891) ... A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>	2022-10-18 07:50:37 +02:00
techknowlogick	6af1a0c8c0	inline gitpod image (#21494) ... fix #21492 Co-authored-by: 6543 <6543@obermui.de>	2022-10-18 09:55:57 +08:00
KN4CK3R	ea08559045	[skip ci] Updated translations via Crowdin	2022-10-18 00:21:08 +00:00
KN4CK3R	a37e8b275d	Do not send notifications for draft releases (#21451) ... Fixes #21448 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2022-10-17 17:33:27 -04:00
rock2dust	c0888def50	Update reverse-proxies.zh-cn.md (#21484) ... add proxy header to nginx config example ``` proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-Proto $scheme; ``` Signed-off-by: rock2dust <its@baronbunny.cn> Signed-off-by: rock2dust <its@baronbunny.cn> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-17 17:30:30 -04:00
delvh	6771b1005a	Docs: Update the feature comparison to other Git Hosting Services (#20933) ... This was drastically outdated recently.	2022-10-17 17:29:57 -04:00
KN4CK3R	a577214760	Add some api integration tests (#18872) ... depends on #18871 Added some api integration tests to help testing of #18798. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2022-10-18 00:23:27 +08:00
6543	18622a0705	probe if sha before exec git (#21467)	2022-10-17 16:40:37 +02:00
wxiaoguang	11ac14cfe1	Fix incorrect notification commit url (#21479) ... For normal commits the notification url was wrong because oldCommitID is received from the shrinked commits list. This PR moves the commits list shrinking after the oldCommitID assignment.	2022-10-17 12:58:20 +08:00
Yarden Shoham	acdb92ad42	Localize all timestamps (#21440) ... Following * #21410 We are now able to localize all timestamps. Some examples: `short-date` format, French, user profile page:  `date-time` format, Portuguese, mirror repository settings page:  Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-17 12:08:21 +08:00
Lunny Xiao	683c9af89f	[skip ci] Updated translations via Crowdin	2022-10-17 00:20:53 +00:00
Lunny Xiao	f860a6d2e4	Add system setting table with cache and also add cache supports for user setting (#18058)	2022-10-17 07:29:26 +08:00
Gusted	5d3dbffa15	Return 404 when user is not found on avatar (#21476) ... - Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found	2022-10-16 19:48:17 +01:00
KN4CK3R	11d3677818	Enforce grouped NuGet search results (#21442) ... Fixes #21434 Added tests to enforce this behaviour. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-17 01:18:09 +08:00
KN4CK3R	cad9adeff4	Display total commit count in hook message (#21400) ... Fixes #21379 The commits are capped by `setting.UI.FeedMaxCommitNum` so `len(commits)` is not the correct number. So this PR adds a new `TotalCommits` field. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-17 00:22:34 +08:00
wxiaoguang	6f48a36227	Refactor GetNextResourceIndex to make it work properly with transaction (#21469) ... Related: * #21362 This PR uses a general and stable method to generate resource index (eg: Issue Index, PR Index) If the code looks good, I can add more tests ps: please skip the diff, only have a look at the new code. It's entirely re-written. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-10-16 18:44:16 +08:00
silverwind	0647df3e83	Simplify fmt-check (#21458) ... `fmt-check` now simply does `fmt` before and relies on `git diff` like other checks like 'tidy-check' already do, so we can remove the argument in the tool that handles printing changed files. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-16 16:11:17 +08:00
techknowlogick	9fb251fb6f	update current stable version	2022-10-15 22:04:25 -04:00
techknowlogick	288adbdea6	1.17.3 changelog	2022-10-15 22:03:59 -04:00
silverwind	e2727b73a3	[skip ci] Updated translations via Crowdin	2022-10-16 00:20:58 +00:00
silverwind	32159cc4a3	Fix mermaid-related bugs (#21431)	2022-10-15 18:04:00 -04:00
Lauris BH	8e8b536c29	Update OpenRC startup script (#21436)	2022-10-15 17:59:52 -04:00
Yarden Shoham	bc53256316	Use own Go version instead of hardcoded 1.17 for make fmt (#21457) ... We should make sure we're using the same version across the codebase. * We upgraded in #19918 but forgot about the following line 6bb6a108e0/build/code-batch-process.go (L273) Signed-off-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2022-10-15 21:10:25 +01:00