15352 Commits

All Branches

Search

Author	SHA1	Message	Date
Yarden Shoham	4f1065030f	Use official Vue extension in Gitpod (#24609) ... The previous one didn't work well --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: silverwind <me@silverwind.io>	2023-05-09 18:03:50 +00:00
来自村里的小螃蟹	cd9a13ebb4	Create a branch directly from commit on the create branch API (#22956) ... #### Added - API: Create a branch directly from commit on the create branch API - Added `old_ref_name` parameter to allow creating a new branch from a specific commit, tag, or branch. - Deprecated `old_branch_name` parameter in favor of the new `old_ref_name` parameter. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-05-09 18:22:32 +08:00
wxiaoguang	023a048f52	Make repository response support HTTP range request (#24592) ... Replace #20480 Replace #18448 Close #16414	2023-05-09 15:34:36 +08:00
Nicholas Pease	c090f87a8d	Add Gitea Profile Readmes (#23260) ... Implements displaying a README.md file present in a users ```.profile``` repository on the users profile page. If no such repository/file is present, the user's profile page remains unchanged. Example of user with ```.profile/README.md```  Example of user without ```.profile/README.md```  This pull request closes the feature request in #12233 Special thanks to @techknowlogick for the help in the Gitea discord! --------- Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Yarden Shoham <hrsi88@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: yp05327 <576951401@qq.com> Co-authored-by: Yarden Shoham <git@yardenshoham.com>	2023-05-09 05:57:24 +00:00
wxiaoguang	b6fc2cdf82	Make diff view full width again (#24598) ... Regression of #24459 , [the related line](https://github.com/go-gitea/gitea/pull/24459/files#diff-f255004de8d715ff40852710390429bf2a06e7e33a4e3f8ad568af636557ac71L8) The PR file diff view needs to be full-screen width.	2023-05-09 05:21:03 +00:00
yp05327	2ee72d011f	Add permission check for moving issue action in project view page (#24589) ... Fix #22954 Only users who have write permission can move issues in the project view page.	2023-05-09 00:50:16 -04:00
silverwind	d5b2bf9044	Update JS dependencies, add new eslint rules (#24597) ... - Update all JS dependencies - Enable new eslint rules, fix issue (some via autofix) - Fix some missed eslint rule renames from [unicorn v25](https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v25.0.0) - Tested Monaco, Katex, Swagger UI --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-09 02:35:49 +00:00
Matthew Walowski	1dd83dbb91	Filters for GetAllCommits (#24568) ... The `GetAllCommits` endpoint can be pretty slow, especially in repos with a lot of commits. The issue is that it spends a lot of time calculating information that may not be useful/needed by the user. The `stat` param was previously added in #21337 to address this, by allowing the user to disable the calculating stats for each commit. But this has two issues: 1. The name `stat` is rather misleading, because disabling `stat` disables the Stat **and** Files. This should be separated out into two different params, because getting a list of affected files is much less expensive than calculating the stats 2. There's still other costly information provided that the user may not need, such as `Verification` This PR, adds two parameters to the endpoint, `files` and `verification` to allow the user to explicitly disable this information when listing commits. The default behavior is true.	2023-05-09 09:06:05 +08:00
GiteaBot	707c7e60c9	[skip ci] Updated translations via Crowdin	2023-05-09 00:24:20 +00:00
Yarden Shoham	46e97986f5	Attach a tooltip to the action control button (#24595) ... The first time I saw the big red X button I thought something failed but apparently, it was just a "Cancel" button # Before    # After    --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	2023-05-08 23:59:59 +00:00
wxiaoguang	def4956122	Improve Gitea's web context, decouple "issue template" code into service package (#24590) ... 1. Remove unused fields/methods in web context. 2. Make callers call target function directly instead of the light wrapper like "IsUserRepoReaderSpecific" 3. The "issue template" code shouldn't be put in the "modules/context" package, so move them to the service package. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-09 01:30:14 +02:00
yp05327	c4303efc23	Support markdown editor for issue template (#24400) ... Fixes #24398 Task: - [x] Reusing "textarea" like GitHub seems more friendly to users. - [x] ^V image pasting and file uploading handling. <details><summary>screenshots</summary>   Display only one markdown editor:  Support file upload and ^V image pasting  </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2023-05-08 22:22:52 +00:00
Yarden Shoham	9ad5b59cd9	Do not select line numbers when selecting text from the action run logs (#24594) ... - Fixes #24578 # Before  # After  Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2023-05-08 20:50:05 +02:00
Nick	3d266dd0f3	In TestViewRepo2, convert computed timezones to local time (#24579) ... This fixes up https://github.com/go-gitea/gitea/pull/10446; in that, the *expected* timezone was changed to the local timezone, but the computed timezone was left in UTC. The result was this failure, when run on a non-UTC system: ``` Diff: --- Expected +++ Actual @@ -5,3 +5,3 @@ commitMsg: (string) (len=12) "init project", - commitTime: (string) (len=29) "Wed, 14 Jun 2017 09:54:21 EDT" + commitTime: (string) (len=29) "Wed, 14 Jun 2017 13:54:21 UTC" }, @@ -11,3 +11,3 @@ commitMsg: (string) (len=12) "init project", - commitTime: (string) (len=29) "Wed, 14 Jun 2017 09:54:21 EDT" + commitTime: (string) (len=29) "Wed, 14 Jun 2017 13:54:21 UTC" } Test: TestViewRepo2 ``` I assume this was probably missed since the CI servers all run in UTC? The Format() string "Mon, 02 Jan 2006 15:04:05 UTC" was incorrect: 'UTC' isn't recognized as a variable placeholder, but was just being copied verbatim. It should use 'MST' in order to command Format() to output the attached timezone, which is what `time.RFC1123` has.	2023-05-08 21:07:41 +08:00
yp05327	f5b70a029c	Fix close org projects (#24588) ... A part of #22865 We can not close org projects now. This PR will fix it.	2023-05-08 12:19:27 +00:00
wxiaoguang	6f9c278559	Rewrite queue (#24505) ... # ⚠️ Breaking Many deprecated queue config options are removed (actually, they should have been removed in 1.18/1.19). If you see the fatal message when starting Gitea: "Please update your app.ini to remove deprecated config options", please follow the error messages to remove these options from your app.ini. Example: ``` 2023/05/06 19:39:22 [E] Removed queue option: `[indexer].ISSUE_INDEXER_QUEUE_TYPE`. Use new options in `[queue.issue_indexer]` 2023/05/06 19:39:22 [E] Removed queue option: `[indexer].UPDATE_BUFFER_LEN`. Use new options in `[queue.issue_indexer]` 2023/05/06 19:39:22 [F] Please update your app.ini to remove deprecated config options ``` Many options in `[queue]` are are dropped, including: `WRAP_IF_NECESSARY`, `MAX_ATTEMPTS`, `TIMEOUT`, `WORKERS`, `BLOCK_TIMEOUT`, `BOOST_TIMEOUT`, `BOOST_WORKERS`, they can be removed from app.ini. # The problem The old queue package has some legacy problems: * complexity: I doubt few people could tell how it works. * maintainability: Too many channels and mutex/cond are mixed together, too many different structs/interfaces depends each other. * stability: due to the complexity & maintainability, sometimes there are strange bugs and difficult to debug, and some code doesn't have test (indeed some code is difficult to test because a lot of things are mixed together). * general applicability: although it is called "queue", its behavior is not a well-known queue. * scalability: it doesn't seem easy to make it work with a cluster without breaking its behaviors. It came from some very old code to "avoid breaking", however, its technical debt is too heavy now. It's a good time to introduce a better "queue" package. # The new queue package It keeps using old config and concept as much as possible. * It only contains two major kinds of concepts: * The "base queue": channel, levelqueue, redis * They have the same abstraction, the same interface, and they are tested by the same testing code. * The "WokerPoolQueue", it uses the "base queue" to provide "worker pool" function, calls the "handler" to process the data in the base queue. * The new code doesn't do "PushBack" * Think about a queue with many workers, the "PushBack" can't guarantee the order for re-queued unhandled items, so in new code it just does "normal push" * The new code doesn't do "pause/resume" * The "pause/resume" was designed to handle some handler's failure: eg: document indexer (elasticsearch) is down * If a queue is paused for long time, either the producers blocks or the new items are dropped. * The new code doesn't do such "pause/resume" trick, it's not a common queue's behavior and it doesn't help much. * If there are unhandled items, the "push" function just blocks for a few seconds and then re-queue them and retry. * The new code doesn't do "worker booster" * Gitea's queue's handlers are light functions, the cost is only the go-routine, so it doesn't make sense to "boost" them. * The new code only use "max worker number" to limit the concurrent workers. * The new "Push" never blocks forever * Instead of creating more and more blocking goroutines, return an error is more friendly to the server and to the end user. There are more details in code comments: eg: the "Flush" problem, the strange "code.index" hanging problem, the "immediate" queue problem. Almost ready for review. TODO: * [x] add some necessary comments during review * [x] add some more tests if necessary * [x] update documents and config options * [x] test max worker / active worker * [x] re-run the CI tasks to see whether any test is flaky * [x] improve the `handleOldLengthConfiguration` to provide more friendly messages * [x] fine tune default config values (eg: length?) ## Code coverage: 	2023-05-08 19:49:59 +08:00
wxiaoguang	cb700aedd1	Split "modules/context.go" to separate files (#24569) ... The "modules/context.go" is too large to maintain. This PR splits it to separate files, eg: context_request.go, context_response.go, context_serve.go This PR will help: 1. The future refactoring for Gitea's web context (eg: simplify the context) 2. Introduce proper "range request" support 3. Introduce context function This PR only moves code, doesn't change any logic.	2023-05-08 17:36:54 +08:00
Matthew Walowski	ff5629268c	Pass 'not' to commit count (#24473) ... Due to #24409 , we can now specify '--not' when getting all commits from a repo to exclude commits from a different branch. When I wrote that PR, I forgot to also update the code that counts the number of commits in the repo. So now, if the --not option is used, it may return too many commits, which can indicate that another page of data is available when it is not. This PR passes --not to the commands that count the number of commits in a repo	2023-05-08 07:10:53 +00:00
sillyguodong	e962ade99c	Refresh the refernce of the closed PR when reopening (#24231) ... Close #24213 Replace #23830 #### Cause - Before, in order to making PR can get latest commit after reopening, the `ref`(${REPO_PATH}/refs/pull/${PR_INDEX}/head) of evrey closed PR will be updated when pushing commits to the `head branch` of the closed PR. #### Changes - For closed PR , won't perform these behavior: insert`comment`, push `notification` (UI and email), exectue [pushToBaseRepo](7422503341/services/pull/pull.go (L409)) function and trigger `action` any more when pushing to the `head branch` of the closed PR. - Refresh the reference of the PR when reopening the closed PR (**even if the head branch has been deleted before**). Make the reference of PR consistent with the `head branch`.	2023-05-08 14:39:32 +08:00
Steve Russo	80765aab8c	Fix broken link in tests/e2e/README (#24576)	2023-05-08 00:52:11 +00:00
GiteaBot	3319e9597e	[skip ci] Updated licenses and gitignores	2023-05-08 00:23:39 +00:00
Tyrone Yeh	1144b1d129	Add goto issue id function (#24479) ... for https://github.com/go-gitea/gitea/issues/4109#issuecomment-1527104992 Supports format: `#1234` `Org/Repo#1234` --------- Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2023-05-07 23:44:16 +08:00
wxiaoguang	0bb52883eb	Improve decryption failure message (#24573) ... Help some users like #16832 #1851 There are many users reporting similar problem: if the SECRET_KEY mismatches, some operations (like 2FA login) only reports unclear 500 error and unclear "base64 decode error" log （some maintainers ever spent a lot of time on debugging such problem) The SECRET_KEY was not well-designed and it is also a kind of technical debt. Since it couldn't be fixed easily, it's good to add clearer error messages, then at least users could know what the real problem is. --------- Co-authored-by: delvh <dev.lh@web.de>	2023-05-07 19:29:43 +08:00
wxiaoguang	56ae853ca0	Simplify template helper functions (#24570) ... To avoid bloating the template helper functions, some functions could be provided by type methods. And the new code `data-line-type="{{.GetHTMLDiffLineType}}"` reads better than `data-line-type="{{DiffLineTypeToStr .GetType}}"` After the fix, screenshots (the same as before): <details>   </details>	2023-05-07 09:49:46 +00:00
riastradh	377e0139b0	Makefile: Use portable !, not GNUish -not, with find(1). (#24565) ... fix https://github.com/go-gitea/gitea/issues/24564 Co-authored-by: Taylor R Campbell <campbell+gitea@mumble.net>	2023-05-07 12:41:33 +08:00
Hester Gong	97b70a0cd4	Add org visibility label to non-organization's dashboard (#24558)	2023-05-07 08:33:43 +08:00
techknowlogick	4daf40505a	Sort users and orgs on explore by recency by default (#24279) ... This gives more "freshness" to the explore page. So it's not just the same X users on the explore page by default, now it matches the same sort as the repos on the explore page. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-05-06 22:04:55 +08:00
Yarden Shoham	46679554d0	Change `add_on` translation to `added_on` and include placeholder for the date (#24562) ... - Very similar to #24550 The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "added on" and the date (and that "added on" comes before the date). Some languages, like Hebrew, have no space between the "added on" and the date. For example: ```ini added_on=נוסף ב-%s ``` ("added" becomes נוסף, "on" is ב and when paired with a date we use a dash to connect ב with the date) --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: delvh <dev.lh@web.de>	2023-05-06 21:11:27 +08:00
Yarden Shoham	95e2e3aa30	Change `valid_until` translation to `valid_until_date` and include placeholder for the date (#24563) ... - Similar to #24550 - Similar to #24562 The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "valid until" and the date (and that "valid until" comes before the date). Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2023-05-06 12:37:02 +00:00
Yarden Shoham	ef92459e18	Fix docs failing the build on `main` (#24561) ... Regression from https://github.com/go-gitea/gitea/pull/23380 First failing build: https://drone.gitea.io/go-gitea/gitea/74565 https://github.com/go-gitea/gitea/actions/runs/4897332409/jobs/8745242395 Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2023-05-06 11:52:44 +00:00
wxiaoguang	db582d97ef	Improve wiki user title test (#24559) ... The `..` should be covered by TestUserTitleToWebPath. Otherwise, if the random string is "..", it causes unnecessary failure in TestUserWebGitPathConsistency	2023-05-06 11:24:18 +00:00
Zettat123	bc888e5f92	Fix incorrect user visibility (#24557) ... Fix #24555	2023-05-06 10:54:26 +00:00
Yarden Shoham	291c868046	Change `join_on` translation to `joined_on` and include placeholder for the date (#24550) ... The correct thing to do is to translate the entire phrase into a single string. The previous translation assumed all languages have a space between the "joined on" and the date (and that "joined on" comes before the date). Some languages, like Hebrew, have no space between the "joined on" and the date. For example: ```ini joined_on=נרשם ב-%s ``` ("joined" becomes נרשם, "on" is ב and when paired with a date we use a dash to connect ב with the date)	2023-05-06 18:10:30 +08:00
Lunny Xiao	e5a8ebc0ed	Require at least one unit to be enabled (#24189) ... Don't remember why the previous decision that `Code` and `Release` are non-disable units globally. Since now every unit include `Code` could be disabled, maybe we should have a new rule that the repo should have at least one unit. So any unit could be disabled. Fixes #20960 Fixes #7525 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: yp05327 <576951401@qq.com>	2023-05-06 17:39:06 +08:00
JakobDev	0ebabf3c6b	Fix broken `README` link (#24546)	2023-05-06 16:16:06 +08:00
Lunny Xiao	0deb5053bd	Check latest version on CI (#24556)	2023-05-06 15:43:56 +08:00
KN4CK3R	05209f0d1d	Add RPM registry (#23380) ... Fixes #20751 This PR adds a RPM package registry. You can follow [this tutorial](https://opensource.com/article/18/9/how-build-rpm-packages) to build a *.rpm package for testing. This functionality is similar to the Debian registry (#22854) and therefore shares some methods. I marked this PR as blocked because it should be merged after #22854. 	2023-05-05 20:33:37 +00:00
Jason Song	8f314c6793	Docs for Gitea Actions (#24405) ... A new documentation section for Gitea Actions. Some content comes from: - [Hacking on Gitea Actions](https://blog.gitea.io/2023/03/hacking-on-gitea-actions/) - The README of [act_runner](https://gitea.com/gitea/act_runner) - @ChristopherHX's excellent overview of the differences between Gitea Actions and GitHub Actions in [this comment](https://github.com/go-gitea/gitea/issues/13539#issuecomment-1448888850). --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2023-05-05 20:07:20 +00:00
Gary Moon	b8c19e7a11	Update LDAP filters to include both username and email address (#24547) ... Since the login form label for user_name unconditionally displays `Username or Email Address` for the `user_name` field, bring matching LDAP filters to more prominence in the documentation/placeholders. Signed-off-by: Gary Moon <gary@garymoon.net>	2023-05-05 14:18:53 -04:00
Kyle D	09dd4b42c7	Temporarily disable PATs until next release (#24527) ... This might be a bit contentious, but I think we should try to limit the impact of deprecating scoped PATs with the rewrite proposed here we're working on for v1.20: https://github.com/go-gitea/gitea/issues/24501 We should have a PR opened shortly to re-scope the routes.	2023-05-05 11:41:44 -04:00
Jason Song	ea1afb945d	Replace placeholders in licenses (#24354) ... Replace #22117. Implement it in a more maintainable way. Some licenses have placeholders e.g. the BSD licenses start with this line: ``` Copyright (c) <year> <owner>. ``` This PR replaces the placeholders with the correct value when initialize a new repo. ### FAQ - Why not use a regex? It will be a pretty complicated regex which could be hard to maintain. - There're still missing placeholders. There are over 500 licenses, it's impossible for anyone to inspect all of them alone. Please help to add them if you find any, and it is also OK to leave them for the future. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-05 13:46:17 +00:00
sillyguodong	a866cb0cb9	Fix the permission of team's `Actions` unit issue (#24536) ... close #24449 The unit of `Actions` should be contorlled not only by `repository.DISABLED_REPO_UNITS` but also by `actions.ENABLED` in the `app.ini`. Previously, the permission of the team's `Actions` unit was not controlled by `actions.Enabled`. So, even if the user sets `actions.Enabled` to false, he can still select the permission of the `Actions` unit for the team. This PR makes the permissions of the team's `Actions` unit also controlled by `actions.Enabled`. Just append`TypeActions` into `DisabledRepoUnits` slice when initializing if `actions.Enabled` is false. ### Changes: If `Actions` is set disbaled in `app.ini`, like below: ```yaml [actions] ENABLED = false ``` 1. If user try to create/edit a team, will prompt user that `Actions` is disabled.  2. `actions` is not displayed in the sidebar on the team details page 	2023-05-05 20:02:30 +08:00
techknowlogick	a1cd455c85	Bump golang deps (#24533)	2023-05-05 17:17:19 +08:00
Lunny Xiao	f17a4358f4	Fix mirrors repository disapeared on user dashboard (#24520) ... Fix regression from #23405	2023-05-05 16:41:21 +08:00
Lunny Xiao	3ee7f27341	Revert "Prevent a user with a different email from accepting the team invite" (#24531) ... Reverts go-gitea/gitea#24491	2023-05-05 15:59:12 +08:00
wxiaoguang	421840486f	Fix form method/class (#24535) ... Fix #24534	2023-05-05 05:14:22 +00:00
sillyguodong	81d6007055	Fix typo in rename branch dialog (#24537) ... Fix https://github.com/go-gitea/gitea/pull/24512#discussion_r1185664695	2023-05-05 12:44:59 +08:00
Jason Song	27a569609c	Check length of `LogIndexes` in case it is outdated (#24516) ... Fix #24458	2023-05-04 23:37:43 -04:00
Benjamin Loison	78fdbaf186	Harmonize title formatting in `docs/content/doc/development/api-usage.en-us.md` (#24529)	2023-05-05 03:11:54 +00:00
techknowlogick	c1e9c7b7b9	automate locking closed threads (#24525) ... With comments happening on closed issues/prs this locks issues that have been closed for >45days. This allows for comments on recently closed issues/prs to still happen. --------- Co-authored-by: silverwind <me@silverwind.io>	2023-05-05 10:17:29 +08:00