mirror/ gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-05-19 16:06:11 +02:00
Code Issues
11,470 Commits 17 Branches 210 Tags 618 MiB
Commit Graph

11470 Commits

Author SHA1 Message Date
KN4CK3R 3d7d750a99
Fix individual tests (addition to #15802) (#15818) 
* Decouple TestAction_GetRepoLink and TestSizedAvatarLink.

* Load database for TestCheckGPGUserEmail.

* Load database for TestMakeIDsFromAPIAssigneesToAdd.

* Load database for TestGetUserIDsByNames and TestGetMaileableUsersByIDs.

* Load database for TestUser_ToUser.

* Load database for TestRepository_EditWikiPage.

* Include AppSubURL in test.

* Prevent panic with empty slice.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-05-12 00:13:42 -04:00
GiteaBot 96b1315e6e [skip ci] Updated translations via Crowdin 2021-05-12 00:12:06 +00:00
zeripath aa65a607e4
Queue manager FlushAll can loop rapidly - add delay (#15733) 
* Queue manager FlushAll can loop rapidly - add delay

Add delay within FlushAll to prevent rapid loop when workers are busy

Signed-off-by: Andrew Thornton <art27@cantab.net>

* as per lunny

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
 2021-05-12 00:22:08 +01:00
Mike L 793e03244b
label size, PR ref, new PR button alignment (#15363) 
Co-authored-by: zeripath <art27@cantab.net>
 2021-05-11 23:11:12 +01:00
Lunny Xiao 143071ee41
don't record error when loading ref comment but ref comment id is zero (#15820) 2021-05-11 21:43:35 +01:00
zeripath fc6501e4e0
Set autocomplete off on branches selector (#15809) 
Fix #15782

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-05-11 12:32:06 -04:00
techknowlogick 2dc3e4edc8
point appleboy/drone-git-push to use updated primary branch 2021-05-10 20:27:56 -04:00
KN4CK3R f8335444de
Add Active and ProhibitLogin to API (#15689) 
* Added active and prohibit_login.

* Do not omit fields for normal users.
 2021-05-11 02:22:29 +02:00
Adam Szatyin d86d123322
Add mimetype mapping settings (#15133) 
* Fix APK's Content-Type header

* Fix case sensitive comparison

* Add custom mime type mapping for downloadable files

* Add documentation for MIME type mapping

* Rename download.mimetype.mapping configuration to repository.mimetype_mapping

Co-authored-by: zeripath <art27@cantab.net>
 2021-05-10 16:38:08 -04:00
John Olheiser 2f65c6b2f0
Add err to log (#15813) 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
 2021-05-10 20:48:23 +01:00
Lunny Xiao d37a89ed05
don't record error when request a non-exist user (#15819) 
* don't record error when request a non-exist user

* Update routers/repo/http.go

Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-05-10 13:43:55 -04:00
a1012112796 75d8297045
add note about ``cron.SCHEDULE`` format in document (#15812) 
* add note about ``cron.SCHEDULE`` format in document

Signed-off-by: a1012112796 <1012112796@qq.com>

* Update custom/conf/app.example.ini

Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-05-10 12:54:45 -04:00
Lunny Xiao 3656a2a672
Fix goth user infer bug (#15821) 2021-05-10 16:31:32 +01:00
Lunny Xiao e5723d6556
Move restore repo to internal router and invoke from command to avoid open the same db file or queues files (#15790) 
* Move restore repo to internal router and invoke from command to avoid open the same db file or queues files

* Follow @zeripath's review

* set no timeout for resotre repo private request

* make restore repo cancelable
 2021-05-10 15:57:45 +08:00
silverwind 1e6fa57acb
Use single shared random string generation function (#15741) 
* Use single shared random string generation function

- Replace 3 functions that do the same with 1 shared one
- Use crypto/rand over math/rand for a stronger RNG
- Output only alphanumerical for URL compatibilty

Fixes: #15536

* use const string method

* Update modules/avatar/avatar.go

Co-authored-by: a1012112796 <1012112796@qq.com>

Co-authored-by: a1012112796 <1012112796@qq.com>
 2021-05-10 07:45:17 +01:00
zeripath 270aab429e
On open repository open common cat file batch and batch-check (#15667) 
Use common git cat-file --batch and git cat-file --batch-check to
significantly reduce calls to git.
    
Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-10 03:27:03 +02:00
zeripath 038e1db4df
Return go-get info on subdirs (#15642) 
This PR is an alternative to #15628 and makes the go get handler a
handler.

Fix #15625

Close #15628

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-09 22:50:06 +01:00
zeripath 4a84022d25
Comment out app.example.ini (#15807) 
This PR is an alternative to #15559.

Instead of deleting the app.example.ini - just comment out most of the
thing. This makes it clear what needs to be set and what is completely
optional - and keeps the documentation.

The app.example.ini is moved around to move the most important settings
higher in the document.

Close #15559

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-09 23:10:05 +02:00
silverwind 17a7797cdd
Fix incorrect asset URL (#15805) 
Fixes another regression from https://github.com/go-gitea/gitea/pull/15219.
 2021-05-09 21:03:09 +01:00
Steven 2e0f315617
Respect default merge message syntax when parsing item references (#15772) 
* Respect merge message structure for parsing item references

Signed-off-by: JustusBunsi <61625851+justusbunsi@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
 2021-05-09 19:25:23 +01:00
zeripath a2df265476
Add trace logging to SSO methods (#15803) 
It is currenly impossible to detect which "SSO" method is responsible for login. This
PR adds some basic trace logging to these methods.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-09 18:04:53 +02:00
6543 4ea0b46d9b
Tests should use test files (#15801) 2021-05-09 17:20:33 +02:00
6543 a229e34387
Allow only internal registration (#15795) 
* Add ALLOW_ONLY_INTERNAL_REGISTRATION into settings

* OpenID respect setting too
 2021-05-09 16:13:35 +02:00
KN4CK3R e818e9150f
Fixed individual markdown tests. (#15802) 2021-05-09 15:29:49 +02:00
6543 a98c09d2ae
Changelog v1.14.2 (#15794) (#15799) 
* Changelog v1.14.2 (#15794)

* changelog tool generate

* format & add

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
 2021-05-09 13:49:26 +02:00
silverwind c3802dcc0f
Use binary version of revive linter (#15739) 
Use the common `go get` method to install and run the revive linter,
removing the useless build/lint.go and related vendor libraries.
 2021-05-09 13:08:02 +02:00
zeripath a69fb523a7
Ensure that ctx.Written is checked after issues(...) calls (#15797) 
Fix issue noted in #15783

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-09 10:33:49 +08:00
Steven 864e656d81
Display conflict-free merge messages for pull requests (#15773) 
Repositories using external issue tracker tend to use numeric issues in
commits. To prevent conflicts during issue reference parsing or inside
commit hooks, this change respects these configuration and uses the !
character to refer to pull requests in merge commit messages.

For repositories using squash merges, this was already handled.

Signed-off-by: JustusBunsi <61625851+justusbunsi@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
 2021-05-08 20:19:42 +01:00
zeripath e22ee468cf
Exponential Backoff for ByteFIFO (#15724) 
This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
 2021-05-08 17:29:47 +01:00
silverwind 2a9b8d173a
Code comments improvements (#15722) 
- Right-align the Reply and Resolve buttons
- Center Resolved text and add some padding
- Add padding to inline comments
- Indent the comment content to align with author name
- Re-parent form to allow better button layout space.

Co-authored-by: zeripath <art27@cantab.net>
 2021-05-08 18:28:25 +03:00
silverwind 24ad131221
Rename StaticUrlPrefix to AssetUrlPrefix (#15779) 
Use a new name for this template/frontend variable to make it distinct
from the server variable StaticURLPrefix.
 2021-05-08 16:27:25 +02:00
6543 e278614753
[API] make change repo settings work on empty repos (#15778) 
* API: Fix #15602

* Add TEST
 2021-05-08 14:11:36 +02:00
6543 272bbb200d
Make let target "clean-all" remove node_modules folder too (#15780) 
* Make let target "clean-all" remove node_modules folder too
 2021-05-08 11:57:48 +02:00
Jonathan Tran 9557b8603a
Add selecting tags on the compare page (#15723) 
* Add selecting tags on the compare page

* Remove unused condition and change indentation

* Fix tag tab in dropdown to be black

* Add compare tag integration test

Co-authored-by: Jonathan Tran <jon@allspice.io>
 2021-05-07 23:10:05 +02:00
silverwind 4900881924
Use esbuild to minify CSS (#15756) 
It's about a 30% speedup in webpack build time with neglible differences
in the output size. We do lose the ability for CSS source maps, but I
rarely have a use for them anyways.

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: 6543 <6543@obermui.de>
 2021-05-07 15:12:37 -04:00
zeripath a4c13229b7
Use pulls in commit graph unless pulls are disabled (#15774) 
Fix #15370

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-07 20:10:30 +02:00
silverwind d4f28fd4ad
Fix URL of gitea emoji (#15770) 
Fixes regression from #15219
 2021-05-07 17:34:33 +02:00
6543 16034bb613
OAuth2 login: Set account link to "login" as default behavior (#15768) 2021-05-07 16:15:16 +02:00
zeripath 8f0539c235
Set GIT_DIR correctly if it is not set (#15751) 
* Set GIT_DIR correctly if it is not set

* Expand out templates

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-07 15:19:09 +02:00
a1012112796 c25813182c
not show `ref-in-new-issue` pop when issue was disabled (#15761) 
fix #15718

Signed-off-by: a1012112796 <1012112796@qq.com>
 2021-05-07 13:59:01 +02:00
zeripath bdc1697729
Drop back to use IsAnInteractiveSession for SVC (#15749) 
* Drop back to use IsAnInteractiveSession for SVC

There is an apparent permission change problem when using
IsWindowsService to determine if the SVC manager should be
used.

This PR simply drops back to using IsAnInteractiveSession as
this does not change behaviour.

Fix #15454

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Yes staticcheck I know this is deprecated

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Just leave me alone lint

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
 2021-05-07 11:27:31 +02:00
6543 640066840e
Use a generic markup class to display externally rendered files and diffs (#15735) 
* creates and implements generic markup less class

* How to give custom CSS to externally rendered html

* Clarifies sources of CSS styling of markup

* further clarification of sources of markup styling

* rename _markdown to _markup

* remove defunct import

* fix orphaned reference

* Update docs/content/doc/advanced/external-renderers.en-us.md

* more renames markdown -> markup

* do not suggest less customization

* add back tokens

* fix class whitespace, remove useless if-clause

* remove unused csv-data rules

* use named exports and rename functions

* sort imports

Co-authored-by: HarvsG <11440490+HarvsG@users.noreply.github.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
 2021-05-07 10:43:41 +02:00
silverwind 9b5185d3cc
Improve logo customization docs (#15754) 
* Improve logo customization docs

* Update docs/content/doc/advanced/customizing-gitea.en-us.md

* Update docs/content/doc/advanced/customizing-gitea.en-us.md

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2021-05-07 02:32:29 -04:00
zeripath 114c85e6ef
Fix bug where repositories appear unadopted (#15757) 
Fix bug where repositories with capital letters in their names appear unadopted.

Fix #15755

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2021-05-07 09:21:34 +08:00
zeripath edb838997c
Fix setting version table in dump (#15753) 
* Fix setting version table in dump

As noted on Discord there is a problem with gitea dump where the version table
is not being dumped correctly.

This is due to a missing pointer in the TableInfo.

This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update models_test.go
 2021-05-07 00:17:43 +01:00
N. L. H 45970ae82e
Feature/oauth userinfo (#15721) 
* Implemented userinfo #8534

* Make lint happy

* Add userinfo endpoint to openid-configuration

* Give an error when uid equals 0

* Implemented BearerTokenErrorCode handling

* instead of ctx.error use ctx.json so that clients
parse error and error_description correctly

* Removed unneeded if statement

* Use switch instead of subsequent if statements
Have a default for unknown errorcodes.

Co-authored-by: Nils Hillmann <hillmann@nlh-software.de>
Co-authored-by: nlhsoftware <nlhsoftware@noreply.localhost>
 2021-05-06 01:30:15 -04:00
6543 6a3ad0b24e
reverse #15734 partial and comment (#15740) 
* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: zeripath <art27@cantab.net>
 2021-05-06 00:05:54 -04:00
a1012112796 3088866531
fix some ui bug about draft release (#15137) 
* fix some ui bug about draft release

- should not show draft release in tag list because
  it will't create real tag
- still show draft release without tag and commit message
  for draft release instead of 404 error
- remove tag load for attachement links because it's useless

Signed-off-by: a1012112796 <1012112796@qq.com>

* add test code

* fix test

That's because has added a new release in relaese test database.

* fix dropdown link for draft release
 2021-05-06 05:12:50 +02:00
zeripath eedc0c8324
Defer closing the gitrepo until the end of the wrapped context functions (#15653) 
There was a mistake in #15372 where deferral of gitrepo close occurs before it should.

This PR fixes this.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2021-05-06 01:30:25 +02:00
zeripath e071b53686
Fix close button change on delete in simplemde area (#15737) 
* Fix close button change on delete in simplemde area

Fix issue with close button changing when deleting in the simplemde textarea.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* apply suggestion

Co-authored-by: 6543 <6543@obermui.de>
 2021-05-05 23:46:04 +01:00