mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-19 15:54:11 +01:00
Code Issues
12,984 Commits 17 Branches 213 Tags 610 MiB
2b55422cd7
Commit Graph

12984 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
wxiaoguang
2b55422cd7
Fix the bug: deploy key with write access can not push (#19010) 
Use DeployKeyID to replace the IsDeployKey, then CanWriteCode uses the DeployKeyID to check the write permission.
 2022-03-22 17:29:07 +08:00
KN4CK3R
80fd25524e
Renamed ctx.User to ctx.Doer. (#19161) 
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-03-22 15:03:22 +08:00
Robin
5495ba7660
[docs] Enhance container selection in docker dump (#14292) 
* Enhance container selection in docker dump

The problem with the previous query was, that it sometimes selected multiple containers, which make the command file with a hard to understand message. Now, use '^...$' to make sure a regex full match.
 2022-03-22 13:50:31 +08:00
Norwin
77d1c7bf2f
Cleanup protected branches when deleting users & teams (#19158) 
* Clean up protected_branches when deleting user

fixes #19094

* Clean up protected_branches when deleting teams

* fix issue

Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-03-22 09:09:45 +08:00
delvh
bfe2e3d562
Reorder issue templates and automatically add labels (#18875) 
* Reorder bug-report.yaml

* Add bug label on bug-report.yaml

* Add feature label on feature-request.yaml

* Reorder ui.bug-report.yaml

* Apply suggestions

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
 2022-03-21 20:00:25 +08:00
zeripath
b05b40180f
Use IterateBufferSize whilst querying repositories during adoption check (#19140) 
The adoption page checks directories to see if they are repositories by querying the
db on a per user basis. This can lead to problems if a user has a large number of
repositories or putative repositories.

This PR changes the buffering to check the db in IterataeBufferSize batches instead.

Fix #19137

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-21 09:09:42 +01:00
Sasha Melentyev
c604c9ae66
Add 1.18 (#19151) 
Co-authored-by: 6543 <6543@obermui.de>
 2022-03-21 11:22:34 +08:00
GiteaBot
572c63d237 [skip ci] Updated translations via Crowdin 2022-03-21 00:24:03 +00:00
Gusted
49c5fc565c
Fix NPE /repos/issues/search when not signed in (#19154) 
- Don't panic when on
`/repos/issues/search?{created,assigned,mentioned,review_requested}=true`
when client didn't pass any authentication.
- Resolves #19115
 2022-03-20 22:04:51 +01:00
GiteaBot
83a2f79d5d [skip ci] Updated licenses and gitignores 2022-03-20 00:24:18 +00:00
Abheek Dhawan
f96e8be41f
Use custom favicon when viewing static files if it exists (#19130) 
Redirect `/favicon.ico` to `/assets/img/favicon.png`.

Fix #19109
 2022-03-19 19:53:31 +00:00
zeripath
3322f4d7cc
not send notification emails to inactive users (part 2) (#19142) 
Unfortunately fixing changes to `mail_issue.go` did not get included in #19131.

We also need to not send issue comment mails to deactivated users.

Fix #18950

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-19 16:20:03 +00:00
zeripath
2d21d2af9e
Make migrations SKIP_TLS_VERIFY apply to git too (#19132) 
Make SKIP_TLS_VERIFY apply to git data migrations too through adding the `-c http.sslVerify=false` option to the git clone command.

Fix #18998

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-19 14:16:38 +00:00
zeripath
fb08d2b3fd
Do not send notification emails to inactive users (#19131) 
Emails should not be sent to inactive users except for Activate and ResetPassword
messages.

Fix #18950

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-19 20:45:44 +08:00
6543
60fbaa9068
remove not needed (#19128) 2022-03-18 20:17:57 +01:00
zeripath
fda5b9fc3e
Add warning to set SENDMAIL_ARGS to -- (#19102) 
Even with #17688 email addresses that contain an initial `-` may still be present in the db and it may in future still be possible to imagine a situation whereby initial `-` are repermitted.

This PR simply updates the documentation to warn users to set their SENDMAIL_ARGS with a terminal `--` to prevent this possibility email addresses being interpreted as options.

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-18 15:19:02 +01:00
zeripath
7fc5fd6415
Do not send activation email if manual confirm is set (#19119) 
If the mailer is configured then even if Manual confirm is set an activation email
is still being sent because `handleUserCreated` is not checking for this case.

Fix #17263

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-03-18 17:57:07 +08:00
silverwind
929b07fe45
Update tool dependencies (#19120) 
- Use tag over hash for all tool dependencies
- Update them to latest released versions
 2022-03-18 10:17:56 +08:00
Otto Richter (fnetX)
04fcf23ea3
Delete related notifications on issue deletion too (#18953) 
* use .Decr for issue comment counting

* Remove notification on issue removal
 2022-03-17 23:04:09 +01:00
6543
45f8d97131
nit fix (#19116) 2022-03-17 20:04:36 +02:00
Aravinth Manivannan
fa73cbf5a7
Store the foreign ID of issues during migration (#18446) 
Storing the foreign identifier of an imported issue in the database is a prerequisite to implement idempotent migrations or mirror for issues. It is a baby step towards mirroring that introduces a new table.

At the moment when an issue is created by the Gitea uploader, it fails if the issue already exists. The Gitea uploader could be modified so that, instead of failing, it looks up the database to find an existing issue. And if it does it would update the issue instead of creating a new one. However this is not currently possible because an information is missing from the database: the foreign identifier that uniquely represents the issue being migrated is not persisted. With this change, the foreign identifier is stored in the database and the Gitea uploader will then be able to run a query to figure out if a given issue being imported already exists.

The implementation of mirroring for issues, pull requests, releases, etc. can be done in three steps:

1. Store an identifier for the element being mirrored (issue, pull request...) in the database (this is the purpose of these changes)
2. Modify the Gitea uploader to be able to update an existing repository with all it contains (issues, pull request...) instead of failing if it exists
3. Optimize the Gitea uploader to speed up the updates, when possible.

The second step creates code that does not yet exist to enable idempotent migrations with the Gitea uploader. When a migration is done for the first time, the behavior is not changed. But when a migration is done for a repository that already exists, this new code is used to update it.

The third step can use the code created in the second step to optimize and speed up migrations. For instance, when a migration is resumed, an issue that has an update time that is not more recent can be skipped and only newly created issues or updated ones will be updated. Another example of optimization could be that a webhook notifies Gitea when an issue is updated. The code triggered by the webhook would download only this issue and call the code created in the second step to update the issue, as if it was in the process of an idempotent migration.

The ForeignReferences table is added to contain local and foreign ID pairs relative to a given repository. It can later be used for pull requests and other artifacts that can be mirrored. Although the foreign id could be added as a single field in issues or pull requests, it would need to be added to all tables that represent something that can be mirrored. Creating a new table makes for a simpler and more generic design. The drawback is that it requires an extra lookup to obtain the information. However, this extra information is only required during migration or mirroring and does not impact the way Gitea currently works.

The foreign identifier of an issue or pull request is similar to the identifier of an external user, which is stored in reactions, issues, etc. as OriginalPosterID and so on. The representation of a user is however different and the ability of users to link their account to an external user at a later time is also a logic that is different from what is involved in mirroring or migrations. For these reasons, despite some commonalities, it is unclear at this time how the two tables (foreign reference and external user) could be merged together.

The ForeignID field is extracted from the issue migration context so that it can be dumped in files with dump-repo and later restored via restore-repo.

The GetAllComments downloader method is introduced to simplify the implementation and not overload the Context for the purpose of pagination. It also clarifies in which context the comments are paginated and in which context they are not.

The Context interface is no longer useful for the purpose of retrieving the LocalID and ForeignID since they are now both available from the PullRequest and Issue struct. The Reviewable and Commentable interfaces replace and serve the same purpose.

The Context data member of PullRequest and Issue becomes a DownloaderContext to clarify that its purpose is not to support in memory operations while the current downloader is acting but is not otherwise persisted. It is, for instance, used by the GitLab downloader to store the IsMergeRequest boolean and sort out issues.

---
[source](https://lab.forgefriends.org/forgefriends/forgefriends/-/merge_requests/36)

Signed-off-by: Loïc Dachary <loic@dachary.org>
Co-authored-by: Loïc Dachary <loic@dachary.org>
 2022-03-17 18:08:35 +01:00
MeIchthys
a7de80db0d
Remove italics for due_date_not_set (#19113) 
To be more consistent with other `repo.issues.x` formatting, we can remove the italics from `dute_date_not_set`.
 2022-03-17 17:43:10 +02:00
GiteaBot
cc6ff74253 [skip ci] Updated translations via Crowdin 2022-03-17 00:24:18 +00:00
Fredrik Ekre
df31ac0e09
Fixed log path in fail2ban documentation (#19103) 
This updates the log path in the [gitea-docker] jail configuration
to match the path in the [gitea] jail, which was updated in #13726.
 2022-03-16 12:39:13 -04:00
techknowlogick
0b15a729cf
rm .sample hooks which aren't used (#19101) 2022-03-16 10:33:07 +00:00
techknowlogick
ed1d95c55d
use go1.18 to build gitea (#19099) 
* use go1.18 to build gitea& update min go version to 1.17

* bump in a few more places

* add a few simple tests for isipprivate

* update go.mod

* update URL to https://go.dev/dl/

* golangci-lint

* attempt golangci-lint workaround

* change version

* bump fumpt version

* skip strings.title test

* go mod tidy

* update tests as some aren't private??

* update tests
 2022-03-16 00:08:31 -04:00
silverwind
fe9626af29
Use go run for tool dependencies, require go 1.17 (#18874) 
This ensures the tools only run in the versions we've tested and it also
does not polute PATH with those tools so they are truly isolated. This
syntax of `go run` requires go 1.17, so the minimum version is set
accordingly.

Fixes: https://github.com/go-gitea/gitea/issues/18867

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-03-15 22:50:26 -04:00
Gusted
6ab4a96855
Update golang.org/x/crypto (#19097) 
* Update golang.org/x/crypto

- Update dependency to include fix for CVE.
- See https://groups.google.com/g/golang-announce/c/-cp44ypCT5s/m/wmegxkLiAQAJ?utm_medium=email&utm_source=footer

* Fix deprecation notice

* Remove workaround

- Introduced in https://github.com/go-gitea/gitea/pull/17281
- Fixed in x/crypto:
- 5d542ad81a
- & 3147a52a75

* Update Kex Algorithms

- Use standardized name for curve22519-sha256. 9b076918e3
- Prefer SHA256 version over SHA1 version. e4b3678e5f
 2022-03-16 02:59:53 +01:00
KN4CK3R
c88f2e2acc
Handle email address not exist. (#19089) 2022-03-15 10:18:39 +01:00
6543
2ba72cedbe
Frontport Changelogs (#19088) 
* Frontport Changelogs

* bump version in docs
 2022-03-14 23:18:01 +01:00
Lunny Xiao
18033f49ba
Restrict email address validation (#17688) 
This didn't follow the RFC but it's a subset of that. I think we should narrow the allowed chars at first and discuss more possibility in future PRs.
 2022-03-14 18:39:54 +01:00
Lunny Xiao
49db87a035
Fix lfs bug (#19072) 
* Fix lfs bug
 2022-03-14 16:18:27 +01:00
GiteaBot
3ad6cf2069 [skip ci] Updated translations via Crowdin 2022-03-14 00:11:34 +00:00
mscherer
35541f853b
Fix documentation and #19065 (#19067) 2022-03-13 18:30:58 +01:00
6543
bc0d2c8ada
RSS/Atom support for Repos (#19055) 
* support for repos
* refactor
* advertise the feeds via meta tags
* allow feed suffix and feed header
* optimize performance
 2022-03-13 17:40:47 +01:00
GiteaBot
780cf76f6e [skip ci] Updated licenses and gitignores 2022-03-13 00:11:52 +00:00
Norwin
9cca834aac
Feeds: render markdown to html (#19058) 
* feeds: render markdown to html
 2022-03-12 23:05:12 +01:00
GiteaBot
a0c043f5c6 [skip ci] Updated translations via Crowdin 2022-03-12 00:11:48 +00:00
zeripath
a223bc8765
Prevent 500 when there is an error during new auth source post (#19041) 
Fix #19036

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-10 23:40:43 +01:00
zeripath
886b1de949
Update the webauthn_credential_id_sequence in Postgres (#19048) 
* Update the webauthn_credential_id_sequence in Postgres

There is (yet) another problem with v210 in that Postgres will silently allow preset
ID insertions ... but it will not update the sequence value.

This PR simply adds a little step to the end of the v210 migration to update the
sequence number.

Users who have already migrated who find that they cannot insert new
webauthn_credentials into the DB can either run:

```bash
gitea doctor recreate-table webauthn_credential
```

or

```bash
./gitea doctor --run=check-db-consistency --fix
```

which will fix the bad sequence.

Fix #19012

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-10 23:04:55 +01:00
zeripath
a0db075f21
If rendering has failed due to a net.OpError stop rendering (attempt 2) (#19049) 
Unfortunately #18642 does not work because a `*net.OpError` does not implement
the `Is` interface to make `errors.Is` work correctly - thus leading to the
irritating conclusion that a `*net.OpError` is not a `*net.OpError`.

Here we keep the `errors.Is` because presumably this will be fixed at
some point in the golang main source code but also we add a simply type
cast to also check.

Fix #18629

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-10 20:23:15 +00:00
6543
ba470a85dd
use xorm builder for models.getReviewers() (#19033) 
* xorm builder

* dedup code
 2022-03-10 19:12:10 +01:00
6543
cc98737ca8
RSS/Atom support for Orgs (#17714) 
part of #569
 2022-03-10 15:54:51 +01:00
Norwin
5fdd30423e
Fix flag validation (#19046) 
Regression from #5785
 2022-03-10 10:11:26 +00:00
zeripath
75eb6cc9c1
Improve SyncMirrors logging (#19045) 
Yet another issue has come up where the logging from SyncMirrors does not provide
enough context. This PR adds more context to these logging events.

Related #19038

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-03-10 10:09:48 +00:00
zeripath
1314f38b59
fix pam authorization (#19040) 
https://huntr.dev/bounties/8d221f92-b2b1-4878-bc31-66ff272e5ceb/

Co-authored-by: ysf <34326+ysf@users.noreply.github.com>
 2022-03-10 10:00:05 +08:00
GiteaBot
7443213707 [skip ci] Updated translations via Crowdin 2022-03-10 00:11:57 +00:00
Lunny Xiao
2448c5ad8b
Upgrading binding package (#19034) 
Fix #18855
 2022-03-09 18:06:58 +00:00
wxiaoguang
c21735b49a
Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (#19028) 
When DISABLE_HTTP_GIT is set we should always show the SSH button
 2022-03-09 12:42:29 +08:00
Otto Richter (fnetX)
ea46142bce
Add button for issue deletion (#19032) 
Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
 2022-03-09 01:38:11 +01:00