15514 Commits

All Branches

Search

Author	SHA1	Message	Date
silverwind	1cf4d46bb1	Reduce verbosity of dev commands (#24917) ... ### Before ``` $ make watch bash build/watch.sh make[1]: Entering directory '/Users/silverwind/git/gitea' make[1]: Entering directory '/Users/silverwind/git/gitea' GITEA_RUN_MODE=dev go run github.com/cosmtrek/air@v1.43.0 -c .air.toml rm -rf public/js public/css public/fonts public/img/webpack public/serviceworker.js NODE_ENV=development npx webpack --watch --progress ``` ### After ``` $ make watch GITEA_RUN_MODE=dev go run github.com/cosmtrek/air@v1.43.0 -c .air.toml NODE_ENV=development npx webpack --watch --progress ```	2023-05-24 20:11:04 +00:00
wxiaoguang	395bb33e4c	Merge different languages for language stats (#24900) ... Fix #24896 If users set different languages by `linguist-language`, the `stats` map could be: `java: 100, Java: 200`. Language stats are stored as case-insensitive in database and there is a unique key. So, the different language names should be merged to one unique name: `Java: 300`	2023-05-24 19:37:36 +00:00
Philip Peterson	63d5e762d8	Add missing test case and fix typo in tests (#24915) ... This PR adds a missing assertion in the `TestGetOrgUsersByOrgID` function. It also incidentally fixes a small typo.	2023-05-24 21:06:04 +02:00
Panagiotis "Ivory" Vasilopoulos	2250ddd112	Improve confusable character string (#24911) ... Very small UX change, "confusable" is a word that is indeed valid, but when you look it up online, it doesn't take long for this adjective to appear in [its technical Unicode-related context](https://util.unicode.org/UnicodeJsps/confusables.jsp). I think that it throws me off as a person that doesn't speak English natively. I think that this could be replaced with "can be confused with". As the change is very small and purely a matter of preference, if you (the maintainer) believe that this shouldn't be included, feel free to close this without any further discussion, as your time would probably be better used elsewhere.	2023-05-24 16:39:33 +02:00
silverwind	1fd7e3d6be	Improve Actions CSS (#24864) ... - Various color tweaks - Add sticky positioning to left sidebar, right header and right step header - Adjust margins and border radiuses <img width="1235" alt="Screenshot 2023-05-23 at 11 18 06" src="https://github.com/go-gitea/gitea/assets/115237/f601b00d-c7f2-43de-89f2-3ac55f2d9cdc"> <img width="1239" alt="Screenshot 2023-05-23 at 11 18 18" src="https://github.com/go-gitea/gitea/assets/115237/a2d24cc9-29fa-4c17-906b-84feea14b889">   --------- Co-authored-by: yp05327 <576951401@qq.com>	2023-05-24 09:00:29 +00:00
HesterG	9ad5cadc07	Fix <empty> in administration/config-cheat-sheet.en-us.md (#24905) ... Before <img width="206" alt="Screen Shot 2023-05-24 at 15 54 02" src="https://github.com/go-gitea/gitea/assets/17645053/3493180e-e7a8-466d-b418-641c39d7788c"> <img width="272" alt="Screen Shot 2023-05-24 at 15 50 05" src="https://github.com/go-gitea/gitea/assets/17645053/b1c80313-5b2c-41d8-aad3-4099c912c173"> <img width="264" alt="Screen Shot 2023-05-24 at 15 50 16" src="https://github.com/go-gitea/gitea/assets/17645053/9a4b4223-ce67-40b3-a44e-03219694a37d"> After <img width="295" alt="Screen Shot 2023-05-24 at 15 52 53" src="https://github.com/go-gitea/gitea/assets/17645053/fbc8ef6e-2b9b-44f5-ba4f-6002cf2f19fe"> <img width="334" alt="Screen Shot 2023-05-24 at 15 53 03" src="https://github.com/go-gitea/gitea/assets/17645053/6ebe45bf-b986-4afc-9b5c-d0c0134650c2"> <img width="282" alt="Screen Shot 2023-05-24 at 15 53 13" src="https://github.com/go-gitea/gitea/assets/17645053/90ccc1ae-69f5-4730-8191-5e86ed0f6d49">	2023-05-24 16:29:44 +08:00
Lunny Xiao	a523bd5889	Only validate changed columns when update user (#24867) ... Fix #23211 Replace #23496	2023-05-24 07:30:55 +00:00
Lunny Xiao	37895b61c0	Rename docs packages title from xxx Packages Repository -> xxx Package Registry (#24895) ... As title.	2023-05-24 06:21:39 +00:00
yp05327	fd1967c3a4	Fix can’t move anymore items in repo project boards (#24892) ... Fix #24879 Related to #24589 In #24589, I changed the css, but didn't reflect the changes in repo-level projects template.	2023-05-24 14:05:50 +08:00
wxiaoguang	c21605951b	Make environment-to-ini support loading key value from file (#24832) ... Replace #19857 Close #19856 Close #10311 Close #10123 Major changes: 1. Move a lot of code from `environment-to-ini.go` to `config_env.go` to make them testable. 2. Add `__FILE` support 3. Update documents 4. Add tests	2023-05-24 11:37:22 +08:00
Zettat123	1aa9107fea	`zh-cn` translation for administration docs (#24881) ... - [x] adding-legal-pages - [x] cmd-embedded - [x] command-line - [x] email-setup - [x] external-renderers - [x] git-lfs-support - [x] logging-config - [x] mail-templates - [x] repo-indexer - [x] search-engines-indexation - [x] signing	2023-05-24 10:35:43 +08:00
silverwind	64e0672e3b	Fix `@font-face` overrides (#24855) ... Fixes: https://github.com/go-gitea/gitea/issues/24850 Not sure how to do it for asian fonts only, so let's revert to previous value for now. ### Before <img width="414" alt="Screenshot 2023-05-22 at 10 34 10" src="https://github.com/go-gitea/gitea/assets/115237/749f1556-a5cf-48fe-8b10-8dc447221657"> ### After <img width="416" alt="Screenshot 2023-05-22 at 10 34 04" src="https://github.com/go-gitea/gitea/assets/115237/a0a315bb-d95f-4d03-863e-0534f665ca71">	2023-05-24 01:48:51 +00:00
wxiaoguang	979f08053f	Fix logger refactoring regression: manager logging add (#24847) ... The `rotate` option is optional. Test result: 	2023-05-24 08:09:33 +08:00
techknowlogick	21add7ea88	Remove publish docs CI workflow (#24889) ... Now that the redirect to docs.gitea.com is in place this is no longer needed.	2023-05-23 20:41:27 +00:00
HesterG	0e84bd2514	Fix double border and adjust width for user profile page (#24870) ... Close #24848	2023-05-23 17:55:51 +00:00
wxiaoguang	8080ace6fc	Support changing git config through `app.ini`, use `diff.algorithm=histogram` by default (#24860) ... Close #13454 , Close #23255, Close #14697 (and maybe more related issues) Many users have the requirement to customize the git config. This PR introduces an easy way: put the options in Gitea's app.ini `[git.config]`, then the config options will be applied to git config. And it can support more flexible default config values, eg: now `diff.algorithm=histogram` by default. According to: https://stackoverflow.com/a/32367597/4754037 , `histogram diff` is efficient and doesn't like to cause server-side problems. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-23 16:30:19 +00:00
wxiaoguang	910bf31546	Fix flakey test in logger test (#24883) ... Fix #24882 The goroutines are all asynchronized. So it needs a little "sleep" to make sure the writer's goroutine has been paused before sending messages to it. Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-23 16:01:20 +00:00
silverwind	a9d417341c	Run stylelint on .vue files (#24865) ... - Run stylelint on .vue files - Fix discovered issues - Suppress warning spam from `declaration-strict-value` rule Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-23 13:54:21 +00:00
John Olheiser	116066ecfa	Update `CONTRIBUTING.md` (#24492) ... Previously, the `CONTRIBUTING` was severely outdated in certain aspects such as workflows. These sections have been brought up to date. Furthermore, the `CONTRIBUTING` now mentions the TOC, how it is structured, elected, and its duties. --------- Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: delvh <dev.lh@web.de>	2023-05-23 14:22:40 +02:00
wxiaoguang	16a766cba1	Do not call nil handler for a dummy queue (#24880) ... A dummy queue doesn't really have a handler (see line 211), so the `safeHandler` can safely drop all items	2023-05-23 13:40:55 +02:00
Lunny Xiao	cfadb1901f	Remove unnecessary usage prefix from doc titles (#24869) ... As title.	2023-05-23 18:14:57 +08:00
JakobDev	25dc1556cd	Add API for Label templates (#24602) ... This adds API that allows getting the Label templates of the Gitea Instance	2023-05-23 18:10:23 +08:00
wxiaoguang	abcf5a7b5e	Fix install page context, make the install page tests really test (#24858) ... Fix #24856 Rename "context.contextKey" to "context.WebContextKey", this context is for web context only. But the Context itself is not renamed, otherwise it would cause a lot of changes (if we really want to rename it, there could be a separate PR). The old test code doesn't really test, the "install page" gets broken not only one time, so use new test code to make sure the "install page" could work.	2023-05-23 09:29:15 +08:00
yp05327	5c0745c034	Add validations.required check to dropdown field (#24849) ... If dropdown is marked as required, we should not provide the `remove` button. This will cause user may post empty value which seems like a bug. Definition:  Post request form:  Result: 	2023-05-22 21:26:48 +00:00
wxiaoguang	81ce271f78	Use Go 1.20 for next release (#24859)	2023-05-22 16:29:53 +00:00
Brecht Van Lommel	3588edbb08	Add gitea manager reload-templates command (#24843) ... This can be useful to update custom templates in production mode, when they are updated frequently and a full Gitea restart each time is disruptive.	2023-05-22 23:51:40 +08:00
yp05327	922c83eea3	Remove `In your repositories` link in milestones dashboard (#24853) ... It is unnecessary to it.	2023-05-22 11:42:57 +00:00
yp05327	a3a8594f75	Fix 500 error when select `No assignee` filter in issue list page (#24854) ... Access the issue list page and select `No assignee`, you will get 500 error:  You can see this page in try.gitea.io: https://try.gitea.io/yp05327/testrepo/issues?q=&type=all&sort=&state=open&labels=&milestone=0&project=0&assignee=-1&poster=0 Caused by https://github.com/go-gitea/gitea/pull/24707/files#diff-d7c7dc2da4fcfdc09997648e11a018414dc116472054350b5590ab407adcd44dR1748 Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-22 13:08:27 +02:00
yp05327	bebc3433c5	Add IsErrRepoFilesAlreadyExist check when fork repo (#24678) ... Before:  After: 	2023-05-22 18:21:46 +08:00
yp05327	f4ef7eed00	Fix missing yes/no in delete time log modal (#24851) ... Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-22 09:46:50 +00:00
wxiaoguang	bb9e20e434	Fix document and improve comment (#24844) ... * Fix broken doc link: https://github.com/go-gitea/gitea/actions/runs/5041309438/jobs/9040887385 * Improve comments about how font weight works: https://github.com/go-gitea/gitea/pull/24827#pullrequestreview-1435584800 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-05-22 08:47:33 +00:00
Brecht Van Lommel	32ec2540cc	Show new pull request button also on subdirectories and files (#24842) ... Instead of only on the repository home page. Saves a click and makes this functionality a bit easier to find when editing files in a subdirectory.	2023-05-22 07:57:00 +00:00
HesterG	da461b5a08	Improvements for action detail page (#24718) ... Close #24625 Main changes: 1. For the left panel, show rerun icon only on hover, and add style when the job is selected, and removed icon on the "rerun all" button and modify the text on the button https://github.com/go-gitea/gitea/assets/17645053/cc437a17-d2e9-4f1b-a8cf-f56e53962767 2. Adjust fonts, and add on hover effects to the log lines. And add loading effect when the job is done and the job step log is expanded for the first time. (With reference to github) https://github.com/go-gitea/gitea/assets/17645053/2808d77d-f402-4fb0-8819-7aa0a018cf0c 3. Add `gt-ellipsis` to `step-summary-msg` and `job-brief-name` <img width="898" alt="ellipsis" src="https://github.com/go-gitea/gitea/assets/17645053/e2fb7049-3125-4252-970d-15b0751febc7"> 4. Fixed https://github.com/go-gitea/gitea/issues/24625#issuecomment-1541380010 by adding explicit conditions to `ActionRunStatus.vue` and `status.tmpl` 5. Adjust some css styles --------- Co-authored-by: silverwind <me@silverwind.io>	2023-05-22 12:17:24 +08:00
KN4CK3R	cdb088cec2	Add CRAN package registry (#22331) ... This PR adds a [CRAN](https://cran.r-project.org/) package registry. 	2023-05-22 10:57:49 +08:00
wxiaoguang	ec2a01d1e2	Fix regression: access log template, gitea manager cli command (#24838) ... Close #24836  	2023-05-22 09:38:38 +08:00
Brecht Van Lommel	2d3ebe889e	Merge message template support for rebase without merge commit (#22669) ... Use `default_merge_message/REBASE_TEMPLATE.md` for amending the message of the last commit in the list of commits that was merged. Previously this template was mentioned in the documentation but not actually used. In this template additional variables `CommitTitle` and `CommitBody` are available, for the title and body of the commit. Ideally the message of every commit would be updated using the template, but doing an interactive rebase or merging commits one by one is complicated, so that is left as a future improvement.	2023-05-22 09:01:46 +08:00
GiteaBot	84d93c82cd	[skip ci] Updated licenses and gitignores	2023-05-22 00:25:26 +00:00
wxiaoguang	2cb66fff60	Support wildcard in email domain allow/block list (#24831) ... Replace #20257 (which is stale and incomplete) Close #20255 Major changes: * Deprecate the "WHITELIST", use "ALLOWLIST" * Add wildcard support for EMAIL_DOMAIN_ALLOWLIST/EMAIL_DOMAIN_BLOCKLIST * Update example config file and document * Improve tests	2023-05-22 00:05:44 +00:00
silverwind	19993d8814	Change `--font-weight-bold` to `--font-weight-semibold` and 600 value, introduce new font weight variables (#24827) ... There was some recent discussion about this in Discord `ui-design` channel and the conclusion was that https://github.com/go-gitea/gitea/issues/24305 should have fixed their OS font installation to have semibold weights. I have now tested this 601 weight on a Windows 10 machine on Firefox myself, and I immediately noticed that bold was excessivly bold and rendering as 700 because browsers are biased towards bolder fonts. So revert this back to the previous value.	2023-05-21 23:37:32 +00:00
wxiaoguang	4647660776	Rewrite logger system (#24726) ... ## ⚠️ Breaking The `log.<mode>.<logger>` style config has been dropped. If you used it, please check the new config manual & app.example.ini to make your instance output logs as expected. Although many legacy options still work, it's encouraged to upgrade to the new options. The SMTP logger is deleted because SMTP is not suitable to collect logs. If you have manually configured Gitea log options, please confirm the logger system works as expected after upgrading. ## Description Close #12082 and maybe more log-related issues, resolve some related FIXMEs in old code (which seems unfixable before) Just like rewriting queue #24505 : make code maintainable, clear legacy bugs, and add the ability to support more writers (eg: JSON, structured log) There is a new document (with examples): `logging-config.en-us.md` This PR is safer than the queue rewriting, because it's just for logging, it won't break other logic. ## The old problems The logging system is quite old and difficult to maintain: * Unclear concepts: Logger, NamedLogger, MultiChannelledLogger, SubLogger, EventLogger, WriterLogger etc * Some code is diffuclt to konw whether it is right: `log.DelNamedLogger("console")` vs `log.DelNamedLogger(log.DEFAULT)` vs `log.DelLogger("console")` * The old system heavily depends on ini config system, it's difficult to create new logger for different purpose, and it's very fragile. * The "color" trick is difficult to use and read, many colors are unnecessary, and in the future structured log could help * It's difficult to add other log formats, eg: JSON format * The log outputer doesn't have full control of its goroutine, it's difficult to make outputer have advanced behaviors * The logs could be lost in some cases: eg: no Fatal error when using CLI. * Config options are passed by JSON, which is quite fragile. * INI package makes the KEY in `[log]` section visible in `[log.sub1]` and `[log.sub1.subA]`, this behavior is quite fragile and would cause more unclear problems, and there is no strong requirement to support `log.<mode>.<logger>` syntax. ## The new design See `logger.go` for documents. ## Screenshot <details>    </details> ## TODO * [x] add some new tests * [x] fix some tests * [x] test some sub-commands (manually ....) --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-21 22:35:11 +00:00
Brecht Van Lommel	65dff8e364	Support Copy Link for video attachments (#24833) ... Creating a `<video>` tag with controls and title.	2023-05-21 22:06:17 +00:00
Brecht Van Lommel	268d121f4b	Fix video width overflow in markdown, and other changes to match img (#24834) ... This change makes the CSS for `<video>` in markup match that of `<img>`, and also allows additional attributes to be used. This way the width, padding, alignment should work equally well for both.	2023-05-21 21:19:37 +00:00
delvh	e95b42e187	Improve accessibility when (re-)viewing files (#24817) ... Visually, nothing should have changed. Changes include - Convert most `<a [no href]>` to `<button>` when (re-)viewing files: - `<a [no href]>` are, by HTML definition, not a link and hence cannot be focused - `<a class="ui button">` can now be clicked (again?) using <kbd>Enter</kbd> - Previously, the installed keypress handler on `.ui.button` elements disabled it for links somehow - The `(un)escape file`, the `expand section` and the `expand/collapse file` buttons can now be focused (and subsequently clicked using only the keyboard) - You can now press <kbd>Space</kbd> on a focused `View file` checkbox to mark the file as viewed. - previously, this was impossible as this checkbox listened on the wrong event listener The `add code comment` button has been left inaccessible for now as it requires quite a bit of extra logic so that it is unhidden when it is focused (you can otherwise focus it without seeing it as you are not hovering on the corresponding line). --------- Co-authored-by: silverwind <me@silverwind.io>	2023-05-21 20:47:41 +00:00
Lunny Xiao	c59a057297	Refactor rename user and rename organization (#24052) ... This PR is a refactor at the beginning. And now it did 4 things. - [x] Move renaming organizaiton and user logics into services layer and merged as one function - [x] Support rename a user capitalization only. For example, rename the user from `Lunny` to `lunny`. We just need to change one table `user` and others should not be touched. - [x] Before this PR, some renaming were missed like `agit` - [x] Fix bug the API reutrned from `http.StatusNoContent` to `http.StatusOK`	2023-05-21 23:13:47 +08:00
Lunny Xiao	64f6a5d113	Use `CommentList` instead of `[]*Comment` (#24828) ... As title.	2023-05-21 20:48:28 +08:00
Yarden Shoham	edd8ea0b0d	Fix topics deleted via API not being deleted in org page (#24825) ... The topics are saved in the `repo_topic` table. They are also saved directly in the `repository` table. Before this PR, only `AddTopic` and `SaveTopics` made sure the `topics` field in the `repository` table was synced with the `repo_topic` table. This PR makes sure `GenerateTopics` and `DeleteTopic` also sync the `topics` in the repository table. `RemoveTopicsFromRepo` doesn't need to sync the data as it is only used to delete a repository. Fixes #24820	2023-05-21 11:03:20 +02:00
Yevhen Pavlov	1dfaf83798	Return `404` in the API if the requested webhooks were not found (#24823) ... Should resolve first point of the issue https://github.com/go-gitea/gitea/issues/24574	2023-05-21 10:54:28 +08:00
wxiaoguang	6b33152b7d	Decouple the different contexts from each other (#24786) ... Replace #16455 Close #21803 Mixing different Gitea contexts together causes some problems: 1. Unable to respond proper content when error occurs, eg: Web should respond HTML while API should respond JSON 2. Unclear dependency, eg: it's unclear when Context is used in APIContext, which fields should be initialized, which methods are necessary. To make things clear, this PR introduces a Base context, it only provides basic Req/Resp/Data features. This PR mainly moves code. There are still many legacy problems and TODOs in code, leave unrelated changes to future PRs.	2023-05-21 09:50:53 +08:00
GiteaBot	6ba4f89723	[skip ci] Updated translations via Crowdin	2023-05-21 00:26:26 +00:00
silverwind	32d9c47ec7	Add RTL rendering support to Markdown (#24816) ... Support RTL content in Markdown:  Example document: https://try.gitea.io/silverwind/symlink-test/src/branch/master/bidi-text.md Same on GitHub: https://github.com/silverwind/symlink-test/blob/master/bidi-text.md `dir=auto` enables a browser heuristic that sets the text direction automatically. It is the only way to get automatic text direction. Ref: https://codeberg.org/Codeberg/Community/issues/1021 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-05-20 23:02:52 +02:00