mirror/gitea
1
1
Fork 1
mirror of https://github.com/go-gitea/gitea.git synced 2024-11-16 02:13:25 +01:00
Code Issues
13,721 Commits 17 Branches 213 Tags 610 MiB
0724ca451e
Commit Graph

13721 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
zeripath
0724ca451e
Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (#20839) 
Some repositories do not have the PullRequest unit present in their configuration
and unfortunately the way that IsUserAllowedToUpdate currently works assumes
that this is an error instead of just returning false.

This PR simply swallows this error allowing the function to return false.

Fix #20621

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-08-18 13:31:15 +03:00
Lunny Xiao
999392f6a5
Fix owners cannot create organization repos bug (#20841) 
* Fix owners cannot create organization repos bug

* Fix api

* Update routers/api/v1/org/team.go

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
 2022-08-18 11:58:21 +03:00
Lunny Xiao
5d0f643461
Fix migration file name (#20843) 2022-08-18 13:38:59 +08:00
zeripath
03df7d0452
Check Mirror exists before linking its Repo (#20840) 
In MirrorRepositoryList.loadAttributes there is some code to load the Mirror entries
from the database. This assumes that every Repository which has IsMirror set has
a Mirror associated in the DB. This association is incorrect in the case of
Mirror repository under creation when there is no Mirror entry in the DB until
completion.

Unfortunately LoadAttributes makes this incorrect assumption and presumes that a
Mirror will always be loaded. This then causes a panic.

This PR simply double checks if there a Mirror before attempting to link back to
its Repo. Unfortunately it should be expected that there may be other cases where
this incorrect assumption causes further problems.

Fix #20804

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-18 10:22:56 +08:00
techknowlogick
4a797f8fab [skip ci] Updated translations via Crowdin 2022-08-18 00:21:28 +00:00
techknowlogick
d8e6c99125
Add badge capabilities to users (#20607) 
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
 2022-08-18 02:25:25 +03:00
xinyu
208b4ee417
docs[zh-cn]: Managing Deployments With Environment Variables (#20817) 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-17 15:44:07 -04:00
zeripath
87ca739a3f
Correctly escape within tribute.js (#20831) 
When writing html in tribute.js ensure that strings are properly escaped.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-08-17 15:43:53 -04:00
Balki
c138e76c1c
Fix panic when an invalid oauth2 name is passed (#20820) 2022-08-17 14:25:28 -04:00
parnic
7503cd35c2
Use the total issue count for UI (#20785) 
* Use the total issue count for UI

This fixes a problem where the "All" line item on the Issues or Pull Requests page was only showing the count of the selected repos instead of the total of all issues/prs in all repos.

The "total number of shown issues" number is now stashed in a different context variable in case it wants to be used by the frontend later. It's currently not being used.

Fixes #20574

* Remove unused context variable

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-17 21:13:41 +08:00
Lunny Xiao
a4e91c4197
Add proxy host into allow list (#20798) 
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-16 20:15:54 -04:00
silverwind
1e0fcd1450
Fix tooltip init after review (#20814) 
* Fix tooltip init after review

Previous code passed a jQuery collection which initTooltip couldn't
handle. Instead, iterate the individial matched elements and add a
dollar to the variable name to make it clear it's jQuery.

Fixes: https://github.com/go-gitea/gitea/issues/20809
 2022-08-17 00:05:40 +03:00
Will Norris
82f89ff996
auth/reverseproxy: Add support for full name (#20776) 
This adds support for getting the user's full name from the reverse
proxy in addition to username and email.

Tested locally with caddy serving as reverse proxy with Tailscale
authentication.

Signed-off-by: Will Norris <will@tailscale.com>

Signed-off-by: Will Norris <will@tailscale.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-16 14:30:27 +08:00
Lunny Xiao
1f146090ec
Add migrate repo archiver and packages storage support on command line (#20757) 
* Add migrate repo archiver and packages storage support on command line

* Fix typo

* Use stdCtx

* Use packageblob and fix command description

* Add migrate packages unit tests

* Fix comment year

* Fix the migrate storage command line description

* Update cmd/migrate_storage.go

Co-authored-by: zeripath <art27@cantab.net>

* Update cmd/migrate_storage.go

Co-authored-by: zeripath <art27@cantab.net>

* Update cmd/migrate_storage.go

Co-authored-by: zeripath <art27@cantab.net>

* Fix test

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
 2022-08-16 12:05:15 +08:00
Lunny Xiao
86c85c19b6
Refactor AssertExistsAndLoadBean to use generics (#20797) 
* Refactor AssertExistsAndLoadBean to use generics

* Fix tests

Co-authored-by: zeripath <art27@cantab.net>
 2022-08-16 10:22:25 +08:00
MaeIsBad
e3308a092a [skip ci] Updated translations via Crowdin 2022-08-16 00:20:56 +00:00
MaeIsBad
f158840606
Fix the commit diff route (#20796) 
Gitea used to return 500 on the /:user/:repo/:commit route due to locale
being undefined in the escape_title template.

Co-authored-by: bad <badatnames@tutanota.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: zeripath <art27@cantab.net>
 2022-08-15 14:13:08 +08:00
xpy
efaa9958b5
Fix push mirror address backend get error Address cause setting page display error (#20593) 
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-14 23:12:01 -04:00
zeripath
58a4407acb
Remove follow from commits by file (#20765) 
The use of `--follow` makes getting these commits very slow on large repositories
as it results in searching the whole commit tree for a blob.

Now as nice as the results of `--follow` are, I am uncertain whether it is really
of sufficient importance to keep around.

Fix #20764

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-14 21:22:13 -04:00
Gusted
7ae297800e [skip ci] Updated translations via Crowdin 2022-08-15 00:20:43 +00:00
Gusted
293544587c
Fix make watch for generated files (#20794) 
- Don't rebuild the binary when generated files are updated, which is the
case by-default when running `make watch`.
 2022-08-14 22:22:09 +01:00
Gusted
4f56ab3bf3
Add missing translation for queue flush workers (#20791) 
- Add a missing translation key and value for the flush worker indication
- Resolves #20770
 2022-08-14 20:28:19 +01:00
PEN²
cf0fef2c30
Update zh-cn translation for Installation from source (#20772) 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-14 12:03:12 -04:00
Gusted
6a43d62e8b
Improve comment header for Mobile (#20781) 
- Since
b9e8fa5beb
the avatar will be inlined into the comment header, so there's more room
for the actual comment container(thus more text per line in the comment
body). However this didn't take into consideration that the flex didn't
allow any wrapping and thus was shrinking the avatar. Well this isn't a
perfect solution, as you ideally all want these elements to be
individually wrapped(such that `comment-header-right` can be on the same
line as `comment-header-left`, which now causes a new line in certain
situations). It's a better solution than the current CSS and to not
mess with the desktop CSS/HTML.

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
 2022-08-14 12:02:59 -04:00
PEN²
070e5d4a4a
Add myself to MAINTAINERS (#20786) 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-14 13:08:53 +03:00
Frank
cc649f0cb3 [skip ci] Updated licenses and gitignores 2022-08-14 00:20:44 +00:00
Frank
1f0638747b
Preserve unix socket file (#20499) 
By default Gitea will always unlink any sockets that are provided using the `LISTEN_FDS` environment variable. This is because it uses this variable to handle passing when it is doing a graceful restart. However, this same mechanism is used by systemd - which explicitly expects that passed in sockets should not be unlinked by the receiving process. 

This PR adjusts Gitea's graceful restart mechanism to use an additional environment variable which tracks if a listening socket was opened by Gitea - and therefore should be unlinked on shutdown by Gitea.

Fix #20490

Co-authored-by: zeripath <art27@cantab.net>
 2022-08-13 22:31:33 +01:00
zeripath
99efa02edf
Switch Unicode Escaping to a VSCode-like system (#19990) 
This PR rewrites the invisible unicode detection algorithm to more
closely match that of the Monaco editor on the system. It provides a
technique for detecting ambiguous characters and relaxes the detection
of combining marks.

Control characters are in addition detected as invisible in this
implementation whereas they are not on monaco but this is related to
font issues.

Close #19913

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-08-13 19:32:34 +01:00
wxiaoguang
11dc6df5be
Fix git.Init for doctor sub-command (#20782) 2022-08-14 00:33:18 +08:00
PEN²
3d7058adbe
Remove the translation key website by PR #20777 (#20779) 2022-08-13 02:24:21 -04:00
PEN²
bbce94ee91
Move the official website link at the footer of gitea (#20777) 2022-08-12 20:34:53 -05:00
silverwind
20b3a90450
Remove useless JS operation for relative time tooltips (#20756) 
This operation that shifts the content from title to data-content is
useless when we can directly render the expected HTML instead.

This change does prevent these tooltips from working when the user has
JS disabled in their browser, but I think we made it clear by now that
JS is required for gitea to work properly.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-12 17:03:41 -04:00
silverwind
74515d3d17
Remove debug output when coverage fails (#20733) 
* Remove debug output when coverage fails

When coverage fails, it logs megabytes of debug to stdout, which seems
to break the drone ui as well as the log output download in drone,
presumably because of the size. I think with removal of this print, we
should still see any errors created by gocovmerge.go, but a few CI runs
may be necessary to get it to fail again.

* Update Makefile

* restart ci

* restart ci

* restart ci

* restart ci

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-12 16:13:31 -04:00
silverwind
d30e02255f
Slightly reduce exclamation icon size (#20753) 
It seemed a tad to big compared to other icons. Shrink it slightly.

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-12 13:51:33 -04:00
Lunny Xiao
d26b652260
Fix disabled open in vscode menu when disabling download source from UI (#20713) 2022-08-12 13:16:05 +08:00
oliverpool
c81b26b0e5
refactor webhook *NewPost (#20729) 
* refactor webhook *NewPost

* remove empty values

* always show errs.Message

* remove utils.IsValidSlackChannel

* move IsValidSlackChannel to services/webhook package

* binding: handle empty Message case

* make IsValidSlackChannel more strict
 2022-08-11 17:48:23 +02:00
Kiel Hurley
2b4d43dd4d
Add SAML SP status to Feature Comparison docs (#20743) 
* Add SAML SP integration

Add current SAML 2.0 Service Provider (SP) status. RhodeCode EE supports SAML, CE does not.

Included issue links for both Gitea and Gogs, as corporate users will likely be interested in the status of both.

* Add SAML SP status to comparison for other translations

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-08-11 07:04:09 +02:00
silverwind
57f1ea0366
Fix loading button with invalid form (#20754) 
Previously, if a invalid form was submitted (for example issue with no
title), the form could not be re-submitted again because the button
would not stay stuck in loading state. Fix that by hooking the 'submit'
event instead which triggers only when the form is valid.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-08-11 11:54:34 +08:00
Gusted
54d9816502 [skip ci] Updated translations via Crowdin 2022-08-11 00:20:58 +00:00
Gusted
c315868b97
Make branch icon stand out more (#20726) 
* Make branch icon stand out more

- Currently the branch icon is "squashed" between the two branch names
and feels a bit "amateur-ish" to my feeling(relative to other UI
elements).
- This patch tries to improve that by making the icon bigger
and by adding some margin to not have a "squashed" icon.
- This patch also includes a "fix", for some reason this symbol is not
centering correctly within the span(or without for that matter), so
simply manually patch this by adding `bottom: 1.px`.

* Use svg

* Apply suggestion

Co-authored-by: silverwind <me@silverwind.io>

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-08-10 15:23:11 -04:00
wxiaoguang
3d76d6034e
Update docs for versions (#20750) 2022-08-10 13:37:15 -04:00
silverwind
802c5313e1
Replace some icons with SVG (#20741) 
- Replace some icons with SVG
- Create teams help page
- Application and SSH keys icons
- Add new icon for app token
- Use fontawesom-send
 2022-08-10 18:30:40 +02:00
silverwind
d751e35d81
Use separate class for tippy targets (#20742) 
Previous solution that re-purposed the 'hide' class by making it
`!important` had various unintended side-effects where jQuery .show() was
not able to outweight it. Use a separate class to prevent these
interactions.
 2022-08-10 22:47:28 +08:00
Gusted
58de07e5fd
Add support mCaptcha as captcha provider (#20458) 
https://mcaptcha.org/

Co-authored-by: Felipe Leopoldo Sologuren Gutiérrez <fsologureng@users.noreply.github.com>
 2022-08-10 15:20:10 +02:00
silverwind
452272c038
Fix CI status popup (#20737) 2022-08-10 12:08:06 +08:00
techknowlogick
1a538df5f4
Add documentation about pagination of the API (#20740) 
* Add documentation about pagination of the API

* Update docs/content/doc/developers/api-usage.en-us.md

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-08-09 21:58:55 -04:00
silverwind
77d7b4c63d [skip ci] Updated translations via Crowdin 2022-08-10 00:20:57 +00:00
silverwind
89505ac650
Change commit status icons to SVG (#20736) 
* Fix commit status popover and switch to svg icons

* margin tweak

* fix integration, use warning sign for error to match previous

* remove fix from here, will be a new pr

* use top/bottom positioning

* vertically center

* use no-entry over alert oction

* add exclamation icon

* fix test selector

* more test fixes
 2022-08-09 23:55:29 +02:00
KN4CK3R
7009eb9a24
Add support for NuGet API keys (#20721) 
* Add support for NuGet API key.

* lint

* Apply suggestions from code review

Co-authored-by: delvh <dev.lh@web.de>

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-08-09 17:36:49 +03:00
KN4CK3R
920481340b
Keep download count on Container tag overwrite (#20728) 
Co-authored-by: 6543 <6543@obermui.de>
 2022-08-09 16:47:57 +03:00