mirror of
https://github.com/git/git.git
synced 2024-05-10 11:56:09 +02:00
chunk-format: drop pair_chunk_unsafe()
There are no callers left, and we don't want anybody to add new ones (they should use the not-unsafe version instead). So let's drop the function. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
12192a9db9
commit
ca06f0fe5d
|
@ -184,14 +184,6 @@ int pair_chunk(struct chunkfile *cf,
|
||||||
return read_chunk(cf, chunk_id, pair_chunk_fn, &pcd);
|
return read_chunk(cf, chunk_id, pair_chunk_fn, &pcd);
|
||||||
}
|
}
|
||||||
|
|
||||||
int pair_chunk_unsafe(struct chunkfile *cf,
|
|
||||||
uint32_t chunk_id,
|
|
||||||
const unsigned char **p)
|
|
||||||
{
|
|
||||||
size_t dummy;
|
|
||||||
return pair_chunk(cf, chunk_id, p, &dummy);
|
|
||||||
}
|
|
||||||
|
|
||||||
int read_chunk(struct chunkfile *cf,
|
int read_chunk(struct chunkfile *cf,
|
||||||
uint32_t chunk_id,
|
uint32_t chunk_id,
|
||||||
chunk_read_fn fn,
|
chunk_read_fn fn,
|
||||||
|
|
|
@ -54,19 +54,6 @@ int pair_chunk(struct chunkfile *cf,
|
||||||
const unsigned char **p,
|
const unsigned char **p,
|
||||||
size_t *size);
|
size_t *size);
|
||||||
|
|
||||||
/*
|
|
||||||
* Unsafe version of pair_chunk; it does not return the size,
|
|
||||||
* meaning that the caller cannot possibly be careful about
|
|
||||||
* reading out of bounds from the mapped memory.
|
|
||||||
*
|
|
||||||
* No new callers should use this function, and old callers should
|
|
||||||
* be audited and migrated over to using the regular pair_chunk()
|
|
||||||
* function.
|
|
||||||
*/
|
|
||||||
int pair_chunk_unsafe(struct chunkfile *cf,
|
|
||||||
uint32_t chunk_id,
|
|
||||||
const unsigned char **p);
|
|
||||||
|
|
||||||
typedef int (*chunk_read_fn)(const unsigned char *chunk_start,
|
typedef int (*chunk_read_fn)(const unsigned char *chunk_start,
|
||||||
size_t chunk_size, void *data);
|
size_t chunk_size, void *data);
|
||||||
/*
|
/*
|
||||||
|
|
Loading…
Reference in New Issue