mirror/docker-letsencrypt-nginx-proxy-companion
1
0
Fork 0
mirror of https://github.com/nginx-proxy/docker-letsencrypt-nginx-proxy-companion synced 2024-11-22 20:42:04 +01:00
Code Issues Releases Activity

refactor: apply suggestions from code review

Browse Source
This commit is contained in:
Nicolas Duchon 2024-07-19 08:46:27 +02:00 committed by GitHub
parent e6f31f0d10
commit b048f4eeca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -24,7 +24,7 @@ It handles the automated creation, renewal and use of SSL certificates for proxi
* The (sub)domains you want to issue certificates for must correctly resolve to the host. * The (sub)domains you want to issue certificates for must correctly resolve to the host.
* If your (sub)domains have AAAA records set, the host must be publicly reachable over IPv6 on port `80` and `443`. * If your (sub)domains have AAAA records set, the host must be publicly reachable over IPv6 on port `80` and `443`.
If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](./docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information. If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](https://github.com/nginx-proxy/acme-companion/blob/main/docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information.
In addition to the above, please ensure that your DNS provider answers correctly to CAA record requests. [If your DNS provider answer with an error, Let's Encrypt won't issue a certificate for your domain](https://letsencrypt.org/docs/caa/). Let's Encrypt do not require that you set a CAA record on your domain, just that your DNS provider answers correctly. In addition to the above, please ensure that your DNS provider answers correctly to CAA record requests. [If your DNS provider answer with an error, Let's Encrypt won't issue a certificate for your domain](https://letsencrypt.org/docs/caa/). Let's Encrypt do not require that you set a CAA record on your domain, just that your DNS provider answers correctly.

2
app/start.sh
View File

@ -7,9 +7,7 @@ term_handler() {
# shellcheck source=functions.sh # shellcheck source=functions.sh
source /app/functions.sh source /app/functions.sh
if parse_true "${ACME_HTTP_CHALLENGE_LOCATION:=false}"; then
remove_all_location_configurations remove_all_location_configurations
fi
remove_all_standalone_configurations remove_all_standalone_configurations
exit 0 exit 0