From b048f4eeca35ba967baf0d1cdcc39d830fa782a9 Mon Sep 17 00:00:00 2001 From: Nicolas Duchon Date: Fri, 19 Jul 2024 08:46:27 +0200 Subject: [PATCH] refactor: apply suggestions from code review --- README.md | 2 +- app/start.sh | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index f5206a6..a28859b 100644 --- a/README.md +++ b/README.md @@ -24,7 +24,7 @@ It handles the automated creation, renewal and use of SSL certificates for proxi * The (sub)domains you want to issue certificates for must correctly resolve to the host. * If your (sub)domains have AAAA records set, the host must be publicly reachable over IPv6 on port `80` and `443`. -If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](./docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information. +If you can't meet these requirements, you can use the `DNS-01` challenge instead. Please refer to the [documentation](https://github.com/nginx-proxy/acme-companion/blob/main/docs/Let's-Encrypt-and-ACME.md#dns-01-acme-challenge) for more information. In addition to the above, please ensure that your DNS provider answers correctly to CAA record requests. [If your DNS provider answer with an error, Let's Encrypt won't issue a certificate for your domain](https://letsencrypt.org/docs/caa/). Let's Encrypt do not require that you set a CAA record on your domain, just that your DNS provider answers correctly. diff --git a/app/start.sh b/app/start.sh index 3ce8737..94db50f 100755 --- a/app/start.sh +++ b/app/start.sh @@ -7,9 +7,7 @@ term_handler() { # shellcheck source=functions.sh source /app/functions.sh - if parse_true "${ACME_HTTP_CHALLENGE_LOCATION:=false}"; then - remove_all_location_configurations - fi + remove_all_location_configurations remove_all_standalone_configurations exit 0