kreyren/pman
1
0
Fork 0
Code Issues 16 Pull Requests 2 Releases Activity

Quality Assurance, Audit and Tags #14

Merged
kreyren merged 11 commits from QAaudit into central 2022-09-03 10:35:10 +02:00
Conversation 13 Commits 11 Files Changed 33 +3407 -2467
kreyren commented 2022-08-28 12:38:19 +02:00
Owner
Copy Link

Fixes: #10

TODO

  • Process all files
    • src/make/main.scm
      • Docs
      • License
    • src/potato/builtins.scm
      • Figure out what to do with the commented out builtin-rules
    • src/potato/exceptions.scm
      • Docs
      • License
      • Add docstrings to all procedures
    • src/potato/make.scm
      • Docs
      • License
      • Identify WTF tags
      • Address FIXME tags
      • Figure out what to do with the commented out #:re-export codeblock
      • Indexed in #18
    • src/potato/makevars.scm
      • Docs
      • License
      • Indexed in #18
    • src/potato/parse-lib.scm
      • Docs
      • License
    • src/potato/parse.scm
      • Docs
      • SECURITY CHECK _eval
      • License
    • src/potato/parser.scm
      • Docs
      • License
    • src/potato/rules.scm
      • Docs
      • License
    • src/potato/text.scm
      • Docs
      • License
  • Add pointers to directories
    • docs/
    • make/
    • /potato
    • tests/
  • Decide what to do with tests
  • Replace MIT License with Expat for clearer legal definition as using "MIT License" is missleading bcs MIT uses more licenses
  • Add GPLv3 license to combat software patents
  • Rename /make on /pmake - Put all source files in /src to make it more manageable
Fixes: https://git.dotya.ml/kreyren/pman/issues/10 --- ### TODO * [X] Process all files * [X] `src/make/main.scm` * [X] Docs * [X] License * [x] `src/potato/builtins.scm` * [x] Figure out what to do with the commented out `builtin-rules` * [x] `src/potato/exceptions.scm` * [x] Docs * [x] License * [x] Add docstrings to all procedures * [x] `src/potato/make.scm` * [x] Docs * [x] License * [x] Identify WTF tags * [x] Address FIXME tags * [x] Figure out what to do with the commented out `#:re-export` codeblock * [X] Indexed in https://git.dotya.ml/kreyren/pman/issues/18 * [X] `src/potato/makevars.scm` * [x] Docs * [X] License * [X] Indexed in https://git.dotya.ml/kreyren/pman/issues/18 * [X] `src/potato/parse-lib.scm` * [X] Docs * [X] License * [X] `src/potato/parse.scm` * [X] Docs * [X] SECURITY CHECK `_eval` * [x] License * [X] `src/potato/parser.scm` * [X] Docs * [x] License * [X] `src/potato/rules.scm` * [X] Docs * [x] License * [X] `src/potato/text.scm` * [X] Docs * [x] License * [X] Add pointers to directories * [X] `docs/` * [X] `make/` * [X] `/potato` * [X] `tests/` * [X] Decide what to do with tests * [X] Replace MIT License with Expat for clearer legal definition as using "MIT License" is missleading bcs MIT uses more licenses * [X] Add GPLv3 license to combat software patents * [X] Rename `/make` on `/pmake` - Put all source files in `/src` to make it more manageable
kreyren added 1 commit 2022-08-28 12:38:20 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added 1 commit 2022-08-28 13:33:53 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added 1 commit 2022-08-28 13:34:55 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added spent time 2022-08-28 13:35:15 +02:00
4 hours
kreyren added this to the Minimal usability milestone 2022-08-28 13:35:28 +02:00
kreyren self-assigned this 2022-08-28 13:35:34 +02:00
kreyren added a new dependency 2022-08-28 18:45:32 +02:00
#15 WIP: Start process to relicense
kreyren added spent time 2022-08-28 20:00:58 +02:00
3 hours 27 minutes
kreyren added 1 commit 2022-08-28 20:02:19 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added 1 commit 2022-08-29 09:43:23 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added the
current-run
 label 2022-08-29 09:47:43 +02:00
kreyren added 1 commit 2022-08-29 17:55:08 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added spent time 2022-08-29 18:00:22 +02:00
2 hours 16 minutes
kreyren commented 2022-08-30 11:00:08 +02:00
Author
Owner
Copy Link

The builtin rules in potato/builtin.scm were removed as it's trying to implement an automatic build system which is outside of the scope of our usecase

The builtin rules in potato/builtin.scm were removed as it's trying to implement an automatic build system which is outside of the scope of our usecase
kreyren commented 2022-08-30 12:01:12 +02:00
Author
Owner
Copy Link

potato/make.scm: Had commented re-export codeblock which seems to be an old iteration of the current re-export with different naming for reference (vs ref) and added _ for compose.. No context to what compose is supposed to do so removed

potato/make.scm: Had commented `re-export` codeblock which seems to be an old iteration of the current `re-export` with different naming for `reference` (vs `ref`) and added `_` for `compose`.. No context to what `compose` is supposed to do so removed
kreyren added spent time 2022-08-30 12:38:21 +02:00
1 hour
kreyren started working 2022-08-30 12:38:23 +02:00
kreyren stopped working 2022-08-30 12:45:05 +02:00
6 minutes 42 seconds
kreyren added 1 commit 2022-08-30 12:46:45 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren added spent time 2022-08-30 16:26:38 +02:00
23 minutes
kreyren started working 2022-08-30 16:26:40 +02:00
kreyren added 1 commit 2022-08-30 16:53:32 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren stopped working 2022-08-30 16:53:42 +02:00
27 minutes 2 seconds
kreyren added a new dependency 2022-08-30 16:59:09 +02:00
#17 WIP: New README
kreyren started working 2022-08-31 18:57:58 +02:00
kreyren commented 2022-08-31 19:06:57 +02:00
Author
Owner
Copy Link

Stubbed unfinished code in potato/parse.scm

;; STUB(Krey): Unfinished code by original author, kept here in case we need to finish it in the future
#|
(define (parse-var-assignment line)
  (let ((i (string-next-token line 0)))
    (if (= i (string-length line))
	#f
	;; else
	(while #t
|#
Stubbed unfinished code in `potato/parse.scm` ```scm ;; STUB(Krey): Unfinished code by original author, kept here in case we need to finish it in the future #| (define (parse-var-assignment line) (let ((i (string-next-token line 0))) (if (= i (string-length line)) #f ;; else (while #t |# ```
kreyren added 1 commit 2022-08-31 19:56:10 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren stopped working 2022-08-31 19:56:11 +02:00
58 minutes 13 seconds
kreyren started working 2022-09-03 09:54:42 +02:00
kreyren added 1 commit 2022-09-03 10:10:20 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren commented 2022-09-03 10:12:53 +02:00
Author
Owner
Copy Link

The project is over-complicated which interfieres with our usecase -> Simplify and optimize the source-code

The project is over-complicated which interfieres with our usecase -> Simplify and optimize the source-code
kreyren commented 2022-09-03 10:19:11 +02:00
Author
Owner
Copy Link

Decided that the QA for tests will be excluded now as the rewrite of the project will require a new tests

Decided that the QA for tests will be excluded now as the rewrite of the project will require a new tests
kreyren commented 2022-09-03 10:21:19 +02:00
Author
Owner
Copy Link

The _eval in potato/parse.scm was checked, doesn't seem like anything security-concerning, but added a FIXME-QA tag for (while #t handling

The `_eval` in `potato/parse.scm` was checked, doesn't seem like anything security-concerning, but added a FIXME-QA tag for `(while #t` handling
kreyren commented 2022-09-03 10:22:12 +02:00
Author
Owner
Copy Link

Peer-review postponed until the refactor is finalized to avoid reviewing of code that we won't be using and thus wasting resources

Peer-review postponed until the refactor is finalized to avoid reviewing of code that we won't be using and thus wasting resources
kreyren added 1 commit 2022-09-03 10:22:34 +02:00 
Signed-off-by: Jacob Hrbek <kreyren@rixotstudio.cz>
kreyren commented 2022-09-03 10:32:19 +02:00
Author
Owner
Copy Link

I've made too many changes that I can't use the gitea's review thing in https://git.dotya.ml/kreyren/pman/pulls/14/files

Thus unable to flag as self-reviewed

CC @wanderer

I've made too many changes that I can't use the gitea's review thing in https://git.dotya.ml/kreyren/pman/pulls/14/files Thus unable to flag as self-reviewed CC @wanderer
kreyren stopped working 2022-09-03 10:32:46 +02:00
38 minutes 4 seconds
kreyren added spent time 2022-09-03 10:32:58 +02:00
5 hours 27 minutes
kreyren commented 2022-09-03 10:33:31 +02:00
Author
Owner
Copy Link

5h 27m research and abstracting

5h 27m research and abstracting
kreyren changed title from WIP: Quality Assurance and audit to Quality Assurance, Audit and Tags 2022-09-03 10:33:51 +02:00
kreyren merged commit 70e83193cb into central 2022-09-03 10:35:10 +02:00
kreyren deleted branch QAaudit 2022-09-03 10:35:10 +02:00
kreyren removed the
current-run
 label 2022-09-03 10:35:27 +02:00
wanderer reviewed 2022-09-03 14:35:20 +02:00
wanderer left a comment
First-time contributor
Copy Link

since I have no idea what this is supposed to do I can only say I viewed it.
I wonder, though, why I was requested for review, considering my Scheme skills :D

since I have no idea what this is supposed to do I can only say I viewed it. I wonder, though, why I was requested for review, considering my Scheme skills :D
kreyren commented 2022-09-05 13:11:17 +02:00
Author
Owner
Copy Link

since I have no idea what this is supposed to do I can only say I viewed it.
I wonder, though, why I was requested for review, considering my Scheme skills :D -- @wanderer (#14 (comment))

I didn't ask you for review and you just pinged like 400 people with that 🤦

I told you that I can't open the https://git.dotya.ml/kreyren/pman/pulls/14/files bcs it just loads infinitely and eats up all system resources so i assume that there is an issue on the server

> since I have no idea what this is supposed to do I can only say I viewed it. > I wonder, though, why I was requested for review, considering my Scheme skills :D -- @wanderer (https://git.dotya.ml/kreyren/pman/pulls/14#issuecomment-2469) I didn't ask you for review and you just pinged like 400 people with that 🤦 I told you that I can't open the https://git.dotya.ml/kreyren/pman/pulls/14/files bcs it just loads infinitely and eats up all system resources so i assume that there is an issue on the server
wanderer commented 2022-09-05 14:08:00 +02:00
First-time contributor
Copy Link

I didn't ask you for review and you just pinged like 400 people with that 🤦

apologies, but it wasn't clear to me what you were pinging me about.

I told you that I can't open the https://git.dotya.ml/kreyren/pman/pulls/14/files bcs it just loads infinitely and eats up all system resources so i assume that there is an issue on the server

now that we know the actual issue, also disregarding the fact that I went through the files and marked them as viewed, it works for me:
image

granted, it takes 3 seconds to load at first.

> I didn't ask you for review and you just pinged like 400 people with that 🤦 apologies, but it wasn't clear to me what you were pinging me about. > I told you that I can't open the https://git.dotya.ml/kreyren/pman/pulls/14/files bcs it just loads infinitely and eats up all system resources so i assume that there is an issue on the server now that we know the actual issue, also disregarding the fact that I went through the files and marked them as viewed, it works for me: ![image](/attachments/91e8850f-f6a7-4a39-bdcb-5ed2ca9a644e) granted, it takes 3 seconds to load at first.
image.png
214 KiB
kreyren commented 2022-09-17 05:15:50 +02:00
Author
Owner
Copy Link

@wanderer For me it's click to halt the system

For some reason i can't submit issues to gitea, can you file it?

@wanderer For me it's click to halt the system For some reason i can't submit issues to gitea, can you file it?
wanderer commented 2022-09-17 12:36:26 +02:00
First-time contributor
Copy Link

@wanderer For me it's click to halt the system

how can I reproduce it? sure, it takes a while to load diffs of bigger PRs, but I believe it's mainly constrained by the specific setup (i.e. sqlite on spinning rust would hurt) and the hardware used to run Gitea, not Gitea itself.

For some reason i can't submit issues to gitea

wdym, why is this?

> @wanderer For me it's click to halt the system how can I reproduce it? sure, it takes a while to load diffs of bigger PRs, but I believe it's mainly constrained by the specific setup (i.e. sqlite on spinning rust would hurt) and the hardware used to run Gitea, not Gitea itself. > For some reason i can't submit issues to gitea wdym, why is this?
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
administration

Management of the project

  
current-run

Issues that are being focused now

No Label
administration
current-run
Milestone
Clear milestone
No items
No Milestone
Minimal usability
Assignees
Clear assignees
No Assignees
kreyren
2 Participants
Notifications
Total Time Spent: 18 hours 43 minutes
kreyren
18 hours 43 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#17 WIP: New README
kreyren/pman
Depends on
#15 WIP: Start process to relicense
kreyren/pman
Reference: kreyren/pman#14
No description provided.
Delete Branch "QAaudit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?