RiXotStudio/grilumops
1
0
Fork 0
Code Issues Pull Requests Releases Activity

src/default.scm: add missing logic in system-hostname-check #2

Merged
kreyren merged 2 commits from :molese-patch into ALPHA 2021-11-30 08:03:59 +01:00
Conversation 2 Commits 2 Files Changed 1 +3 -2
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/default.scm
View File

@ -7,10 +7,11 @@
;; FIXME(Krey): Process DOMAIN ;; FIXME(Krey): Process DOMAIN
;; function to print error if environment variable 'HOSTNAME' is not set or if it's value is empty ;; function to throw error if environment variable 'HOSTNAME' is not set
; or if it's value is empty
kreyren commented 2021-11-30 07:37:51 +01:00
Review
Copy Link

don't split things across multiple lines

don't split things across multiple lines
;; FIXME-QA(Molese): Needs test ;; FIXME-QA(Molese): Needs test
(define system-hostname-check (lambda () (define system-hostname-check (lambda ()
(if (not (system-hostname-set?)) (if (eq nil (getenv "HOSTNAME"))
kreyren commented 2021-11-30 07:38:14 +01:00
Review
Copy Link

(if (empty? (getenv "HOSTNAME"... ?

(if (empty? (getenv "HOSTNAME"... ?
(throw 1 "Environment variable 'HOSTNAME' is not set, unable to apply sufficient configuration")) (throw 1 "Environment variable 'HOSTNAME' is not set, unable to apply sufficient configuration"))
(if (eq? (getenv "HOSTNAME") #f) (if (eq? (getenv "HOSTNAME") #f)
(throw 1 "Environment variable 'HOSTNAME' is empty, unable to apply sufficient configuration")))) (throw 1 "Environment variable 'HOSTNAME' is empty, unable to apply sufficient configuration"))))