RiXotStudio/grilumops
1
0
Fork 0
Code Issues Pull Requests Releases Activity

src/default.scm: add missing logic in system-hostname-check #2

Merged
kreyren merged 2 commits from :molese-patch into ALPHA 2021-11-30 08:03:59 +01:00
Conversation 2 Commits 2 Files Changed 1 +3 -2
Ghost commented 2021-11-30 07:34:47 +01:00
First-time contributor
Copy Link

Signed-off-by: molese molese@protonmail.com

Signed-off-by: molese <molese@protonmail.com>
Ghost added 1 commit 2021-11-30 07:34:48 +01:00 
Signed-off-by: molese <molese@protonmail.com>
Ghost changed title from src/default.scm: add missing logic in system-hostname-check to [WIP] src/default.scm: add missing logic in system-hostname-check 2021-11-30 07:36:01 +01:00
Ghost added 1 commit 2021-11-30 07:37:45 +01:00 
Signed-off-by: molese <molese@protonmail.com>
Ghost requested review from kreyren 2021-11-30 07:37:52 +01:00
Ghost changed title from [WIP] src/default.scm: add missing logic in system-hostname-check to src/default.scm: add missing logic in system-hostname-check 2021-11-30 07:38:04 +01:00
kreyren changed title from src/default.scm: add missing logic in system-hostname-check to WIP: src/default.scm: add missing logic in system-hostname-check 2021-11-30 07:38:39 +01:00
Ghost commented 2021-11-30 07:42:15 +01:00
Author
First-time contributor
Copy Link

@kreyren: It requires a separate file that has the necessary technique for determining if an environment variable is present or not before proceeding directly to the main procedure.

@kreyren: It requires a separate file that has the necessary technique for determining if an environment variable is present or not before proceeding directly to the main procedure.
Ghost changed title from WIP: src/default.scm: add missing logic in system-hostname-check to src/default.scm: add missing logic in system-hostname-check 2021-11-30 07:42:50 +01:00
kreyren commented 2021-11-30 07:48:33 +01:00
Owner
Copy Link

@kreyren: It requires a separate file that has the necessary technique for determining if an environment variable is present or not before proceeding directly to the main procedure.

Do whatever you think is the optimal solution i rewrite it after you if needed

> @kreyren: It requires a separate file that has the necessary technique for determining if an environment variable is present or not before proceeding directly to the main procedure. Do whatever you think is the optimal solution i rewrite it after you if needed
kreyren approved these changes 2021-11-30 08:03:46 +01:00
src/default.scm
@ -9,2 +9,3 @@
;; function to print error if environment variable 'HOSTNAME' is not set or if it's value is empty
;; function to throw error if environment variable 'HOSTNAME' is not set
; or if it's value is empty
kreyren commented 2021-11-30 07:37:51 +01:00
Owner
Copy Link

don't split things across multiple lines

don't split things across multiple lines
src/default.scm
@ -11,3 +12,3 @@
;; FIXME-QA(Molese): Needs test
(define system-hostname-check (lambda ()
(if (not (system-hostname-set?))
(if (eq nil (getenv "HOSTNAME"))
kreyren commented 2021-11-30 07:38:14 +01:00
Owner
Copy Link

(if (empty? (getenv "HOSTNAME"... ?

(if (empty? (getenv "HOSTNAME"... ?
kreyren merged commit 3e2f6b186b into ALPHA 2021-11-30 08:03:59 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
kreyren
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: RiXotStudio/grilumops#2
No description provided.
Delete Branch ":molese-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?