wanderer/go-xkcdreader
1
1
Fork 0
Code Issues 5 Pull Requests Releases Activity

unify coverage levels for different go versions #2

New Issue
Open
opened 2022-05-20 10:52:17 +02:00 by wanderer · 0 comments
wanderer commented 2022-05-20 10:52:17 +02:00
Owner
Copy Link

there is a rework[1] on the way that changes how go test -cover results are produced.
it can already be observed in CI:

to transcribe what the images show:

  • go test -cover on archlinux/go1.18.2 yields: 
    go test -cover ./...
... lines ...
ok  	git.dotya.ml/wanderer/go-xkcdreader	0.038s	coverage: 0.0% of statements
ok  	git.dotya.ml/wanderer/go-xkcdreader/cmd	0.167s	coverage: 50.0% of statements
ok  	git.dotya.ml/wanderer/go-xkcdreader/xkcdreader	0.095s	coverage: 20.0% of statements
  • go test -cover on fedora36/go1.18 yields: 
    go test -cover ./...
ok  	git.dotya.ml/wanderer/go-xkcdreader	0.014s	coverage: 100.0% of statements
ok  	git.dotya.ml/wanderer/go-xkcdreader/cmd	0.025s	coverage: 50.0% of statements
ok  	git.dotya.ml/wanderer/go-xkcdreader/xkcdreader	0.048s	coverage: 20.0% of statements

the difference can probably be attributed to the changes already present in go1.18.2.

after applying a patch (also reffed here), the example test coverage appeared to have improved dramatically.

ref [1]: https://github.com/golang/go/issues/51430

there is a rework[1] on the way that changes how `go test -cover` results are produced. it can already be observed in CI: * [archlinux/go1.18.2](https://drone.dotya.ml/wanderer/go-xkcdreader/231/2/5) ![image](/attachments/d3e76a26-22de-4aed-a4ef-c9ff299296c8) * [fedora36/go1.18](https://drone.dotya.ml/wanderer/go-xkcdreader/231/3/5) ![image](/attachments/5c75941c-f2ca-4d29-a594-c8454a0f1c15) to transcribe what the images show: * `go test -cover` on archlinux/go1.18.2 yields: ``` go test -cover ./... ... lines ... ok git.dotya.ml/wanderer/go-xkcdreader 0.038s coverage: 0.0% of statements ok git.dotya.ml/wanderer/go-xkcdreader/cmd 0.167s coverage: 50.0% of statements ok git.dotya.ml/wanderer/go-xkcdreader/xkcdreader 0.095s coverage: 20.0% of statements ``` * `go test -cover` on fedora36/go1.18 yields: ``` go test -cover ./... ok git.dotya.ml/wanderer/go-xkcdreader 0.014s coverage: 100.0% of statements ok git.dotya.ml/wanderer/go-xkcdreader/cmd 0.025s coverage: 50.0% of statements ok git.dotya.ml/wanderer/go-xkcdreader/xkcdreader 0.048s coverage: 20.0% of statements ``` the difference can probably be attributed to the changes already present in go1.18.2. after applying [a patch](https://go-review.googlesource.com/c/go/+/404299/) (also reffed [here](https://github.com/golang/go/issues/51430#issuecomment-1119843774)), the example *test* coverage appeared to have improved dramatically. ref [1]: https://github.com/golang/go/issues/51430
image.png
344 KiB
image.png
345 KiB
wanderer added the
bug
 label 2022-05-20 10:52:17 +02:00
wanderer added the
breakage/upstream
 label 2022-05-20 12:10:41 +02:00
wanderer added the
pertains/ci
 label 2022-05-25 20:03:58 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
breakage/local

Local breaking change

  
breakage/upstream

Breaking change upstream

  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
pertains/ci

Related to CI

  
pertains/go

Something to do w/ Go

  
pertains/nix

Something to do w/ Nix ❄

  
pertains/pre-commit

Something to do with pre-commit ✅

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
breakage/local
breakage/upstream
bug
duplicate
enhancement
help wanted
invalid
pertains/ci
pertains/go
pertains/nix
pertains/pre-commit
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Reference: wanderer/go-xkcdreader#2
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?