Validate migration files

[realaravinth]

On behalf of @dachary from the forgefriends project:

JSON Schema validation for data used by Gitea during migrations
Discussion at https://forum.forgefriends.org/t/common-json-schema-for-repository-information/563

---

source

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@8c647bf). Click here to learn what that means.
The diff coverage is 65.62%.

@@           Coverage Diff           @@
##             main   #18203   +/-   ##
=======================================
  Coverage        ?   45.66%           
=======================================
  Files           ?      832           
  Lines           ?    92097           
  Branches        ?        0           
=======================================
  Hits            ?    42052           
  Misses          ?    43299           
  Partials        ?     6746           

Impacted Files	Coverage Δ
cmd/restore_repo.go	0.00% <0.00%> (ø)
modules/migration/issue.go	100.00% <ø> (ø)
modules/private/restore_repo.go	0.00% <0.00%> (ø)
routers/private/restore_repo.go	0.00% <0.00%> (ø)
modules/migration/file_format.go	71.42% <71.42%> (ø)
modules/migration/schemas_dynamic.go	81.81% <81.81%> (ø)
services/migrations/dump.go	30.54% <100.00%> (ø)
services/migrations/restore.go	33.54% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c647bf...4718117. Read the comment docs.

[lunny]

I think it's unnecessary to increment the binary size for a test purpose.

[realaravinth]

I think it's unnecessary to increment the binary size for a test purpose.

The bindata keyword that was added to .drone.yml and Makefile was removed. Thanks for the quick review :-)

---

source

[realaravinth]

The PR was updated to remove the conflicting changes in the vendor directory.

---

source

[6543]

CI fail related:

+ make lint-backend
golangci-lint run --timeout 10m
services/migrations/dump.go:155:3: not enough arguments in call to git.Clone (typecheck)
	})
	 ^
services/migrations/dump.go:162:56: not enough arguments in call to repository.WikiRemoteURL (typecheck)
		wikiRemotePath := repository.WikiRemoteURL(remoteAddr)
		                                                     ^
services/migrations/dump.go:173:5: not enough arguments in call to git.Clone (typecheck)
			}); err != nil {
			 ^
make: *** [Makefile:754: golangci-lint] Error 1

[realaravinth]

@Gusted thanks for your review. I addressed your comments, hopefully to your satisfaction

---

source

[realaravinth]

@6543 thanks for highlighting the CI failure. The PR was rebased against today's main branch to resolve them.

---

source

[Gusted]

Only a small nit, otherwise it looks good to me.

[Gusted]

LGTM!

[6543]

please dont force-push I cant easily check what was changed

[6543]

force push after 2 lgtms - need 👀

[realaravinth]

@6543: Apologies, we'll avoid force pushing next time

[6543]

well we squash-merge so its better to not force-push to see the progress