Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for v1.15.0-rc1 #16422

Merged
merged 20 commits into from Jul 15, 2021
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 14, 2021

as title

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 14, 2021
@6543 6543 added this to the 1.15.0 milestone Jul 14, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter

This comment has been minimized.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, also each line should start with a capital letter unless it otherwise makes sense.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@6543 6543 requested a review from techknowlogick July 14, 2021 09:52
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@fnetX
Copy link
Contributor

fnetX commented Jul 15, 2021

Just a side note: What about including a quick Heads Up section what people would need to "adjust" in order to install / maintain / use the software. IMHO the "BREAKING" section is rather targeted on people who follow the development of Gitea and acts as a reminder what has been changed in this release / RC.
But for normal users, I suppose this isn't really an understandable thing. Just one example, Codeberg might not have been the only installation to place the robots.txt into the public folder to get it served (instead of the CustomPath as told in the docs), and some admin might not catch to move the robots.txt file. I know this is implicitly mentioned when serving assets from another folder, but still, I think reading your changelog doesn't always make it obvious how the change will affect you (as user, admin, ...).

Thank you for considering this.

CHANGELOG.md Outdated Show resolved Hide resolved
6543 and others added 2 commits July 15, 2021 12:54
Co-authored-by: Norwin <noerw@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Lauris BH <lauris@nix.lv>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2021
@techknowlogick techknowlogick merged commit 195c999 into go-gitea:main Jul 15, 2021
@zeripath
Copy link
Contributor

Just a side note: What about including a quick Heads Up section what people would need to "adjust" in order to install / maintain / use the software. IMHO the "BREAKING" section is rather targeted on people who follow the development of Gitea and acts as a reminder what has been changed in this release / RC.

We put a BREAKING section in our blog posts:

https://blog.gitea.io/2021/04/gitea-1.14.0-is-released/#breaking-changes-or-potentially-breaking

I'm trying to update and make it easier to explain why a PR is breaking by changing their initial comments e.g.:

#16010 (comment)

So that when it comes to writing the blog post we can copy and paste that information into the blog.

Some of the breaking changes - and I guess you're specifically referencing #15219 here - the breaking nature only becomes apparent through testing and through people trying things.

If you find a PR is breaking - it would be helpful if you could help improve this process by explaining clearly in a comment on the PR how it is breaking so we can update and improve this.

For example - this is the first time I've heard of the robots.txt problem.

@6543 6543 deleted the changelog_v1.15.0-rc1 branch July 15, 2021 16:14
@fnetX
Copy link
Contributor

fnetX commented Jul 16, 2021

@zeripath thank you for your explanation. I wasn't aware of the blog posts containing more information. I can try to assist in writing these comments if I come along them, otherwise I'll just suggest to keep in mind every information available to end users is helpful to avoid being caught by breaking things you (speaking of end users) didn't fully understand as I don't always find it obvious to get what it's about. Nice to see this is already happening, so take this as a friendly reminder to continue the work 😉

The blog posts + explanations in the PRs are already much more helpful than the changelog in Git, don't know why I missed this ... ✌️

@6543
Copy link
Member Author

6543 commented Jul 17, 2021

@fnetX they are managed in a different repo: https://gitea.com/gitea/blog

@zeripath
Copy link
Contributor

The addition of the

## ⚠️ BREAKING ⚠️ 

marker in pr in the first comment is an innovation I've come up with this cycle - hopefully it's useful and others will start doing it of their own volition.

For any pr I merge or write I try to make the first comment make some sort of sense. I've tried to suggest this to other maintainers/mergers and similarly I'm hoping this will rub off on other mergers & maintainers too.

In terms of making this CHANGELOG.md file more useful - I think it needs to remain quite succinct and as updating it can be difficult I wouldn't want to have more information in it. However I take your point that the blog post can be hard to find. Maybe we need to update the readme to suggest to reading the blog?

BTW are you aware we use a tool to generate the changelog? IIRC it's possible to use that tool to emit the first comment from the PRs too so I guess we could include the instructions on how to do that in the readme?

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
* changelog -m 1.15.0 generate

* enhance changelog

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: techknowlogick <matti@mdranta.net>

* move SECURITY before FEATURES

* move ENHANCEMENTS above BUGFIXES

* as per techknowlogick

* more

* node16

* Apply suggestions from code review

Co-authored-by: Kyle D. <kdumontnu@gmail.com>

* next

* Apply suggestions from code review

* Update CHANGELOG.md

Co-authored-by: Norwin <noerw@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: techknowlogick <matti@mdranta.net>
Co-authored-by: Kyle D. <kdumontnu@gmail.com>
Co-authored-by: Norwin <noerw@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants