59 Commits

Author	SHA1	Message	Date
JakobDev	c548dde205	More refactoring of `db.DefaultContext` (#27083) ... Next step of #27065	2023-09-15 06:13:19 +00:00
JakobDev	76659b1114	Reduce usage of `db.DefaultContext` (#27073) ... Part of #27065 This reduces the usage of `db.DefaultContext`. I think I've got enough files for the first PR. When this is merged, I will continue working on this. Considering how many files this PR affect, I hope it won't take to long to merge, so I don't end up in the merge conflict hell. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-14 17:09:32 +00:00
CaiCandong	a78c2eae24	Replace `util.SliceXxx` with `slices.Xxx` (#26958)	2023-09-07 09:37:47 +00:00
Lunny Xiao	b9df9fa2e2	Move createrepository from module to service layer (#26927) ... Repository creation depends on many models, so moving it to service layer is better.	2023-09-06 12:08:51 +00:00
merlleu	a7d9a70552	allow "latest" to be used in release vTag when downloading file (#26748) ... Hello, In the discord I saw [someone](https://discord.com/channels/322538954119184384/1069795723178160168/1145061200644800514) complaining that you can't use the "latest" keyword as release tag to download a specific file: In his example: https://www.uberwald.me/gitea/public/fvtt-ecryme/releases/latest/system.json However the latest keyword works for the release page, so I think it's a good thing to implement this on the release attachment download url too. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-09-06 11:06:04 +00:00
yp05327	f6e7798405	Add link to job details and tooltip to commit status in repo list in dashboard (#26326) ... Tooltip:  Link to the target job: 	2023-08-21 15:26:10 +08:00
HesterG	2f0e79e639	Use frontend fetch for branch dropdown component (#25719) ... - Send request to get branch/tag list, use loading icon when waiting for response. - Only fetch when the first time branch/tag list shows. - For backend, removed assignment to `ctx.Data["Branches"]` and `ctx.Data["Tags"]` from `context/repo.go` and passed these data wherever needed. - Changed some `v-if` to `v-show` and used native `svg` as mentioned in https://github.com/go-gitea/gitea/pull/25719#issuecomment-1631712757 to improve perfomance when there are a lot of branches. - Places Used the dropdown component: Repo Home Page <img width="1429" alt="Screen Shot 2023-07-06 at 12 17 51" src="https://github.com/go-gitea/gitea/assets/17645053/6accc7b6-8d37-4e88-ae1a-bd2b3b927ea0"> Commits Page <img width="1431" alt="Screen Shot 2023-07-06 at 12 18 34" src="https://github.com/go-gitea/gitea/assets/17645053/2d0bf306-d1e2-45a8-a784-bc424879f537"> Specific commit -> operations -> cherry-pick <img width="758" alt="Screen Shot 2023-07-06 at 12 23 28" src="https://github.com/go-gitea/gitea/assets/17645053/1e557948-3881-4e45-a625-8ef36d45ae2d"> Release Page <img width="1433" alt="Screen Shot 2023-07-06 at 12 25 05" src="https://github.com/go-gitea/gitea/assets/17645053/3ec82af1-15a4-4162-a50b-04a9502161bb"> - Demo https://github.com/go-gitea/gitea/assets/17645053/d45d266b-3eb0-465a-82f9-57f78dc5f9f3 - Note: UI of dropdown menu could be improved in another PR as it should apply to more dropdown menus. Fix #14180 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-21 11:20:04 +00:00
Lunny Xiao	037c9895a7	Support copy protected branch from template repository (#25889) ... Fix #14303	2023-07-21 12:32:47 +08:00
silverwind	88f835192d	Replace `interface{}` with `any` (#25686) ... Result of running `perl -p -i -e 's#interface\{\}#any#g' **/*` and `make fmt`. Basically the same [as golang did](2580d0e08d).	2023-07-04 18:36:08 +00:00
Lunny Xiao	807c9712ef	Get latest commit statuses from database instead of git data on dashboard for repositories (#25605) ... related #24638	2023-07-03 01:53:05 +00:00
Lunny Xiao	d6dd6d641b	Fix all possible setting error related storages and added some tests (#23911) ... Follow up #22405 Fix #20703 This PR rewrites storage configuration read sequences with some breaks and tests. It becomes more strict than before and also fixed some inherit problems. - Move storage's MinioConfig struct into setting, so after the configuration loading, the values will be stored into the struct but not still on some section. - All storages configurations should be stored on one section, configuration items cannot be overrided by multiple sections. The prioioty of configuration is `[attachment]` > `[storage.attachments]` | `[storage.customized]` > `[storage]` > `default` - For extra override configuration items, currently are `SERVE_DIRECT`, `MINIO_BASE_PATH`, `MINIO_BUCKET`, which could be configured in another section. The prioioty of the override configuration is `[attachment]` > `[storage.attachments]` > `default`. - Add more tests for storages configurations. - Update the storage documentations. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-14 11:42:38 +08:00
wxiaoguang	3af2c8e4ab	Remove the parallelizing when loading repo for dashboard (#24705) ... Ref: #24638 IMO, parallelizing might run out server resources more quickly. Gitea shouldn't use a lot of go-routine in a web handler. And add a comment about how many repositories there could be at most. Co-authored-by: Yarden Shoham <git@yardenshoham.com>	2023-05-14 21:45:47 +08:00
Yarden Shoham	4810fe55e3	Add status indicator on main home screen for each repo (#24638) ... It will show the calculated commit status state of the latest commit on the default branch for each repository in the dashboard repo list - Closes #15620 # Before  # After  --------- Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-05-13 21:59:01 +00:00
wxiaoguang	cb700aedd1	Split "modules/context.go" to separate files (#24569) ... The "modules/context.go" is too large to maintain. This PR splits it to separate files, eg: context_request.go, context_response.go, context_serve.go This PR will help: 1. The future refactoring for Gitea's web context (eg: simplify the context) 2. Introduce proper "range request" support 3. Introduce context function This PR only moves code, doesn't change any logic.	2023-05-08 17:36:54 +08:00
wxiaoguang	92fd3fc4fd	Refactor "route" related code, fix Safari cookie bug (#24330) ... Fix #24176 Clean some misuses of route package, clean some legacy FIXMEs --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-04-27 02:06:45 -04:00
JakobDev	42919ccb7c	Make Release Download URLs predictable (#23891) ... As promised in #23817, I have this made a PR to make Release Download URLs predictable. It currently follows the schema `<repo>/releases/download/<tag>/<filename>`. this already works, but it is nowhere shown in the UI or the API. The Problem is, that it is currently possible to have multiple files with the same name (why do we even allow this) for a release. I had written some Code to check, if a Release has 2 or more files with the same Name. If yes, it uses the old `attachments/<uuid>` URlL if no it uses the new fancy URL. I had also changed `<repo>/releases/download/<tag>/<filename>` to directly serve the File instead of redirecting, so people who who use automatic update checker don't end up with the `attachments/<uuid>` URL. Fixes #10919 --------- Co-authored-by: a1012112796 <1012112796@qq.com>	2023-04-12 17:05:23 +08:00
wxiaoguang	4e33481357	Make label templates have consistent behavior and priority (#23749) ... Fix https://github.com/go-gitea/gitea/issues/23715 Other related PRs: * #23717 * #23716 * #23719 This PR is different from others, it tries to resolve the problem fundamentally (and brings more benefits) Although it looks like some more lines are added, actually many new lines are for tests. ---- Before, the code was just "guessing" the file type and try to parse them. <details>  </details> This PR: * Always remember the original option file names, and always use correct parser for them. * Another benefit is that we can sort the Label Templates now (before there was a map, its key order is undefined) 	2023-04-10 16:44:02 +08:00
Jason Song	04347eb810	Use context parameter in services/repository (#23186) ... Use context parameter in `services/repository`. And use `cache.WithCacheContext(ctx)` to generate push action history feeds. Fix #23160	2023-02-28 16:17:51 -06:00
wxiaoguang	e9288c2477	Fix improper HTMLURL usages in Go code (#22839) ... In Go code, HTMLURL should be only used for external systems, like API/webhook/mail/notification, etc. If a URL is used by `Redirect` or rendered in a template, it should be a relative URL (aka `Link()` in Gitea) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-02-11 14:34:11 +08:00
Lunny Xiao	769be877f2	Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) ... partially fix #19345 This PR add some `Link` methods for different objects. The `Link` methods are not different from `HTMLURL`, they are lack of the absolute URL. And most of UI `HTMLURL` have been replaced to `Link` so that users can visit them from a different domain or IP. This PR also introduces a new javascript configuration `window.config.reqAppUrl` which is different from `appUrl` which is still an absolute url but the domain has been replaced to the current requested domain.	2023-02-06 12:09:18 -06:00
KN4CK3R	a35749893b	Move `convert` package to services (#22264) ... Addition to #22256 The `convert` package relies heavily on different models which is [disallowed by our definition of modules](https://github.com/go-gitea/gitea/blob/main/CONTRIBUTING.md#design-guideline). This helps to prevent possible import cycles. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-12-29 10:57:15 +08:00
Lunny Xiao	68704532c2	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00
Lunny Xiao	0a7d3ff786	refactor some functions to support ctx as first parameter (#21878) ... Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: Lauris BH <lauris@nix.lv>	2022-12-03 10:48:26 +08:00
flynnnnnnnnnn	e81ccc406b	Implement FSFE REUSE for golang files (#21840) ... Change all license headers to comply with REUSE specification. Fix #16132 Co-authored-by: flynnnnnnnnnn <flynnnnnnnnnn@github> Co-authored-by: John Olheiser <john.olheiser@gmail.com>	2022-11-27 18:20:29 +00:00
KN4CK3R	fc7a2d5a95	Add support for HEAD requests in Maven registry (#21834) ... Related #18543 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-11-24 16:25:13 +02:00
KN4CK3R	044c754ea5	Add `context.Context` to more methods (#21546) ... This PR adds a context parameter to a bunch of methods. Some helper `xxxCtx()` methods got replaced with the normal name now. Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-11-19 16:12:33 +08:00
delvh	0ebb45cfe7	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551) ... Found using `find . -type f -name '*.go' -print -exec vim {} -c ':%s/fmt\.Errorf(\(.*\)%v\(.*\)err/fmt.Errorf(\1%w\2err/g' -c ':wq' \;` Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-10-24 20:29:17 +01:00
Peter Gardfjäll	4562d40fce	fix hard-coded timeout and error panic in API archive download endpoint (#20925) ... * fix hard-coded timeout and error panic in API archive download endpoint This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>	2022-08-29 11:45:20 +02:00
KN4CK3R	dc0253b063	Replace `ServeStream` with `ServeContent` (#20903) ... * Replace ServeStream with ServeContent. * Update modules/timeutil/timestamp.go Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2022-08-25 12:05:21 -04:00
Lunny Xiao	1d8543e7db	Move some files into models' sub packages (#20262) ... * Move some files into models' sub packages * Move functions * merge main branch * Fix check * fix check * Fix some tests * Fix lint * Fix lint * Revert lint changes * Fix error comments * Fix lint Co-authored-by: 6543 <6543@obermui.de>	2022-08-25 10:31:57 +08:00
Lunny Xiao	26095115f4	Move some repository related code into sub package (#19711) ... * Move some repository related code into sub package * Move more repository functions out of models * Fix lint * Some performance optimization for webhooks and others * some refactors * Fix lint * Fix * Update modules/repository/delete.go Co-authored-by: delvh <dev.lh@web.de> * Fix test * Merge * Fix test * Fix test * Fix test * Fix test Co-authored-by: delvh <dev.lh@web.de>	2022-06-06 16:01:49 +08:00
Lunny Xiao	fd7d83ace6	Move almost all functions' parameter db.Engine to context.Context (#19748) ... * Move almost all functions' parameter db.Engine to context.Context * remove some unnecessary wrap functions	2022-05-20 22:08:52 +08:00
Gusted	076eaad743	Improve dashboard's repo list performance (#18963) ... * Improve dashboard's repo list performance - Avoid a lot of database lookups for all the repo's, by adding a undocumented "minimal" mode for this specific task, which returns the data that's only needed by this list which doesn't require any database lookups. - Makes fetching these list faster. - Less CPU overhead when a user visits home page. * Refactor javascript code + fix Fork icon - Use async in the function so we can use `await`. - Remove `archivedFilter` check for count, as it doesn't make sense to show the count of repos when you can't even see them(as they are filited away). * Add `count_only` * Remove uncessary code * Improve comment Co-authored-by: delvh <dev.lh@web.de> * Update web_src/js/components/DashboardRepoList.js Co-authored-by: delvh <dev.lh@web.de> * Update web_src/js/components/DashboardRepoList.js Co-authored-by: delvh <dev.lh@web.de> * By default apply minimal mode * Remove `minimal` paramater * Refactor count header * Simplify init Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: zeripath <art27@cantab.net>	2022-04-26 16:34:30 -04:00
Lunny Xiao	783a021889	Never use /api/v1 from Gitea UI Pages (#19318) ... Reusing `/api/v1` from Gitea UI Pages have pros and cons. Pros: 1) Less code copy Cons: 1) API/v1 have to support shared session with page requests. 2) You need to consider for each other when you want to change something about api/v1 or page. This PR moves all dependencies to API/v1 from UI Pages. Partially replace #16052	2022-04-07 20:59:56 +02:00
Lunny Xiao	76aa33d884	Move init repository related functions to modules (#19159) ... * Move init repository related functions to modules * Fix lint * Use ctx but db.DefaultContext Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-03-29 15:23:45 +08:00
Lunny Xiao	b06b9a056c	Move organization related structs into sub package (#18518) ... * Move organization related structs into sub package * Fix test * Fix lint * Move more functions into sub packages * Fix bug * Fix test * Update models/organization/team_repo.go Co-authored-by: KN4CK3R <admin@oldschoolhack.me> * Apply suggestions from code review Co-authored-by: KN4CK3R <admin@oldschoolhack.me> * Fix fmt * Follow suggestion from @Gusted * Fix test * Fix test * Fix bug * Use ctx but db.DefaultContext on routers * Fix bug * Fix bug * fix bug * Update models/organization/team_user.go * Fix bug Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-03-29 14:29:02 +08:00
wxiaoguang	7a550b3af2	Use `ctx` instead of `db.DefaultContext` in some packages(routers/services/modules) (#19163) ... * Remove `db.DefaultContext` usage in routers, use `ctx` directly * Use `ctx` directly if there is one, remove some `db.DefaultContext` in `services` * Use ctx instead of db.DefaultContext for `cmd` and some `modules` packages * fix incorrect context usage	2022-03-22 16:22:54 +01:00
KN4CK3R	80fd25524e	Renamed ctx.User to ctx.Doer. (#19161) ... Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2022-03-22 15:03:22 +08:00
6543	54e9ee37a7	format with gofumpt (#18184) ... * gofumpt -w -l . * gofumpt -w -l -extra . * Add linter * manual fix * change make fmt	2022-01-20 18:46:10 +01:00
wxiaoguang	e61b390d54	Unify and simplify TrN for i18n (#18141) ... Refer: https://github.com/go-gitea/gitea/pull/18135#issuecomment-1003246099 Now we have a unique and simple `TrN`, and make the fix of PR #18135 also use the better `TrN` logic.	2022-01-02 04:33:57 +01:00
Gusted	88da7a7174	Use correct user when determining max repo limits for error messages (#18153) ... - Use the correct user(`owner` instead of `ctx.User`) to get the maxCreationLimit.	2022-01-02 02:38:07 +00:00
Gusted	7eb380baa4	Use correct translation key (#18135) ... - Resolves #18122 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2021-12-31 16:43:03 +08:00
zeripath	bef93abd49	Ensure that git repository is closed before transfer (#18049) ... Repository Transfer requires that the repository directory is renamed - which is not possible on Windows if the git repository is open. Fix #17885 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2021-12-21 10:01:58 +08:00
Lunny Xiao	5723240490	Some repository refactors (#17950) ... * some repository refactors * remove unnecessary code * Fix test * Remove unnecessary banner	2021-12-12 23:48:20 +08:00
Lunny Xiao	719bddcd76	Move repository model into models/repo (#17933) ... * Some refactors related repository model * Move more methods out of repository * Move repository into models/repo * Fix test * Fix test * some improvements * Remove unnecessary function	2021-12-10 09:27:50 +08:00
Lunny Xiao	dcdb4873c8	Move repo archiver to models/repo (#17913) ... * Move repo archiver to models/repo * Move archiver service into services/repository/ * Fix imports * Fix test * Fix test	2021-12-06 15:19:28 +08:00
Lunny Xiao	a666829a37	Move user related model into models/user (#17781) ... * Move user related model into models/user * Fix lint for windows * Fix windows lint * Fix windows lint * Move some tests in models * Merge	2021-11-24 17:49:20 +08:00
Lunny Xiao	baed01f247	Remove unnecessary attributes of User struct (#17745) ... * Remove unnecessary functions of User struct * Move more database methods out of user struct * Move more database methods out of user struct * Fix template failure * Fix bug * Remove finished FIXME * remove unnecessary code	2021-11-22 23:21:55 +08:00
Lunny Xiao	fc3d082609	Move attachment into models/repo/ (#17650) ... * Move attachment into models/repo/ * Fix test * Fix bug	2021-11-19 21:39:57 +08:00
Lunny Xiao	7a03473159	Use a standalone struct name for Organization (#17632) ... * Use a standalone struct name for Organization * recover unnecessary change * make the code readable * Fix template failure * Fix template failure * Move HasMemberWithUserID to org * Fix test * Remove unnecessary user type check * Fix test Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-19 19:41:40 +08:00