318 Commits

Author	SHA1	Message	Date
ThetaDev	af901a4ca9	Detect dark theme via css variable (#17800) ... * detect dark theme via css variable * minor refactor, add documentation If your custom theme is considered a dark theme, set the global css variable `--is-dark-theme` to `true`. This allows gitea to adjust the Monaco code editor's theme accordingly.	2021-11-25 15:14:48 +08:00
silverwind	9450410ff7	Improve ellipsis buttons (#17773) ... * Improve ellipsis buttons - Remove icon font usage - Add aria-expanded attribute * rename function to match Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2021-11-22 21:44:38 -05:00
Jimmy Praet	a3efd048a7	Improvements to content history (#17746) ... * Improvements to content history * initialize content history when making an edit to an old item created before the introduction of content history * show edit history for code comments on pull request files tab * Fix a flaw in keepLimitedContentHistory Fix a flaw in keepLimitedContentHistory, the first and the last should never be deleted * Remove obsolete eager initialization of content history	2021-11-22 20:20:16 +08:00
wxiaoguang	49b2cb998b	Fix project board bug and improve documents (#17753) ... * the project board was broken, this PR fixes it, and refactor the code, and we prevent the uncategorized column from being dragged. * improve the frontend guideline (as discussed in https://github.com/go-gitea/gitea/pull/17699)	2021-11-22 19:40:17 +08:00
silverwind	a159c3175f	Add new JS linter rules (#17699) ... * Add new JS linter rules Adds a few useful rules from eslint-plugin-github. Notable changes: - Forbid dataset usage, its camel-casing behaviour makes it hard to grep for attributes. - Forbid .then() and .catch(), we should generally prefer await for new code. For rare cases where they are useful, a eslint-disable-line directive can be set. - Add docs js to linting * also enable github/array-foreach * small tweak Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-22 16:19:01 +08:00
zeripath	8511eec4d4	Allow Loading of Diffs that are too large (#17739) ... * Allow Loading of Diffs that are too large This PR allows the loading of diffs that are suppressed because the file is too large. It does not handle diffs of files which have lines which are too long. Fix #17738 Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-11-22 00:51:08 +08:00
zeripath	0d69e64e03	Make a.add-code-comment click handler an event handler (#17737) ... Instead of directly attaching the add-code-comment on click handler to the a.add-code-comment elements - make this an event handler on the document instead. Fix #17736 Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-11-20 20:12:59 +08:00
Gusted	96ec656cf1	perf: sent data-path once for each file (#17657) ... - Don't sent it with each line, instead send it at the top-element for each file. - Related: https://github.com/go-gitea/gitea/pull/17618#issuecomment-968192761 2.5K Additions: No-Patch: Unified: 2.14 MB (2.14 MB size) Split: 2.59 MB (2.59 MB size) Patch: Unified: 2.10 MB (2.10 MB size) (-1.8%) Split: 2.55 MB (2.55 MB size) (-1.5%)	2021-11-19 10:28:27 +08:00
wxiaoguang	55be5fe339	Refactor repo-legacy.js, remove messy global variables. Fix errors. (#17646) ... Refactor repo-legacy.js, remove messy global variables. Fix errors. Fix an error in Sortable Fix a incorrect call assignMenuAttributes from the template	2021-11-19 00:45:00 +08:00
silverwind	6874fe90e5	Cleanup and use global style on popups (#17674) ... * Cleanup and use global style on popups - Fix typo 'poping' to 'popping' - Remove most inline 'data-variation' attributes - Initialize all popups with 'inverted tiny' variation * misc tweaks * rename to .tooltip, use jQuery Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-18 11:26:50 +08:00
Gusted	d8a8961b99	Sanitize user-input on file name (#17666) ... * Sanitize user-input on file name - Sanitize user-input before it get passed into the DOM. - Prevent things like "<iframe onload=alert(1)></iframe>" from being executed. This isn't a XSS attack as the server seems to be santizing the path as well. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-17 18:08:25 +00:00
zeripath	bbffcc3aec	Multiple Escaping Improvements (#17551) ... There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this. This is an extensive PR attempting to fix these issues. 1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping. 2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand. 3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.) 5. The title generation in feeds is now properly escaped. 6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-11-16 18:18:25 +00:00
Gusted	447428f446	Remove superfluous argument (#17667) ... As title.	2021-11-16 19:36:03 +08:00
silverwind	23bd7b1211	Add copy button to markdown code blocks (#17638) ... * Add copy button to markdown code blocks Done mostly in JS because I think it's better not to try getting buttons past the markup sanitizer. * add svg module tests * fix sanitizer regexp * remove outdated comment * vertically center button in issue comments as well * add comment to css * fix undefined on view file line copy * combine animation less files * Update modules/markup/markdown/markdown.go Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> * add test for different sizes * add cloneNode and add tests for it * use deep clone * remove useless optional chaining * remove the svg node cache * unify clipboard copy string and i18n * remove unused var * remove unused localization * minor css tweaks to the button * comment tweak * remove useless attribute Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-16 16:16:05 +08:00
wxiaoguang	6292603215	Fix database deadlock when update issue labels (#17649) ... This fix updates issue labels one by one, and won't cause database deadlock. In future, we can use a batch API to update all changed labels by one request.	2021-11-16 10:21:13 +08:00
Gusted	8eddb75508	perf: only generate data-comment-url once (#17618)	2021-11-14 00:28:57 -05:00
wxiaoguang	7f802631c5	Fix some incorrect async functions, improve frontend document. (#17597)	2021-11-12 20:37:45 +08:00
silverwind	433e81aecf	Update JS dependencies (#17611) ... - Update monaco, adapting to breaking changes - Update dropzone, adapting to breaking changes - Update linters, fix new issues, disable opinionated stylelint rules - Rebuild SVGs and images - Tested Dropzone and Monaco Replaces: https://github.com/go-gitea/gitea/pull/17574	2021-11-11 09:52:16 +08:00
wxiaoguang	bb71ceeeb2	Improve async/await usage, and sort init calls in index.js (#17386) ... * clean up async/await, and sort init calls in `index.js * use `const _promise` to indicate that we do not need await an async function	2021-11-09 17:27:25 +08:00
zeripath	513951bc16	Remove appSubUrl from pasted images (#17572) ... * Remove appSubUrl from pasted images Since we fixed the url base for the links in repositories we no longer need to add the appsuburl to pasted image links. Fix #17057 Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-11-08 14:27:40 +08:00
qwerty287	f46e67b519	Move key forms before list and add cancel button (#17432) ... * Move GPG form before list and add cancel button * Move SSH form before list and add cancel button Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-10-28 18:55:48 +08:00
wxiaoguang	2b2eb5d0ad	make commit-statuses popup can be shown correctly. (#17447) ... Close #17443 Maybe we do not need to backport this PR, the bug doesn't break daily usage. After the fix, the commit statuses popup can show a lot of lines with scroll bars: 	2021-10-28 02:34:18 +01:00
wxiaoguang	89beceeb9a	Fix a UI error when folding a file content in a commit view (#17446)	2021-10-27 19:11:56 +08:00
David Jimenez	a462fcaac8	Show client-side error if wiki page is empty (#17415) ... * fix: show client-side error if wiki page is empty Implement a JS, client-side validation workaround for a bug in the upstream editor library SimpleMDE which breaks HTML5 client-side validation when a wiki page is submitted. This allows native, client-side errors to appear if the text editor contents are empty. See upstream bugfix report: https://github.com/sparksuite/simplemde-markdown-editor/issues/324 Signed-off-by: David Jimenez <dvejmz@sgfault.com> Co-authored-by: Lauris BH <lauris@nix.lv>	2021-10-27 12:33:22 +08:00
wxiaoguang	943dc08722	Fix issue content history problems, improve UI (#17404) ... * Improve: make diff result better, make the HTML element fit the full height in the content history diff dialog * Bug fix: when edit the main issue, the poster is wrongly set to the issue poster	2021-10-23 22:47:38 +08:00
wxiaoguang	406bd3780e	Fix context popup error (#17398) ... * Fix context popup error	2021-10-22 22:34:01 +08:00
wxiaoguang	a115309f4f	Fix the click behavior for <tr> and <td> with [data-href] (#17388)	2021-10-21 19:19:32 +01:00
wxiaoguang	2add8fe9be	Frontend refactor, PascalCase to camelCase, remove unused code (#17365) ... * Frontend refactor, PascalCase to camelCase, remove unused code * fix	2021-10-21 15:37:43 +08:00
Mario Lubenka	0208ea0248	"Copy branch name" button in pull request (#17323) ... * Drop data-original from clipboard data-original attribute was removed. Instead, the original value from data-content is set after success/fail message was displayed. Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * "Copy branch name" button in pull request Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com> * Update templates/repo/issue/view_title.tmpl Co-authored-by: silverwind <me@silverwind.io> * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: zeripath <art27@cantab.net>	2021-10-19 13:32:11 -04:00
Netduma Luke M	9f3d5c0a23	Re-allow clipboard copy on non-https sites (#17118) ... * Re-allow clipboard copy on non-https sites * fallback clipboard functions	2021-10-19 18:22:16 +08:00
silverwind	eaf493be5d	Update JS dependencies (#17357) ... * Update JS dependencies - Upgrade to eslint 8 and add new plugin rules - Adapt to various API changes - Rebuild SVGs * fix webpack warning on license * order options alphabetically Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2021-10-19 15:23:58 +08:00
zeripath	e2a59c57fc	Fix dashboard repolist alignment and repolisting (#17355) ... Unfortunately #17301 broke the restriction of the dashboard repolist to the user's repos because it stopped passing in the uid for the current user. This PR restores this. There is also a weird alignment problem - not caused by that PR - where the menu items in the repolist spread over multiple lines. This PR simply reduces the padding on these items and switches the justification of the flex elements to space-evenly. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2021-10-19 12:38:33 +08:00
wxiaoguang	7333104e89	Fix the PR review form bug during frontend refactor (#17332)	2021-10-16 22:30:31 +02:00
wxiaoguang	1a7473ff45	Split index.js to separate files (#17315) ... * split `index.js` to separate files * tune clipboard * fix promise * fix document * remove intermediate empty file * fix async event listener * use `export function` instead of `export {}`, add more comments Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2021-10-17 01:28:04 +08:00
zeripath	a889d0cc8c	Add buttons to allow loading of incomplete diffs (#16829) ... This PR adds two buttons to the stats and the end of the diffs list to load the (some of) the remaining incomplete diff sections. Contains #16775 Signed-off-by: Andrew Thornton <art27@cantab.net> ## Screenshots ### Show more button at the end of the diff  ### Show more button at the end of the diff stats box 	2021-10-15 17:05:33 +01:00
wxiaoguang	56362043d3	Frontend refactor: move Vue related code from index.js to components dir, and remove unused codes. (#17301) ... * frontend refactor * Apply suggestions from code review Co-authored-by: delvh <dev.lh@web.de> * Update templates/base/head.tmpl Co-authored-by: delvh <dev.lh@web.de> * Update docs/content/doc/developers/guidelines-frontend.md Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> * fix typo * fix typo * refactor PageData to pageData * Apply suggestions from code review Co-authored-by: delvh <dev.lh@web.de> * Simply for the visual difference. Co-authored-by: delvh <dev.lh@web.de> * Revert "Apply suggestions from code review" This reverts commit 4d78ad9b0e96ca180e0823de17659a2e0814c099. Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2021-10-15 10:35:26 +08:00
Maximilian Weiler	030f696cdd	Show direct match on top for user search (#17303) ... This PR makes sure that direct matches in the user search always show on top of the result list. The following places were checked to follow the desired behavior now: - Search when adding a user to a team - Search when adding a user as a collaborator to a repository Signed-off-by: Maximilian Weiler <16721506+maweil@users.noreply.github.com>	2021-10-15 01:48:47 +02:00
wxiaoguang	7bcbdd0707	Add user status filter to admin user management page (#16770) ... It makes Admin's life easier to filter users by various status. * introduce window.config.PageData to pass template data to javascript module and small refactor move legacy window.ActivityTopAuthors to window.config.PageData.ActivityTopAuthors make HTML structure more IDE-friendly in footer.tmpl and head.tmpl remove incorrect <style class="list-search-style"></style> in head.tmpl use log.Error instead of log.Critical in admin user search * use LEFT JOIN instead of SubQuery when admin filters users by 2fa. revert non-en locale. * use OptionalBool instead of status map * refactor SearchUserOptions.toConds to SearchUserOptions.toSearchQueryBase * add unit test for user search * only allow admin to use filters to search users	2021-10-12 20:11:35 +02:00
wxiaoguang	c5c88f2f18	Save and view issue/comment content history (#16909) ... * issue content history * Use timeutil.TimeStampNow() for content history time instead of issue/comment.UpdatedUnix (which are not updated in time) * i18n for frontend * refactor * clean up * fix refactor * re-format * temp refactor * follow db refactor * rename IssueContentHistory to ContentHistory, remove empty model tags * fix html * use avatar refactor to generate avatar url * add unit test, keep at most 20 history revisions. * re-format * syntax nit * Add issue content history table * Update models/migrations/v197.go Co-authored-by: 6543 <6543@obermui.de> * fix merge Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Lauris BH <lauris@nix.lv>	2021-10-10 18:40:03 -04:00
qwerty287	56d79301b9	Move add deploy key form before the list and add a cancel button (#17228)	2021-10-08 18:15:09 +02:00
zeripath	001dbf100d	Defer Last Commit Info (#16467) ... One of the biggest reasons for slow repository browsing is that we wait until last commit information has been generated for all files in the repository. This PR proposes deferring this generation to a new POST endpoint that does the look up outside of the main page request. Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-10-08 15:08:22 +02:00
Norwin	8f75a559ee	Reference in new issue modal: dont pre-populate issue title (#17208) ... * dont prepopulate issue title * cleanup	2021-10-02 12:05:55 -04:00
qwerty287	47193dbcd9	Add option to copy line permalink (#17145) ... * Add option to copy line permalink * Fix lint * Apply review suggestions * Update code and fix lint * Use features/clipboard.js framework	2021-10-02 10:46:43 +03:00
Romain	ecfac78f6e	Kanban colored boards (#16647) ... Add a column Color in ProjectBoard and color picker in new / edit project board form.	2021-09-29 22:53:12 +02:00
Gwyneth Morgan	4e0cca3f7d	Use light/dark theme based on system preference (#17051) ... Add a new default theme `auto`, which will automatically switch between `gitea` (light) and `arc-green` (dark) themes depending on the user's operating system settings. Closes: #8183	2021-09-27 15:47:44 +01:00
Jelle Hulter	b74a0f9060	Fixed issue where creating a reference of an issue would create a tag with the full name instead of the username if this is the default in the .ini file (#17074) ... Adds an extra attribute to every issue comment containing the actual username, such that it can be used to tag the original author when clicking on "Reference in new issue" (#17073) Fix #17073	2021-09-18 16:44:45 +01:00
zeripath	976db2a8b7	Do not show issue context popup on external issues (#17050) ... The issues pop-up context cannot work for external issues - therefore do not show these. Fix #17047 Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-09-15 09:45:27 +01:00
zeripath	248b96d8a3	Use git attributes to determine generated and vendored status for language stats and diffs (#16773) ... Replaces #16262 Replaces #16250 Replaces #14833 This PR first implements a `git check-attr` pipe reader - using `git check-attr --stdin -z --cached` - taking account of the change in the output format in git 1.8.5 and creates a helper function to read a tree into a temporary index file for that pipe reader. It then wires this in to the language stats helper and into the git diff generation. Files which are marked generated will be folded by default. Fixes #14786 Fixes #12653	2021-09-09 21:13:36 +01:00
wxiaoguang	07fde28ddb	Fix wrong attachment removal (#16915)	2021-09-01 23:53:29 +02:00
a1012112796	cbf05c3f79	Add option to update pull request by rebase (#16125) ... * add option to update pull request by `rebase` Signed-off-by: a1012112796 <1012112796@qq.com>	2021-08-31 16:03:45 +02:00