16378 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
GiteaBot	a38cf868c5	[skip ci] Updated licenses and gitignores	2023-09-04 00:23:31 +00:00
Lunny Xiao	1bfb3f78f6	Update documents to fix some links (#26885)	2023-09-03 18:45:20 +00:00
JonRB	99a5595408	clarify aspects of the dump command (#26887) ... clarify aspects of the dump command Possibly closes #26862 --------- Co-authored-by: delvh <dev.lh@web.de>	2023-09-03 14:44:01 -04:00
BeYonme	918accaafa	Relocate the RSS user feed button (#26882) ... before:  after:  Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	2023-09-03 11:06:59 +00:00
wxiaoguang	fc039167d2	Use Go 1.21 and update dependencies (#26878) ... To make sure Gitea's next release's lifecycle could have active Golang support. And min/max are builtin now.	2023-09-03 10:34:57 +00:00
CaiCandong	7477c93d62	Update docs about attachment path (#26883) ... This change was caused by #26271, for configuration as below: ``` [attachment] ENABLE = true PATH = data/attachments MAX_SIZE = 100 MAX_FILES = 5 ``` Before #26271, the resolved path is ${AppWorkPath}/${attachments.PATH} (such as `/var/lib/gitea/data/attachments`) After #26271, the resolved path is ${AppDataPath}/${attachments.PATH} (such as `/var/lib/gitea/data/data/attachments`) Fix https://github.com/go-gitea/gitea/issues/26864 Follow https://github.com/go-gitea/gitea/pull/26271	2023-09-03 11:40:10 +02:00
wxiaoguang	fba7150ca9	Refactor "shortsha" (#26877) ... The old code used complex `if` blocks and strange HTML layouts. <details>  </details> This PR refactors the template code and remove legacy CSS styles. The UI doesn't change much.  	2023-09-03 02:58:52 +00:00
Nanguan Lin	f1fe102c8c	Fix wrong review requested number (#26784) ... Fix the wrong review requested number mentioned by #18808 . Fix #18808 Before:  After: 	2023-09-03 02:12:38 +00:00
wxiaoguang	c802c46a9b	Refactor og:description to limit the max length (#26876) ... 1. The `og:description` should be "a one to two sentence description of your object" * It shouldn't output all the user inputted content -- it would be pretty huge. * Maybe it only needs at most 300 bytes. 2. Do not render commit message as HTML	2023-09-03 01:43:29 +00:00
silverwind	9a3de436f4	Reorder blocks in vue SFCs (#26874) ... The [recommended order](https://vuejs.org/guide/scaling-up/sfc.html) for SFC blocks is script -> template -> style, which we were violating because template and script were swapped. I do find script first also easier to read because the imports are on top, letting me immideatly see a component's dependencies. This is a pure cut-paste refactor with some removal of some empty lines. --------- Co-authored-by: Lauris BH <lauris@nix.lv>	2023-09-02 14:59:07 +00:00
6543	79f7329971	Make it posible to customize nav text color via css var (#26807) ... --- *Sponsored by Kithara Software GmbH*	2023-09-02 05:10:41 +02:00
silverwind	a625f3a761	Enable djlint H008 and fix issues (#26869) ... Enable `H008 | Attributes should be double quoted` and fix issues.	2023-09-01 17:32:39 +00:00
Linus Groh	5743d7cb5b	Improve opengraph previews (#26851) ... Add more useful Open Graph metadata for commit and file URLs: - Set `og:title` to the page title, which is a concise summary in both cases (`<commit message> · <commit hash>` and `<filename> at <branch>`, respectively) - Set `og:description` to the commit message body, if available - Set `og:url` to the relevant URLs instead of the repo URL Also move the relevant meta tags into a separate template as they now take up the majority of the base head template.	2023-09-01 16:59:24 +00:00
Jack Hay	9881b8a4e2	Add more descriptive error on forgot password page (#26848) ... ## Changes - Forces flashed error to render immediately when forgot password code is incorrect or has expired. - Adds a link back to the `forgot_password` page so that the user can restart the process (in the event that their link has expired)	2023-09-01 16:15:39 +00:00
Zettat123	04771b5ff7	Allow users with write permissions for issues to add attachments with API (#26837) ... Fixes #24944 Since a user with write permissions for issues can add attachments to an issue via the the web interface, the user should also be able to add attachments via the API	2023-09-01 15:35:38 +00:00
silverwind	02efd99010	Move licenses.txt to /assets directory (#26866) ... Now that we have the `/assets` directory, we can put`licenses.txt` directly into it instead of incorrect `/js` path which was previously only done to avoid reserving a username. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-01 14:42:33 +00:00
silverwind	327a7ad518	Use case-insensitive regex for all webpack assets (#26867) ... Previously, only some of these regex had the `i` flag and while we can likely ensure case for our files, these regexes are also used for third-party files, so it's better to always match insensitively.	2023-09-01 14:07:37 +00:00
Earl Warren	4ab8e56c91	restrict certificate type for builtin SSH server (#26789) ... - While doing some sanity checks over OpenSSH's code for how they handle certificates authentication. I stumbled on an condition that checks the certificate type is really an user certificate on the server-side authentication. This checks seems to be a formality and just for the sake of good domain seperation, because an user and host certificate don't differ in their generation, verification or flags that can be included. - Add this check to the builtin SSH server to stay close to the unwritten SSH specification. - This is an breaking change for setups where the builtin SSH server is being used and for some reason host certificates were being used for authentication. - (cherry picked from commit de35b141b79a3d6efe2127ed2c73fd481515e481) Refs: https://codeberg.org/forgejo/forgejo/pulls/1172 ## ⚠️ BREAKING ⚠️ Like OpenSSH, the built-in SSH server will now only accept SSH user certificates, not server certificates. Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-01 13:45:22 +00:00
Bo-Yi Wu	9eb4a9e601	feat(API): add secret deletion functionality for repository (#26808) ... - Modify the `CreateOrUpdateSecret` function in `api.go` to include a `Delete` operation for the secret - Modify the `DeleteOrgSecret` function in `action.go` to include a `DeleteSecret` operation for the organization - Modify the `DeleteSecret` function in `action.go` to include a `DeleteSecret` operation for the repository - Modify the `v1_json.tmpl` template file to update the `operationId` and `summary` for the `deleteSecret` operation in both the organization and repository sections --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>	2023-09-01 13:02:49 +00:00
wxiaoguang	f01bed2443	Avoid double-unescaping of form value (#26853) ... 1. The old `prepareQueryArg` did double-unescaping of form value. 2. By the way, remove the unnecessary `ctx.Flash = ...` in `MockContext`. Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-01 12:01:36 +00:00
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859) ... Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	2023-09-01 11:26:07 +00:00
wxiaoguang	fcb4941d47	Remove some unused CSS styles (#26852) ... 1. `icons`: globally searched, no use in templates. 2. toast's `display: inline-block;`: there is a `display: flex` below.	2023-09-01 08:59:38 +02:00
GiteaBot	3ff81d38d8	[skip ci] Updated translations via Crowdin	2023-09-01 00:24:05 +00:00
silverwind	9b76df53dc	Minor dashboard tweaks, fix flex-list margins (#26829) ... Some small dashboard tweaks: - Remove margin-bottom from divider so first item does not appear to have un-equal margins - Restore previous icon color - Add slight margin-right to icon Before: <img width="783" alt="Screenshot 2023-08-31 at 00 10 28" src="https://github.com/go-gitea/gitea/assets/115237/b75f70d7-8704-4afb-866d-fea0484c52d4"> After: <img width="783" alt="Screenshot 2023-08-31 at 00 10 08" src="https://github.com/go-gitea/gitea/assets/115237/50ed0c47-6f7c-449e-a054-13091369d43f"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-31 21:28:45 +00:00
Jack Hay	c0ab7070e5	Update team invitation email link (#26550) ... Co-authored-by: Kyle D <kdumontnu@gmail.com> Co-authored-by: Jonathan Tran <jonnytran@gmail.com>	2023-08-31 16:26:13 +00:00
JakobDev	3cae50e841	Redirect from {repo}/issues/new to {repo}/issues/new/choose when blank issues are disabled (#26813) ... You can currently visit `{repo}/issues/new` and create a blank issue, even if it's disabled. This PR fixes this, Fixes https://codeberg.org/forgejo/forgejo/issues/1356 Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-31 15:36:25 +00:00
wxiaoguang	d5703d4a1b	Remove "TODO" tasks from CSS file (#26835) ... 1. Use `gt-invisible` instead of `invisible`. 2. Use `gt-word-break` instead of `dont-break-out` (there is a slight different "hyphens", but I think it won't affect too much since it is only used for the "full name"). 3. Remove `.small.button:has(svg)` , now our buttons could layout SVG correctly, and actually I didn't see this CSS class is used in code.	2023-08-31 10:49:53 +00:00
Denys Konovalov	5b5bb8d354	User details page (#26713) ... This PR implements a proposal to clean up the admin users table by moving some information out to a separate user details page (which also displays some additional information). Other changes: - move edit user page from `/admin/users/{id}` to `/admin/users/{id}/edit` -> `/admin/users/{id}` now shows the user details page - show if user is instance administrator as a label instead of a separate column - separate explore users template into a page- and a shared one, to make it possible to use it on the user details page - fix issue where there was no margin between alert message and following content on admin pages <details> <summary>Screenshots</summary>   </details> Partially resolves #25939 --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-31 11:21:18 +02:00
silverwind	3d109861dd	Render code blocks in repo description (#26830) ... Backtick syntax now works in repo description too. Also, I replaced the CSS for this was a new single class, making it more flexible and not dependent on a parent. Also, very slightly reduced font size from 16.8px to 16px. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-31 05:01:01 +00:00
silverwind	c35b16a9a4	Remove joinPaths function (#26833) ... Extract from https://github.com/go-gitea/gitea/pull/25940. `assetUrlPrefix` is guaranteed to not contain trailing slashes, making this function unneeded.	2023-08-31 02:46:44 +00:00
wxiaoguang	19a1e1b20e	Remove polluted .ui.right (#26825) ... Each change is tested manually line by line. There are too many changes so I can't share dozens of screenshots. In short: 1. `ui right` could be still used in `ui top attached header`, because there is a special case. 2. A lot of `ui right` are just no-op, so they can be removed safely. 3. Some of the `ui right` should be replaced by `gt-float-right` (to avoid breaking, leave them to the future). 4. A few of the `ui right` could be rewritten by flex.	2023-08-31 02:29:59 +00:00
Zettat123	98f2bf23bc	Sync tags when adopting repos (#26816) ... Fixes #26138 Sync the tags into database when adopting repos --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	2023-08-31 01:42:42 +00:00
techknowlogick	4544b2a9a3	rm comment about hugo (#26832)	2023-08-31 01:09:11 +00:00
silverwind	274c16e481	Fix filename for .spectral.yaml (#26828) ... Mixed up yml vs. yaml previously.	2023-08-30 20:41:37 -04:00
GiteaBot	10aab8a385	[skip ci] Updated translations via Crowdin	2023-08-31 00:22:07 +00:00
techknowlogick	45976a1bde	Check blocklist for emails when adding them to account (#26812)	2023-08-30 10:46:49 -05:00
wxiaoguang	1bb9b1c4d9	Remove polluted ".ui.left" style (#26809)	2023-08-30 21:46:24 +08:00
delvh	2590707122	Remove fomantic text module (#26777) ... Corollary to #26775: All selectors I found that are actually used and not necessarily present in the current code have been copied to `web_src/css/base.css`. Everything else should be a clean removal.	2023-08-30 10:37:17 +00:00
KN4CK3R	5315153059	Use Set[Type] instead of map[Type]bool/struct{}. (#26804)	2023-08-30 06:55:25 +00:00
CaiCandong	815d267c80	Fix verifyCommits error when push a new branch (#26664) ... > ### Description > If a new branch is pushed, and the repository has a rule that would require signed commits for the new branch, the commit is rejected with a 500 error regardless of whether it's signed. > > When pushing a new branch, the "old" commit is the empty ID (0000000000000000000000000000000000000000). verifyCommits has no provision for this and passes an invalid commit range to git rev-list. Prior to 1.19 this wasn't an issue because only pre-existing individual branches could be protected. > > I was able to reproduce with [try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test), which is set up with a blanket rule to require commits on all branches. Fix #25565 Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting an valid solution! --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2023-08-30 02:27:53 +00:00
silverwind	508de3a58d	Fix Uint8Array comparisons and update vitest (#26805) ... Compare those `Uint8Array` via conversion to Array which are properly comparable, so that we don't have to worry about whether `TextEncoder` and `UInt8Array` from the environment are compatible or not. --------- Co-authored-by: delvh <dev.lh@web.de>	2023-08-30 01:56:44 +00:00
silverwind	7bc80cb350	Add various missing files-changed dependencies (#26799) ... We were missing a number of config files like `.golangci.yml` in the dependencies for the pull request pipelines, which resulted in the linting not running for https://github.com/go-gitea/gitea/pull/26786 because only `.golangci.yml` had changed.	2023-08-30 01:40:13 +00:00
wxiaoguang	1a9998ce91	Improve flex list item padding (#26779) ... Replace #26761 It's better to keep children elements simple, and let parent containers layout the necessary padding/margin. The old `not(:last-child)` and `.flex-item + .flex-item` are not easy to maintain (for example, what if the developer would like to use a "tiny height" item?) The old approach also makes some UI look strange because the first item doesn't have proper padding-top. In this PR, we just simply use `.flex-item { padding: ... }`: * Developers could manually set the item height they want easily * It's easier to make it work with various containers -- with padding (`ui segment`) and without padding (`div`) And added more samples/examples.  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-29 23:13:30 +00:00
js6pak	4f5a2117c3	Include the GITHUB_TOKEN/GITEA_TOKEN secret for fork pull requests (#26759) ... Include `GITHUB_TOKEN`/`GITEA_TOKEN` secrets for actions triggered by pull requests This makes it consistent with the environment variables which you can already access ```shell echo env: $GITHUB_TOKEN echo expression: ${{ secrets.GITHUB_TOKEN }} ``` before  after  --------- Co-authored-by: Jason Song <i@wolfogre.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-29 22:13:16 +00:00
Bo-Yi Wu	b91057b172	feat(API): add route and implementation for creating/updating repository secret (#26766) ... spec: https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28#create-or-update-a-repository-secret - Add a new route for creating or updating a secret value in a repository - Create a new file `routers/api/v1/repo/action.go` with the implementation of the `CreateOrUpdateSecret` function - Update the Swagger documentation for the `updateRepoSecret` operation in the `v1_json.tmpl` template file --------- Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-29 20:54:49 +00:00
Chongyi Zheng	2d9249b6d9	Replace deprecated elliptic.Marshal (#26800) ... In PR #26786, the Go version for golangci-lint is bumped to 1.21. This causes the following error: ``` models/migrations/v1_16/v210.go:132:23: SA1019: elliptic.Marshal has been deprecated since Go 1.21: for ECDH, use the crypto/ecdh package. This function returns an encoding equivalent to that of PublicKey.Bytes in crypto/ecdh. (staticcheck) PublicKey: elliptic.Marshal(elliptic.P256(), parsed.PubKey.X, parsed.PubKey.Y), ``` The change now uses [func (*PublicKey) ECDH](https://pkg.go.dev/crypto/ecdsa#PublicKey.ECDH), which is added in Go 1.20.	2023-08-29 22:19:40 +02:00
puni9869	438c7642c7	Updating the js libraries to latest version. (#26795) ... As title. <img width="657" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/db8f6c80-78b5-4992-800c-802ee7b9ba6d">	2023-08-30 02:29:13 +08:00
Chongyi Zheng	ad43486cd3	Fix some slice append usages (#26778) ... Co-authored-by: delvh <dev.lh@web.de>	2023-08-29 15:47:26 +00:00
Chongyi Zheng	3507cad6f5	Use Go 1.21 for golangci-lint (#26786) ... Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-29 16:25:24 +02:00
wxiaoguang	96ba747ff2	Fix notification circle (border-radius) (#26794) ... `border-radius` means `radius`, not `diameter`, so it should be `50%` and `boxHeight / 2`	2023-08-29 14:03:34 +00:00