wanderer/gitea
1
0
Fork 0
forked from mirror/gitea
Code Issues Pull Requests Releases Activity
14,241 Commits 2 Branches 0 Tags 167 MiB
36a2d2f919
Commit Graph

14241 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lunny Xiao
36a2d2f919
Add a simple test for external renderer (#20033) 
Fix #16402
 2022-12-12 20:45:21 +08:00
Lunny Xiao
6398ca745a
refactor bind functions based on generics (#22055) 2022-12-12 16:09:26 +08:00
Lunny Xiao
003b4e209c
Allow disable code tab (#20805) 
I know some users created a repository in an organization but just use
issues and projects to handle the whole organizations issues. So that
`Code` could be disabled per repository.

<img width="1148" alt="image"
src="https://user-images.githubusercontent.com/81045/184792075-346cb508-b620-4adb-bc9a-cba76fdcb294.png">

It could also become a wiki repository.

<img width="1173" alt="image"
src="https://user-images.githubusercontent.com/81045/184792324-e15c6f68-35c0-4105-ab77-83585ce53672.png">

Co-authored-by: delvh <dev.lh@web.de>
 2022-12-12 13:29:27 +08:00
Lunny Xiao
3e8285b824
Use multi reader instead to concat strings (#22099) 
extract from #20326
 2022-12-12 11:03:54 +08:00
aceArt-GmbH
352a50d65f
Fix sorting admin user list by last login (#22081) 
Admin User Account list sort

`updated_unix` is not the same as "Last Sign-In"
 2022-12-11 18:00:17 -06:00
Lunny Xiao
c9ef03af65
Fix wrong default value for update checker on app.example.ini (#22084) 2022-12-11 16:08:01 -06:00
Restray
112e425f90
fix(config): remove context on config template (#22096) 
👋 Hey
I'm new around here, so I may have done some mistakes, sorry! 

---

## Context
On a fresh Gitea install, when I go to the [config admin
page](http://localhost:3000/admin/config) I had a 500 error page.
The logs:
```
2022/12/10 20:08:47 ...s/context/context.go:232:HTML() [E] [6394d93f] Render failed: template: admin/config:180:22: executing "admin/config" at <.Service.DefaultAllowOnlyContributorsToTrackTime>: DefaultAllowOnlyContributorsToTrackTime has arguments but cannot be invoked as function
2022/12/10 20:08:47 [6394d93f] router: completed GET /admin/config for [::1]:43800, 500 Internal Server Error in 5.1ms @ admin/config.go:99(admin.Config)
```

## The fix

I removed the `$.Context` on the
`.Service.DefaultAllowOnlyContributorsToTrackTime` to fix the 500 error
page happening. It could be a mistake, and I don't fully understand what
I've done!

Signed-off-by: Restray <contact@restray.org>
 2022-12-11 12:06:12 +08:00
KN4CK3R
601d126627 [skip ci] Updated licenses and gitignores 2022-12-11 00:19:34 +00:00
KN4CK3R
0e2d04601a
Update xorm (#22094) 2022-12-10 18:53:32 -05:00
Yarden Shoham
9745c33e9e
Remove unnecessary whitespace in snapcraft.yaml (#22090) 
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
 2022-12-10 08:31:16 -06:00
Lunny Xiao
68704532c2
Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
Felipe Leopoldo Sologuren Gutiérrez
097d4e30b1
Change ID pattern of raw content container for issue (#21966) 
Implement differentiation to html id for issue raw content container.

Fixes #21965
 2022-12-10 00:25:32 +08:00
Jason Song
2779d47ad3
Optimize html templates (#22080) 
Replace `active{{end}} item` with `active{{end}} item`.
 2022-12-09 21:34:51 +08:00
KN4CK3R
3c59d31bc6
Add API management for issue/pull and comment attachments (#21783) 
Close #14601
Fix #3690

Revive of #14601.
Updated to current code, cleanup and added more read/write checks.

Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andre Bruch <ab@andrebruch.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Norwin <git@nroo.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-09 14:35:56 +08:00
Jason Song
8fb1e53ca2
Rename actions to operations on UI (#22067) 
Use "operations" to indicate "some something can be done", to prevent
users from confusing it with CICD.

Releated to: #13539.

Snapshots:

<img width="389" alt="image"
src="https://user-images.githubusercontent.com/9418365/206409797-a99bac25-2d38-4066-b9ab-27a4f6fe67e7.png">
<img width="398" alt="image"
src="https://user-images.githubusercontent.com/9418365/206410099-bbd258a9-54d9-4664-8d95-31d29cb35209.png">
<img width="442" alt="image"
src="https://user-images.githubusercontent.com/9418365/206410218-009a3103-a9b9-4d0c-86b6-540dda5bce89.png">

I'm not a native English speaker, but I think "operations" may be good
enough, and Gitea already uses this word:

<img width="1440" alt="image"
src="https://user-images.githubusercontent.com/9418365/206410671-4a718b14-0603-40cb-bdcb-f6f84d1f5e24.png">
 2022-12-08 21:14:09 +08:00
silverwind
0585ac3ac6
Update go dev dependencies (#22064) 
`golangci-lint`
[deprecated](https://github.com/golangci/golangci-lint/issues/1841) a
bunch of linters, removed them.
 2022-12-08 16:21:37 +08:00
hr-98
cf27403e18
Round language stats percentage using largest remainder (#22026) 
Fix #22023 

I've changed how the percentages for the language statistics are rounded
because they did not always add up to 100%
Now it's done with the largest remainder method, which makes sure that
total is 100%

Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-12-08 10:47:47 +08:00
Jason Song
0a85537c79
Support disabling database auto migration (#22053) 
Gitea will migrate the database model version automatically, but it
should be able to be disabled and keep Gitea shutdown if the version is
not matched.
 2022-12-07 09:58:31 -06:00
silverwind
e2fa84fddc
Release and Tag List tweaks (#21712) 
- Reduce font size on tag list and add muted links
- Move Release tag to right side on release list
- Move Release edit button to far-right and make it icon-only
- Add styles for error dropdowns, seen on release edit page
- Make the release page slightly more mobile-friendly

<img width="468" alt="Screen Shot 2022-11-07 at 22 10 44"
src="https://user-images.githubusercontent.com/115237/200417500-149f40f5-2376-42b4-92a7-d7eba3ac359d.png">

<img width="1015" alt="Screen Shot 2022-11-07 at 22 27 14"
src="https://user-images.githubusercontent.com/115237/200419201-b28f39d6-fe9e-4049-8023-b301c9bae528.png">
<img width="1019" alt="Screen Shot 2022-11-07 at 22 27 27"
src="https://user-images.githubusercontent.com/115237/200419206-3f07d988-42f6-421d-8ba9-303a0d59e711.png">

<img width="709" alt="Screen Shot 2022-11-07 at 22 42 10"
src="https://user-images.githubusercontent.com/115237/200421671-f0393cde-2d8f-4e1f-a788-f1f51fc4807c.png">
<img width="713" alt="Screen Shot 2022-11-07 at 22 42 27"
src="https://user-images.githubusercontent.com/115237/200421676-5797f8cf-dfe8-4dd6-85d4-dc69e31a9912.png">


<img width="406" alt="image"
src="https://user-images.githubusercontent.com/115237/200418220-8c3f7549-61b4-4661-935e-39e1352f7851.png">
<img width="416" alt="Screen Shot 2022-11-07 at 22 21 36"
src="https://user-images.githubusercontent.com/115237/200418107-cdb0eb6f-1292-469c-b89a-2cb13f24173c.png">

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-06 21:15:46 +08:00
Jason Song
74874d065f
Fix issue/PR numbers (#22037) 
When deleting a closed issue, we should update both `NumIssues`and
`NumClosedIssues`, or `NumOpenIssues`(`= NumIssues -NumClosedIssues`)
will be wrong. It's the same for pull requests.

Releated to #21557.

Alse fixed two harmless problems:

- The SQL to check issue/PR total numbers is wrong, that means it will
update the numbers even if they are correct.
- Replace legacy `num_issues = num_issues + 1` operations with
`UpdateRepoIssueNumbers`.
 2022-12-06 15:53:09 +08:00
Yarden Shoham
77f50356f4
Remove useless "Cancel" buttons (#21872) 
* Continues #21381

These buttons have no real use. To cancel, one would simply navigate
away.

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
 2022-12-05 20:38:34 +08:00
zeripath
a08584ee36
Ensure that Chinese punctuation is not ambiguous when locale is Chinese (#22019) 
Although there are per-locale fallbacks for ambiguity the locale names
for Chinese do not quite match our locales. This PR simply maps zh-CN on
to zh-hans and other zh variants on to zh-hant.

Ref #20999

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-12-04 17:57:30 +00:00
zeripath
ea86c2b56a
Use GhostUser if needed for TrackedTimes (#22021) 
When getting tracked times out of the db and loading their attributes
handle not exist errors in a nicer way. (Also prevent an NPE.)

Fix #22006

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-12-04 17:48:18 +00:00
Michael Kriese
84d2a820e5
Add dumb-init to rootless docker (#21775) 
Add dumb-init as process reaper to the rootless image to reap defunct git processes.
 2022-12-04 11:12:06 +00:00
6543
46485848fa
On tag/branch-exist check, dont panic if repo is nil (#21787) 
fix a panic found in gitea logs
 2022-12-04 10:28:57 +00:00
Lunny Xiao
36cbaec54c
Fix ListBranches to handle empty case (#21921) 
Fix #21910

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
 2022-12-04 08:57:17 +00:00
Percy Ma
9eb9cf5153
fix(web): reduce page jitter on browsers that support overlay scrollbar (#21850) 
Reduce jitter caused by the presence or absence of scrollbars in page
switching

---

Ref [scrollbar-gutter |
MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter)


https://user-images.githubusercontent.com/45708948/165972251-7d5a5017-f76d-4ba2-9106-a224b3ee521f.mp4
 2022-12-04 08:56:10 +00:00
zeripath
d084ce306a [skip ci] Updated licenses and gitignores 2022-12-04 00:19:34 +00:00
zeripath
0e46499258
Do not emit ambiguous character warning on rendered pages (#22016) 
The real sensitivity of ambiguous characters is in source code -
therefore warning about them in rendered pages causes too many warnings.
Therefore simply remove the warning on rendered pages.

The escape button will remain available and it is present on the view
source page.

Fix #20999

Signed-off-by: Andrew Thornton <art27@cantab.net>
 2022-12-03 23:47:00 +08:00
Xinyu Zhou
181f4bfdb1
docs: add Edit this page (#21981) 
Update theme to support `Edit this page`:
https://gitea.com/gitea/theme/pulls/116

Screenshot:
![Edit this
page](https://user-images.githubusercontent.com/76462613/205257167-d6039d0c-c913-4ebc-98c1-834aece4b5e9.png)

Signed-off-by: Xinyu Zhou <i@sourcehut.net>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-03 19:51:53 +08:00
Lunny Xiao
0a7d3ff786
refactor some functions to support ctx as first parameter (#21878) 
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-12-03 10:48:26 +08:00
Chongyi Zheng
8698458f48
Remove deprecated packages & staticcheck fixes (#22012) 
`ioutil` is deprecated and should use `io` instead
 2022-12-02 17:06:23 -05:00
xtexChooser
21bcb92926
Add pnpm to packages/overview (#22008) 
[`pnpm`](https://pnpm.io/) is a "fast, disk space efficient" node
package manager.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-02 11:23:47 -05:00
flynnnnnnnnnn
350bc83d00
Update to Alpine 3.17 (#21904) 
This pull request is for updating the base docker images to build with
the latest version of Alpine.
 2022-12-02 11:23:26 -05:00
Jason Song
f59a74852b
Update gitea-vet to check FSFE REUSE (#22004) 
Related to:
- #21840
- https://gitea.com/gitea/gitea-vet/pulls/21

What it looks like when it's working:
https://drone.gitea.io/go-gitea/gitea/64040/1/5

All available SPDX license identifiers: [SPDX License
List](https://spdx.org/licenses/).

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-02 22:14:57 +08:00
silverwind
d64063277d
Multiple improvements for comment edit diff (#21990) 
- Use explicit avatar size so when JS copies the HTML, the size gets
copied with it
- Replace icon font use with SVG
- Improve styling and diff rendering
- Sort lists in `svg.js`

Fixes: https://github.com/go-gitea/gitea/issues/21924

<img width="933" alt="Screenshot 2022-11-30 at 17 52 17"
src="https://user-images.githubusercontent.com/115237/204859608-f322a8f8-7b91-45e4-87c0-82694e574115.png">

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 2022-12-02 11:42:34 +02:00
Lunny Xiao
df676a47d0
Remove session in api tests (#21984) 
It's no meaning to request an API route with session.
 2022-12-01 22:39:42 -05:00
Mark Ormesher
665d02efaf
Remove duplicate "Actions" label in mobile view (#21974) 
Closes #21973.

The "Actions" button on the commit view page is labelled twice in mobile
view. No other buttons on the page have a `mobile-only` extra label, so
this PR removes it.

Before:


![before](https://user-images.githubusercontent.com/6496999/204540002-75baa08a-6c06-4b39-847b-34272e09d71e.PNG)

After:


![after](https://user-images.githubusercontent.com/6496999/204539991-a0607765-d5e2-4b1a-84c9-a3e16cbc674e.PNG)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-01 22:39:19 -05:00
Lunny Xiao
f7ade6de7c
Fix generate index failure possibility on postgres (#21998) 
@wxiaoguang Please review

Co-authored-by: silverwind <me@silverwind.io>
 2022-12-02 11:15:36 +08:00
zeripath
64973cf18f
Use path not filepath in template filenames (#21993) 
Paths in git are always separated by `/` not `\` - therefore we should
`path` and not `filepath`

Fix #21987

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-12-02 07:56:51 +08:00
silverwind
f0bd219a5e
Update chroma to v2.4.0 (#22000) 
Did a few cursory tests, seems to work well.
 2022-12-01 16:44:38 -05:00
Jason Song
f9cbf5a1bc
Util type to parse ref name (#21969) 
Provide a new type to make it easier to parse a ref name.

Actually, it's picked up from #21937, to make the origin PR lighter.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2022-12-01 19:56:04 +08:00
Jason Song
4e5d4d0073
Skip initing LFS storage if disabled (#21996) 
A complement to #21985.

I overlooked it because the name of the switch is `StartServer`, not
`Enabled`. I believe the weird name is a legacy, but renaming is out of
scope.
 2022-12-01 11:02:04 +02:00
Lunny Xiao
b2c4870481
Fix parallel creating commit status bug with tests (#21911) 
This PR is a follow up of #21469

Co-authored-by: Lauris BH <lauris@nix.lv>
 2022-12-01 00:41:49 +08:00
Jason Song
67881ae99a
Skip initing disabled storages (#21985) 
If `Attachment` or `Packages` are disabled, we don't have to init the
storages for them.
 2022-11-30 21:39:02 +08:00
花墨
7020c4afb7
Fix leaving organization bug on user settings -> orgs (#21983) 
Fix #21772

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2022-11-30 17:00:00 +08:00
luzpaz
fdfd77f478
Fix typos (#21979) 
Found via codespell
 2022-11-29 18:41:29 -06:00
Saswat Padhi
715cf46dc4
Normalize AppURL according to RFC 3986 (#21950) 
Fixes #21865.

Scheme-based normalization ([RFC 3986, section
6.2.3](https://www.rfc-editor.org/rfc/rfc3986#section-6.2.3)) was
already implemented, but only for `defaultAppURL`.
This PR implements the same for `AppURL`.

Signed-off-by: Saswat Padhi <saswatpadhi@protonmail.com>
Co-authored-by: John Olheiser <john.olheiser@gmail.com>
 2022-11-29 15:30:47 +08:00
Jason Song
f047ee0a40
Use random bytes to generate access token (#21959) 2022-11-28 23:37:42 +08:00
Jason Song
9607750b5e
Replace fmt.Sprintf with hex.EncodeToString (#21960) 
`hex.EncodeToString` has better performance than `fmt.Sprintf("%x",
[]byte)`, we should use it as much as possible.

I'm not an extreme fan of performance, so I think there are some
exceptions:

- `fmt.Sprintf("%x", func(...)[N]byte())`
- We can't slice the function return value directly, and it's not worth
adding lines.
    ```diff
    func A()[20]byte { ... }
    - a := fmt.Sprintf("%x", A())
    - a := hex.EncodeToString(A()[:]) // invalid
    + tmp := A()
    + a := hex.EncodeToString(tmp[:])
    ```
- `fmt.Sprintf("%X", []byte)`
- `strings.ToUpper(hex.EncodeToString(bytes))` has even worse
performance.
 2022-11-28 11:19:18 +00:00