16332 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
silverwind	88479e0dfc	Update JS dependencies (#26449) ... - Update all JS dependencies - Tested Monaco and Swagger	2023-08-11 00:29:15 +00:00
wxiaoguang	f42cd4561b	Call git.InitSimple for runRepoSyncReleases (#26396) ... Fix #26394 Otherwise, the git module is not initialized and it doesn't respect the "timeout" config in app.ini	2023-08-10 22:42:48 +00:00
techknowlogick	bfef7d4735	Target specific OS for devcontainer base image (#26422) ... fixes #25842 credit to philippbeckmann for discovering this	2023-08-10 21:57:29 +00:00
silverwind	1772814605	Lock go to 1.21 on CI (#26433) ... To prevent unwanted surprises with new minor versions of go, lock the version to minor version using [semver tilde syntax](https://github.com/npm/node-semver#tilde-ranges-123-12-1). We were already getting 1.21.0 since yesterday, so use that version now as minimum.	2023-08-10 21:53:44 +00:00
Panagiotis "Ivory" Vasilopoulos	2cbd377e1f	Always show usernames in reaction tooltips (#26444) ... Even if GetDisplayName() is normally preferred elsewhere, this change provides more consistency, as usernames are also always being shown when participating in a conversation taking place in an issue or a pull request. This change makes conversations easier to follow, as you would not have to have a mental association between someone's username and someone's real name in order to follow what is happening. This behavior matches GitHub's. Optimally, both the username and the full name (if applicable) could be shown, but such an effort is a much bigger task that needs to be thought out well.	2023-08-10 21:20:01 +00:00
CaiCandong	7a69d71733	Fix incorrect redirection in new issue using references (#26440) ... fix #26427 related https://github.com/go-gitea/gitea/pull/25258 --- Before:  --- After: 	2023-08-10 20:04:08 +00:00
yp05327	918d0f033d	Fix the display of orgs listed in user profile (#26424) ... Before:  After:  In #26214, we changed each row's display into `flex` which caused this problem.   In old version:  Maybe we can add paddings here?  In old version; 	2023-08-11 03:28:36 +08:00
nekrondev	3c91b09c19	minio: add missing region on client initialization (#26412) ... The MinIO client isn't redirecting to the correct AWS endpoint if a non-default data center is used. In my use case I created an AWS bucket at `eu-central-1` region. Because of the missing region initialization of the client the default `us-east-1` API endpoint is used returning a `301 Moved Permanently` response that's not handled properly by MinIO client. This in return aborts using S3 storage on AWS as the `BucketExists()` call will fail with the http moved error. MinIO client trace shows the issue: ```text ---------START-HTTP--------- HEAD / HTTP/1.1 Host: xxxxxxxxxxx-prod-gitea-data.s3.dualstack.us-east-1.amazonaws.com User-Agent: MinIO (windows; amd64) minio-go/v7.0.61 Authorization: AWS4-HMAC-SHA256 Credential=**REDACTED**/20230809/accesspoint.eu-central-1/s3/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=**REDACTED** X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 X-Amz-Date: 20230809T141143Z HTTP/1.1 301 Moved Permanently Connection: close Content-Type: application/xml Date: Wed, 09 Aug 2023 14:11:43 GMT Server: AmazonS3 X-Amz-Bucket-Region: eu-central-1 X-Amz-Id-2: UK7wfeYi0HcTcytNvQ3wTAZ5ZP1mOSMnvRZ9Fz4xXzeNsS47NB/KfFx2unFxo3L7XckHpMNPPVo= X-Amz-Request-Id: S1V2MJV8SZ11GEVN ---------END-HTTP--------- ``` Co-authored-by: Heiko Besemann <heiko.besemann@qbeyond.de>	2023-08-10 11:21:09 +00:00
Lunny Xiao	e7cbb0e7c9	Fix wrong middleware sequence (#26428)	2023-08-10 12:51:46 +02:00
wxiaoguang	a370efc13f	Use template context function for avatar rendering (#26385) ... Introduce `AvatarUtils`, no need to pass `$.Context` to every sub-template, and simplify the template helper functions.	2023-08-10 11:19:39 +08:00
Lunny Xiao	36eb3c433a	Add transaction when creating pull request created dirty data (#26259) ... Fix #26129 Replace #26258 This PR will introduce a transaction on creating pull request so that if some step failed, it will rollback totally. And there will be no dirty pull request exist. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-10 02:39:21 +00:00
wxiaoguang	a85a862804	Fix admin queue page title (#26409) ... Fix #26408 ``` # locale_en-US.ini [admin] monitor.queues = Queues ``` --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-10 02:05:37 +00:00
Denys Konovalov	63ab92d797	Pre-register OAuth2 applications for git credential helpers (#26291) ... This PR is an extended implementation of #25189 and builds upon the proposal by @hickford in #25653, utilizing some ideas proposed internally by @wxiaoguang. Mainly, this PR consists of a mechanism to pre-register OAuth2 applications on startup, which can be enabled or disabled by modifying the `[oauth2].DEFAULT_APPLICATIONS` parameter in app.ini. The OAuth2 applications registered this way are being marked as "locked" and neither be deleted nor edited over UI to prevent confusing/unexpected behavior. Instead, they're being removed if no longer enabled in config.  The implemented mechanism can also be used to pre-register other OAuth2 applications in the future, if wanted. Co-authored-by: hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> --------- Co-authored-by: M Hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-09 14:24:07 +02:00
CaiCandong	d41aee1d1e	Make user-content-* consistent with github (#26388) ... Fix #26367 Related #19745 Thanks @lazyky for providing test cases	2023-08-09 09:30:31 +00:00
Yarden Shoham	220f236ff5	Add pull request review request webhook event (#26401) ... Add webhook events for pull request review requests - Fixes #26371 - Added support for the "Pull request review requested" and "Pull request review request removed" webhook events. - Updated the `getPullRequestPayloadInfo` function in `general.go` to handle these new webhook events. # Before  # After  Signed-off-by: Yarden Shoham <git@yardenshoham.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-09 10:30:34 +02:00
wxiaoguang	c2e0143bfe	Introduce ctx.PathParamRaw to avoid incorrect unescaping (#26392) ... Fix #26389 And complete an old TODO: `ctx.Params does un-escaping,..., which is incorrect.`	2023-08-09 14:57:45 +08:00
GiteaBot	906e253d5e	[skip ci] Updated translations via Crowdin	2023-08-09 00:26:05 +00:00
FuXiaoHei	ad69f7175a	fix artifact merging chunks path with correct slash on Windows (#26400) ... From Discord https://discord.com/channels/322538954119184384/1069795723178160168/1136719889684500480 Artifact chunks merging is break on Windows. ``` Gitea Log: 2023/08/03 20:51:15 ...actions/artifacts.go:271:comfirmUploadArtifact() [E] Error merge chunks: parse content range error: input does not match format ``` Artifact uses wrong slash to parse saved chunks path.	2023-08-08 17:21:48 +00:00
KN4CK3R	e6f8e9318b	Use flex classes in package settings (#26314) ... Regression of #25790 Fixes #26310 --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-08 18:28:24 +02:00
Panagiotis "Ivory" Vasilopoulos	daf7092863	Improve multiple strings in en-US locale (#26213) ... I kept sending pull requests that consisted of one-line changes. It's time to settle this once and for all. (Maybe.) - Explain Gitea behavior and the consequences of each setting better, so that the user does not have to consult the docs. - Do not use different spellings of identical terms interchangeably, e.g. `e-mail` and `email`. - Use more conventional terms to describe the same things, e.g. `Confirm Password` instead of `Re-Type Password`. - Introduces additional clarification for Mirror Settings - Small adjustments in test - This is a cry for help. - Grammar and spelling consistencies for en-US locale (e.g. cancelled -> canceled) - Introduce tooltip improvements. --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-08 15:25:05 +00:00
wxiaoguang	4fc4f6e634	Refactor "editorconfig" (#26391) ... There are 2 kinds of ".Editorconfig" in code, one is `JSON string` for the web edtior, another is `*editorconfig.Editorconfig` for the file rendering (used by `TabSizeClass`) This PR distinguish them with different names. And by the way, change the default tab size from 8 to 4, I think few people would like to use 8-size tabs nowadays.	2023-08-08 10:44:19 +00:00
Earl Warren	20f47bbca9	fix generated source URL on rendered files (#26364) ... - The permalink and 'Reference in New issue' URL of an renderable file (those where you can see the source and a rendered version of it, such as markdown) doesn't contain `?display=source`. This leads the issue that the URL doesn't have any effect, as by default the rendered version is shown and thus not the source. - Add `?display=source` to the permalink URL and to 'Reference in New Issue' if it's renderable file. - Add integration testing. Refs: https://codeberg.org/forgejo/forgejo/pulls/1088 Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-08 09:04:04 +00:00
wxiaoguang	71d253f42e	Remove unnecessary template helper DisableGravatar (#26386) ... And one "AllowedUserVisibilityModes" was missing, add it. Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-08 08:29:14 +00:00
wxiaoguang	78b2a1cc36	Remove unnecessary template helper repoAvatar (#26387) ... And simplify the "repo/icon" code	2023-08-08 15:29:35 +08:00
wxiaoguang	6913053223	Start using template context function (#26254) ... Before: * `{{.locale.Tr ...}}` * `{{$.locale.Tr ...}}` * `{{$.root.locale.Tr ...}}` * `{{template "sub" .}}` * `{{template "sub" (dict "locale" $.locale)}}` * `{{template "sub" (dict "root" $)}}` * ..... With context function: only need to `{{ctx.Locale.Tr ...}}` The "ctx" could be considered as a super-global variable for all templates including sub-templates. To avoid potential risks (any bug in the template context function package), this PR only starts using "ctx" in "head.tmpl" and "footer.tmpl" and it has a "DataRaceCheck". If there is anything wrong, the code can be fixed or reverted easily.	2023-08-08 01:22:47 +00:00
KN4CK3R	0c6ae61229	Allow package cleanup from admin page (#25307) ... Until now expired package data gets deleted daily by a cronjob. The admin page shows the size of all packages and the size of unreferenced data. The users (#25035, #20631) expect the deletion of this data if they run the cronjob from the admin page but the job only deletes data older than 24h. This PR adds a new button which deletes all expired data.  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-08 00:46:10 +00:00
Maxim Slipenko	c2b6897e35	Fix text truncate (#26354) ... Fixes: https://github.com/go-gitea/gitea/issues/25597 Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-07 22:44:04 +02:00
CaiCandong	3a42743b3a	Fix incorrect sort link with .profile repository (#26374) ... fix #26360	2023-08-07 19:59:17 +00:00
Lunny Xiao	f5dbac9d36	Use more IssueList instead of []*Issue (#26369)	2023-08-07 19:26:40 +00:00
cassiozareck	ab0eb1c47b	Rename code_langauge.go to code_language.go (#26377)	2023-08-07 15:00:53 -04:00
delvh	a5d8f95550	Add changelog for 1.20.3 (#26373)	2023-08-07 18:11:33 +02:00
Earl Warren	87f70979cf	Do not highlight #number in documents (#26365) ... - Currently the post processing will transform all issue indexes (such as `#6`) into a clickable link. - This makes sense in an situation like issues or PRs, where referencing to other issues is quite common and only referencing their issue index is an handy and efficient way to do it. - Currently this is also run for documents (which is the user profile and viewing rendered files), but in those situations it's less common to reference issues by their index and instead could mean something else. - This patch disables this post processing for issue index for documents. Matches Github's behavior. - Added unit tests. - Resolves https://codeberg.org/Codeberg/Community/issues/1120 Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-08-07 15:11:25 +02:00
wxiaoguang	e4b1ea6f15	Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex (#26279) ... Close #26277 Fix #26285	2023-08-07 12:23:59 +02:00
CaiCandong	24fbf4e059	Fix nil pointer dereference error when open link with invalid pull index (#26353) ... fix #26331 Before:  After: 	2023-08-07 11:43:18 +08:00
GiteaBot	049e400327	[skip ci] Updated licenses and gitignores	2023-08-07 00:27:21 +00:00
delvh	8736b134bd	Display human-readable text instead of cryptic filemodes (#26352) ... Now, you don't need to be a git expert anymore to know what these numbers mean. ## Before  ## After  or when the mode actually changed: 	2023-08-06 21:52:34 +02:00
Track3	c1c83dbaec	[docs] Add missing backtick in quickstart.zh-cn.md (#26349) ... Added missing backtick in quickstart.zh-cn.md docs so inline code can render properly. Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-06 00:28:25 +08:00
wxiaoguang	d92b4cd093	Fix incorrect CLI exit code and duplicate error message (#26346) ... Follow the CLI refactoring, and add tests.	2023-08-05 23:36:45 +08:00
wxiaoguang	4f513474dc	Improve CLI and messages (#26341) ... Follow the CLI refactoring 1. Remove the "checkCommandFlags" helper 2. Unify the web startup message, make them have consistent names as `./gitea help` 3. Fine tune some other messages (see the diff)	2023-08-05 13:24:49 +00:00
Lunny Xiao	ecb04cc324	Remove backslashed newlines on markdown (#26344) ... Fix https://gitea.com/gitea/gitea-docusaurus/issues/56	2023-08-05 12:48:46 +00:00
CaiCandong	9ac6bb053c	Hide last indexed SHA when a repo could not be indexed yet (#26340) ... Now, for a new repo without any commit, the Last indexed SHA field looks like this: Before:  After:  Fixes #26336	2023-08-05 13:04:14 +02:00
cassiozareck	952882fe4a	Fix log typo in task.go (#26337) ... Signed-off-by: cassiozareck <cassiomilczareck@gmail.com>	2023-08-05 11:43:03 +02:00
KN4CK3R	2d3924d0e7	Prevent newline errors with Debian packages (#26332) ... Fixes #26313	2023-08-05 10:59:52 +02:00
Zettat123	9a8af92577	Fix the bug when getting files changed for pull_request_target event (#26320) ... Follow #25229 Copy from https://github.com/go-gitea/gitea/pull/26290#issuecomment-1663135186 The bug is that we cannot get changed files for the `pull_request_target` event. This event runs in the context of the base branch, so we won't get any changes if we call `GetFilesChangedSinceCommit` with `PullRequest.Base.Ref`.	2023-08-05 14:26:06 +08:00
wxiaoguang	5db4c8db93	Refactor backend SVG package and add tests (#26335) ... Introduce a well-tested `svg.Normalize` function. Make `RenderHTML` faster and more stable.	2023-08-05 04:34:59 +00:00
Lunny Xiao	12c249c5ca	Fix bug with sqlite load read (#26305) ... Possible fix #26280	2023-08-05 10:40:27 +08:00
yp05327	e5011a0e6d	Remove commit load branches and tags in wiki repo (#26304) ... If click `load branches and tags`, you will get 500 error from backend, as it is a wiki repo.   Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 15:49:43 +00:00
yp05327	945a0cb96b	Add highlight to selected repos in milestone dashboard (#26300) ... Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 15:16:56 +00:00
Nicholas Pease	6a7a5ea32a	Do not show Profile README when repository is private (#26295) ... As mentioned in the original thread (#23260) and in the enhancements PR #24753, this PR ensures the .profile repository is public before the README file is shown. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 14:45:33 +00:00
yp05327	30eae5a40c	Fix incorrect color of selected assignees when create issue (#26324) ... Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-04 14:14:30 +00:00