wanderer/gitea
1
0
Fork 0
forked from mirror/gitea
Code Issues Pull Requests Releases Activity

when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates (#16762)

Browse Source
This commit is contained in:
wxiaoguang 2021-08-21 21:04:47 +08:00 committed by GitHub
parent 0bd58d61e5
commit 06f82641cb
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
routers/web/repo/issue.go
View File

@ -1727,9 +1727,12 @@ func UpdateIssueContent(ctx *context.Context) {
return
}
if err := updateAttachments(issue, ctx.FormStrings("files[]")); err != nil {
ctx.ServerError("UpdateAttachments", err)
return
// when update the request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates
if !ctx.FormBool("ignore_attachments") {
if err := updateAttachments(issue, ctx.FormStrings("files[]")); err != nil {
ctx.ServerError("UpdateAttachments", err)
return
}
}
content, err := markdown.RenderString(&markup.RenderContext{
@ -2148,10 +2151,6 @@ func UpdateCommentContent(ctx *context.Context) {
return
}
if ctx.FormBool("ignore_attachments") {
return
}
if comment.Type == models.CommentTypeComment {
if err := comment.LoadAttachments(); err != nil {
ctx.ServerError("LoadAttachments", err)
@ -2159,9 +2158,12 @@ func UpdateCommentContent(ctx *context.Context) {
}
}
if err := updateAttachments(comment, ctx.FormStrings("files[]")); err != nil {
ctx.ServerError("UpdateAttachments", err)
return
// when the update request doesn't intend to update attachments (eg: change checkbox state), ignore attachment updates
if !ctx.FormBool("ignore_attachments") {
if err := updateAttachments(comment, ctx.FormStrings("files[]")); err != nil {
ctx.ServerError("UpdateAttachments", err)
return
}
}
content, err := markdown.RenderString(&markup.RenderContext{