wanderer/drone-kaniko
1
1
Fork 0
Code Issues 1 Pull Requests Projects Releases Activity

Fix the broken link in readme (#38)

Browse Source
This commit is contained in:
Sinkerine 2022-02-10 05:06:36 -08:00 committed by GitHub
parent de43f3afb6
commit c38eb07dea
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -86,7 +86,7 @@ docker run --rm \
``` ```
### Auto Tagging ### Auto Tagging
The [auto tag feature](https://plugins.drone.io/drone-plugins/drone-docker/** of docker plugin is also supported. The [auto tag feature](https://plugins.drone.io/drone-plugins/drone-docker) of docker plugin is also supported.
When auto tagging is enabled, if any of the case is matched below, a docker build will be pushed with auto generated tags. Otherwise the docker build will be skipped. When auto tagging is enabled, if any of the case is matched below, a docker build will be pushed with auto generated tags. Otherwise the docker build will be skipped.

2
kaniko.go
View File

@ -106,7 +106,7 @@ func (b Build) AutoTags() (tags []string, err error) {
// user specified at the same time. Starts to auto detect tags. // user specified at the same time. Starts to auto detect tags.
// Note: passing in a "latest" tag with auto-tag enabled won't trigger the // Note: passing in a "latest" tag with auto-tag enabled won't trigger the
// early returns above, because we cannot tell if the tag is provided by // early returns above, because we cannot tell if the tag is provided by
// the default value of by the users. // the default value or by the users.
commitRef := b.DroneCommitRef commitRef := b.DroneCommitRef
if !tagger.UseAutoTag(commitRef, b.DroneRepoBranch) { if !tagger.UseAutoTag(commitRef, b.DroneRepoBranch) {
err = fmt.Errorf("Could not auto detect the tag. Skipping automated docker build for commit %s", commitRef) err = fmt.Errorf("Could not auto detect the tag. Skipping automated docker build for commit %s", commitRef)

4
kaniko_test.go
View File

@ -126,7 +126,7 @@ func TestBuild_AutoTags(t *testing.T) {
} }
}) })
} }
t.Run("flag conflict", func(t *testing.T) { t.Run("auto-tag cannot be enabled with user provided tags", func(t *testing.T) {
b := Build{ b := Build{
DroneCommitRef: "refs/tags/v1.0.0", DroneCommitRef: "refs/tags/v1.0.0",
DroneRepoBranch: "master", DroneRepoBranch: "master",
@ -135,7 +135,7 @@ func TestBuild_AutoTags(t *testing.T) {
} }
_, err := b.AutoTags() _, err := b.AutoTags()
if err == nil { if err == nil {
t.Errorf("Expect flag conflict error") t.Errorf("Expect error for invalid flags")
} }
}) })
} }