mirror/ ultrajson
1
0
Fork 0
mirror of https://github.com/ultrajson/ultrajson.git synced 2024-05-05 16:06:17 +02:00
Code Issues

Fix undefined behavior in Buffer_AppendLongUnchecked (#606) 

This was flagged when running with UBSAN
This commit is contained in:
William Ayd 2023-10-01 18:41:23 -04:00 committed by GitHub
parent a967539cdc
commit 0959d18cfa
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/ultrajsonenc.c
View File

@ -42,6 +42,7 @@ https://opensource.apple.com/source/tcl/tcl-14/tcl/license.terms
#include <string.h>
#include <stdlib.h>
#include <stddef.h>
#include <stdint.h>
#include <math.h>
#include <float.h>
@ -584,7 +585,13 @@ static void Buffer_AppendIndentUnchecked(JSONObjectEncoder *enc, JSINT32 value)
static void Buffer_AppendLongUnchecked(JSONObjectEncoder *enc, JSINT64 value)
{
char* wstr;
JSUINT64 uvalue = (value < 0) ? -value : value;
JSUINT64 uvalue;
if (value == INT64_MIN) {
uvalue = INT64_MAX + UINT64_C(1);
} else {
uvalue = (value < 0) ? -value : value;
}
wstr = enc->offset;
#ifdef DEBUG