1
1
mirror of https://git.sr.ht/~emersion/tlstunnel synced 2024-11-19 15:53:50 +01:00

Don't try to guess listening address

Always listen on all hosts. Only use the host part of a frontend
address for TLS cert names.

Customizing the listen host will be better done with a `bind`
directive, like Caddy does.
This commit is contained in:
Simon Ser 2020-09-12 13:41:11 +02:00
parent fd46214036
commit 18dd507ea5
No known key found for this signature in database
GPG Key ID: 0FDE7BE0E88F5E48
2 changed files with 9 additions and 13 deletions

@ -38,25 +38,21 @@ func parseFrontend(srv *Server, d *Directive) error {
return err
}
for _, listenAddr := range d.Params {
host, port, err := net.SplitHostPort(listenAddr)
for _, addr := range d.Params {
host, port, err := net.SplitHostPort(addr)
if err != nil {
return fmt.Errorf("failed to parse listen address %q: %v", listenAddr, err)
return fmt.Errorf("failed to parse frontend address %q: %v", addr, err)
}
// TODO: come up with something more robust
var name string
if host != "" && host != "localhost" && net.ParseIP(host) == nil {
name = host
host = ""
srv.ManagedNames = append(srv.ManagedNames, name)
if host != "" {
srv.ManagedNames = append(srv.ManagedNames, host)
}
addr := net.JoinHostPort(host, port)
// TODO: allow to customize listen host
addr := net.JoinHostPort("", port)
ln := srv.RegisterListener(addr)
if err := ln.RegisterFrontend(name, frontend); err != nil {
if err := ln.RegisterFrontend(host, frontend); err != nil {
return err
}
}