mirror/tea
1
1
Fork 0
mirror of https://gitea.com/gitea/tea synced 2024-11-23 00:12:05 +01:00
Code Issues

Improve error messages (#370)

Browse Source 
fixes #367

Co-authored-by: Norwin Roosen <git@nroo.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Reviewed-on: https://gitea.com/gitea/tea/pulls/370
Reviewed-by: 6543 <6543@obermui.de>
Reviewed-by: KN4CK3R <kn4ck3r@noreply.gitea.io>
Co-authored-by: Norwin <noerw@noreply.gitea.io>
Co-committed-by: Norwin <noerw@noreply.gitea.io>
This commit is contained in:
Norwin 2021-07-03 22:39:05 +08:00 committed by 6543
parent 64770a771f
commit 2bdd72dfff
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
modules/context/context.go
View File

@ -123,8 +123,16 @@ func InitCommand(ctx *cli.Context) *TeaContext {
} }
} else if c.Login == nil { } else if c.Login == nil {
if c.Login, err = config.GetDefaultLogin(); err != nil { if c.Login, err = config.GetDefaultLogin(); err != nil {
log.Fatal(err.Error()) if err.Error() == "No available login" {
// TODO: maybe we can directly start interact.CreateLogin() (only if
// we're sure we can interactively!), as gh cli does.
fmt.Println(`No gitea login configured. To start using tea, first run
tea login add
and then run your command again.`)
}
os.Exit(1)
} }
fmt.Printf("NOTE: no gitea login detected, falling back to login '%s'\n", c.Login.Name)
} }
// parse reposlug (owner falling back to login owner if reposlug contains only repo name) // parse reposlug (owner falling back to login owner if reposlug contains only repo name)

2
modules/task/pull_checkout.go
View File

@ -28,7 +28,7 @@ func PullCheckout(
client := login.Client() client := login.Client()
pr, _, err := client.GetPullRequest(repoOwner, repoName, index) pr, _, err := client.GetPullRequest(repoOwner, repoName, index)
if err != nil { if err != nil {
return err return fmt.Errorf("couldn't fetch PR: %s", err)
} }
if err := workaround.FixPullHeadSha(client, pr); err != nil { if err := workaround.FixPullHeadSha(client, pr); err != nil {
return err return err