mirror of
https://github.com/swaywm/sway
synced 2024-11-18 04:33:59 +01:00
701fcafc70
The original purpose of this commit is to replace some for loops with list_find. But while doing this I found the workspace_prev_next_impl functions to be difficult to read and also contained a bug, so I refactored them and fixed the bug. To reproduce the bug: * Have two outputs, where the left output has workspaces 1, 2, 3 and the right output has workspaces 4, 5, 6. Make workspace 2 focused_inactive and workspace 4 focused. * Run `workspace prev`. * Previously it would visit the left output, then apply `workspace prev` to workspace 2, which focuses workspace 1. * Now it will focus the rightmost workspace on the left output (workspace 3). The refactoring I made to the workspace functions are: * Added the static keyword. * They now accept an int dir rather than bool, to avoid an unnecessary conversion. * Rather than preparing start and end variables for the purpose of iterating, just iterate everything. * Replace for loops with list_find. * Don't call workspace_output_prev_next_impl (this fixes the bug).
31 lines
1.2 KiB
C
31 lines
1.2 KiB
C
#ifndef _SWAY_LIST_H
|
|
#define _SWAY_LIST_H
|
|
|
|
typedef struct {
|
|
int capacity;
|
|
int length;
|
|
void **items;
|
|
} list_t;
|
|
|
|
list_t *create_list(void);
|
|
void list_free(list_t *list);
|
|
void list_foreach(list_t *list, void (*callback)(void* item));
|
|
void list_add(list_t *list, void *item);
|
|
void list_insert(list_t *list, int index, void *item);
|
|
void list_del(list_t *list, int index);
|
|
void list_cat(list_t *list, list_t *source);
|
|
// See qsort. Remember to use *_qsort functions as compare functions,
|
|
// because they dereference the left and right arguments first!
|
|
void list_qsort(list_t *list, int compare(const void *left, const void *right));
|
|
// Return index for first item in list that returns 0 for given compare
|
|
// function or -1 if none matches.
|
|
int list_seq_find(list_t *list, int compare(const void *item, const void *cmp_to), const void *cmp_to);
|
|
int list_find(list_t *list, const void *item);
|
|
// stable sort since qsort is not guaranteed to be stable
|
|
void list_stable_sort(list_t *list, int compare(const void *a, const void *b));
|
|
// swap two elements in a list
|
|
void list_swap(list_t *list, int src, int dest);
|
|
// move item to end of list
|
|
void list_move_to_end(list_t *list, void *item);
|
|
#endif
|