1
1
mirror of https://github.com/swaywm/sway synced 2024-11-19 03:24:39 +01:00
sway/common
Ryan Dwyer 701fcafc70 Use list_find in more places and refactor/fix workspace prev_next functions
The original purpose of this commit is to replace some for loops with
list_find. But while doing this I found the workspace_prev_next_impl
functions to be difficult to read and also contained a bug, so I
refactored them and fixed the bug.

To reproduce the bug:

* Have two outputs, where the left output has workspaces 1, 2, 3 and the
right output has workspaces 4, 5, 6. Make workspace 2 focused_inactive
and workspace 4 focused.
* Run `workspace prev`.
* Previously it would visit the left output, then apply `workspace prev`
to workspace 2, which focuses workspace 1.
* Now it will focus the rightmost workspace on the left output
(workspace 3).

The refactoring I made to the workspace functions are:

* Added the static keyword.
* They now accept an int dir rather than bool, to avoid an unnecessary
conversion.
* Rather than preparing start and end variables for the purpose of
iterating, just iterate everything.
* Replace for loops with list_find.
* Don't call workspace_output_prev_next_impl (this fixes the bug).
2018-08-15 15:14:35 +10:00
..
background-image.c
cairo.c
ipc-client.c ipc-client: fix memory leaks in get_socketpath 2018-08-06 17:30:24 +01:00
list.c Use list_find in more places and refactor/fix workspace prev_next functions 2018-08-15 15:14:35 +10:00
log.c
meson.build
pango.c
readline.c
stringop.c
unicode.c
util.c