mirror/sway
1
1
Fork 0
mirror of https://github.com/swaywm/sway synced 2024-11-23 17:32:40 +01:00
Code Issues

swaynag: remove double free of details button

Browse Source 
If there are no arguments or invalid arguments given, swaynag will free
`swaynag.details.button_details` under the `cleanup` label in main. It
then called `swaynag_destroy`, which would attempt to free it again.

Since `swaynag.details.button_details` is either freed on line 106 of
main (when there is no detailed message) or added to `swaynag.buttons`
on line 103 of main, there is no reason to manually free it in
`swaynag_destroy`.

Although I cannot reproduce a double free on my system, for some reason,
it should have actually resulted in a double free in all code paths.
This commit is contained in:
Brian Ashworth 2018-12-17 00:54:00 -05:00 committed by emersion
parent 8d7ebc258a
commit eb527ac01a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
swaynag/swaynag.c
View File

@ -416,7 +416,6 @@ void swaynag_destroy(struct swaynag *swaynag) {
free(button);
}
list_free(swaynag->buttons);
free(swaynag->details.button_details);
free(swaynag->details.message);
free(swaynag->details.button_up.text);
free(swaynag->details.button_down.text);