mirror/sway
1
1
Fork 0
mirror of https://github.com/swaywm/sway synced 2024-11-05 18:49:41 +01:00
Code Issues

Merge pull request #2370 from RyanDwyer/transactions-use-after-free

Browse Source 
Fix use after free in transactions
This commit is contained in:
Brian Ashworth 2018-07-28 01:31:43 -04:00 committed by GitHub
commit 92a4bc646a
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sway/desktop/transaction.c
View File

@ -364,7 +364,13 @@ static void set_instructions_ready(struct sway_view *view, int index) {
struct sway_transaction_instruction *instruction = struct sway_transaction_instruction *instruction =
view->swayc->instructions->items[i]; view->swayc->instructions->items[i];
if (!instruction->ready) { if (!instruction->ready) {
// set_instruction_ready can remove instructions from the list we're
// iterating
size_t length = view->swayc->instructions->length;
set_instruction_ready(instruction); set_instruction_ready(instruction);
size_t num_removed = length - view->swayc->instructions->length;
i -= num_removed;
index -= num_removed;
} }
} }
} }