mirror/ rustlings
1
0
Fork 0
mirror of https://github.com/rust-lang/rustlings.git synced 2024-05-25 17:36:11 +02:00
Code Issues
599 Commits 3 Branches 39 Tags 30 MiB
Commit Graph

599 Commits

Author SHA1 Message Date
Anastasis Georgoulas a09f684f05 fix(strings2): update line number in hint 2019-11-13 23:23:34 +00:00
ageorgou 8cc5af121c
Fix(functions4): Update line number in hint 2019-11-12 23:49:19 +00:00
Chris Keschnat c42c3b2101
fix(arc1): Fix some words in the comment 2019-11-12 18:37:23 +01:00
Chris Keschnat fda5a47069 fix(variables1): Correct wrong word in comment 2019-11-12 17:33:25 +01:00
marisa 57a837bde6
Merge pull request #236 from jrvidal/master 
fix(primitive_types4): update outdated comment
 2019-11-12 13:00:28 +01:00
Roberto Vidal ded2c034ba fix(primitive_types4): update outdated comment 2019-11-12 12:52:28 +01:00
marisa eac07df96c 2.0.0 2019-11-12 12:24:30 +01:00
bors 8c1376df07 Auto merge of #235 - rust-lang:fmoko-patch-1, r=fmoko 
fix(default): Clarify the installation procedure
 2019-11-12 11:13:06 +00:00
bors 45d68d9b39 Auto merge of #232 - rust-lang:update-docs, r=fmoko 
chore: Update docs for 2.0

Only merge this once we're ready to release 2.0.
 2019-11-12 11:07:56 +00:00
marisa c371b853af
fix(default): Clarify the installation procedure 2019-11-12 11:53:58 +01:00
bors bc32a63c69 Auto merge of #234 - jrvidal:no-prompt-on-run, r=fmoko 
fix(run): makes `run` never prompt

`watch` and `verify` do prompt the user to actively move to the
next exercise. This change fixes `run` to never prompt. Previously
it was inconsistent between "test" and "compile" exercises.

BREAKING CHANGE: we again change the behavior of the `run` command
 2019-11-12 10:50:19 +00:00
Roberto Vidal 4b26546589 fix(run): makes `run` never prompt 
`watch` and `verify` do prompt the user to actively move to the
next exercise. This change fixes `run` to never prompt. Previously
it was inconsistent between "test" and "compile" exercises.

BREAKING CHANGE: we again change the behavior of the `run` command
 2019-11-12 11:35:40 +01:00
bors bc56788fe6 Auto merge of #233 - jrvidal:rustc-check, r=fmoko 
feat(cli): check for rustc before doing anything

Addresses #190. From the backtraces shown there, it seems like we're not able to launch `rustc` (which is odd, given that they probably compiled and installed `rustlings` 🤷‍♀️)
 2019-11-11 18:19:07 +00:00
marisa b4d41c1b7a chore: Update docs for 2.0 2019-11-11 18:02:56 +01:00
Roberto Vidal 36a033b87a feat(cli): check for rustc before doing anything 
Addresses #190.
 2019-11-11 18:00:54 +01:00
bors 9544ba1029 Auto merge of #231 - rust-lang:refactor-hints, r=jrvidal 
Refactor hints

Breaking change. This removes hints from the end of files, and puts them into `info.toml`. You can now access hints using:

```
rustlings hint <exerciseName>
```

ALSO this changes the exercise system to index by name for `run` and `hint`, so:

```
rustlings run exercises/if/if1.rs
```

becomes

```
rustlings run if1
```
 2019-11-11 16:51:12 +00:00
marisa 1a7bb5a400 Address feedback 2019-11-11 17:47:45 +01:00
marisa 48c35bcfbc fix tests 2019-11-11 17:28:19 +01:00
marisa ec2d4bd3ee
Merge branch 'master' into refactor-hints 2019-11-11 17:21:06 +01:00
marisa ce9fa6ebbf feat(hint): Add test for hint 2019-11-11 17:19:50 +01:00
marisa 9a9007abae chore: Add .editorconfig file 2019-11-11 17:12:11 +01:00
bors 88ec6f6b16 Auto merge of #230 - jrvidal:master, r=fmoko 
Changes the execution mode for `watch`, asking for user input

We've [observed](https://hackmd.io/-cK6aPhnTwiCiI7u6k0xug?both) that learners can get confused when they do get everything right, but they _still_ get errors... which come from the next exercise, no the one they just edited.

This PR changes it so they have to confirm they want to move forward by removing the `I AM NOT DONE` comment.

![Screenshot at 2019-11-11 15:13:39](https://user-images.githubusercontent.com/1636604/68593566-0abd3900-0496-11ea-9e9d-6c43b91bf21d.png)

* [ ] The particular string is of course subject to bikeshed.

### Alternatives/doubts
* The coolest solution I could imagine would involve a proc-macro attribute `#![ready(false)]` that they could edit once they're done, but it's a bit complicated to set up.
* For now I've put `I AM NOT DONE` everywhere, I think it's what make more sense.
 2019-11-11 15:59:35 +00:00
marisa 795b6e3480 fix(info): Fix trailing newlines for hints 2019-11-11 16:56:39 +01:00
marisa 9bdb0a12e4 feat: Refactor hint system 
Hints are now accessible using the CLI subcommand `rustlings hint
<exercise name`.

BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
 2019-11-11 16:51:38 +01:00
Roberto Vidal 2cdd61294f feat: improve `watch` execution mode 
The `watch` command now requires user action to move to the next
exercise.

BREAKING CHANGE: this changes the behavior of `watch`.
 2019-11-11 16:23:35 +01:00
marisa 627cdc07d0 feat: Index exercises by name 
BREAKING CHANGE: This changes the way you use `rustlings run` by now
requiring an abridged form of the previous filename, e.g:

`rustlings run exercises/if/if1.rs` becomes
`rustlings run if1`
 2019-11-11 15:46:32 +01:00
marisa a47a62172a 1.5.1 2019-11-11 14:02:27 +01:00
marisa f72e5a8f05 fix(structs1): Remove misleading comment 2019-11-11 13:57:59 +01:00
marisa fbe91a67a4 fix(threads): Move Threads behind SLT 
Closes #205.
 2019-11-11 13:48:09 +01:00
marisa 6dcecb38a4 fix(strings): Move Strings before Structs 
Closes #204.
 2019-11-11 13:46:42 +01:00
marisa dcfb427b09 fix(errors3): Update hint 
Closes #185.
 2019-11-11 13:37:43 +01:00
marisa ad03d180c9 fix(if1): Remove `return` reference 
This closes #153.
 2019-11-11 13:34:21 +01:00
bors 3232a4d60d Auto merge of #228 - WofWca:clear-screen, r=fmoko 
improvement(watch): clear screen before each `verify()`

Closes #146
It seems to me that #227 wasn't really fixing the issue.
 2019-11-09 15:23:53 +00:00
WofWca 3aff590855 improvement(watch): clear screen before each `verify()` 
Closes #146
 2019-11-09 22:24:24 +08:00
marisa c8babbad27 1.5.0 2019-11-09 10:52:20 +01:00
bors c6dad28ddc Auto merge of #224 - nyxtom:feat-enums, r=fmoko 
feat: Add enums exercises

Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
 2019-11-09 09:41:36 +00:00
bors fea81419cd Auto merge of #227 - workingjubilee:watch-clears-terminal, r=fmoko 
watch: clears terminal before entering loop

Fixes #146

If someone is sliding in and out of "watch" mode, it can make it hard
to tell which error messages are still relevant. This patch resolves
that by clearing the terminal entirely before entering watch's loop.

Note that the escape character is chosen for compatibility reasons, because different shells/terminals can change which commands they accept or have installed, betting on what other commands are in use to collect data seems risky, and just expecting them to implement ANSI escape code sequences is more reliable. This seems especially true since Windows is seeking more UNIX compatibility in its terminals going forward, even though it doesn't implement the POSIX standard per se.
 2019-11-09 09:31:50 +00:00
Jubilee Young 83be517e77 watch: clears terminal before entering loop 
If someone is sliding in and out of "watch" mode, it can make it hard
to tell which error messages are still relevant. This patch resolves
that by clearing the terminal entirely before entering watch's loop.
 2019-11-09 00:57:36 -08:00
marisa 79a569422c
fix: Rewrite test1 logic 2019-10-29 20:53:41 +01:00
bors 1e0b12e37e Auto merge of #225 - ssweeny:fix/test1-wording, r=fmoko 
chore: Clarify comment in exercises/test1.rs

closes #194

The author of issue #194 suggests that the wording of the comment is at
least ambiguous about the desired results. I believe this change more
clearly describes the expectation of the exercise.
 2019-10-29 13:37:30 +00:00
Thomas Holloway dc15032112 feat: Add enums exercises 2019-10-28 22:49:49 -05:00
Scott Sweeny 2821227acf chore: Clarify comment in exercises/test1.rs 
closes #194

The author of issue #194 suggests that the wording of the comment is at
least ambiguous about the desired results. I believe this change more
clearly describes the expectation of the exercise.
 2019-10-28 23:08:46 -04:00
bors 2191ef7eee Auto merge of #219 - vyaslav:master, r=fmoko 
Added exercise for struct update syntax

Added one exercise for struct update syntax `struct2.rs`
 2019-10-28 22:56:54 +00:00
marisa 4c2cf6da75
fix(option1): Fix arguments passed to assert! macro (#222) 
fix(option1): Fix arguments passed to assert! macro
 2019-10-26 00:27:40 +02:00
marisa 0f3d6d871e
chore: Bump version in Cargo.lock (#223) 
chore: Bump version in Cargo.lock
 2019-10-26 00:27:17 +02:00
Niklas Anderson bd007d4617 chore: Bump version in Cargo.lock 2019-10-25 14:57:30 -07:00
Niklas Anderson ead4f7af9e fix(option1): Fix arguments passed to assert! macro 2019-10-25 14:27:24 -07:00
marisa 4808b5b3ba
Update README to show latest version, for those who copy/paste (#221) 
Update README to show latest version, for those who copy/paste
 2019-10-25 01:54:10 +02:00
Mark Provan f3da6796b9
Update README to show latest version, for those who copy/paste 2019-10-24 13:56:14 +01:00
marisa cece12e87e docs: Add automatic Windows support to Readme 2019-10-23 13:01:07 +02:00