From 6e40f982082a60b9788cf5e0360142a23180fbfa Mon Sep 17 00:00:00 2001 From: Matteo Croce Date: Sun, 29 Sep 2024 00:41:23 +0200 Subject: [PATCH] scripts/download.pl: use perl builtins instead of system() Perl natively supports renaming files and create directories. Do it without calling system(). Signed-off-by: Matteo Croce Link: https://github.com/openwrt/openwrt/pull/16542 Signed-off-by: Hauke Mehrtens --- scripts/download.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/download.pl b/scripts/download.pl index 5449a3406a..c6c9b8e56c 100755 --- a/scripts/download.pl +++ b/scripts/download.pl @@ -11,6 +11,7 @@ use strict; use warnings; use File::Basename; use File::Copy; +use File::Path; use Text::ParseWords; use JSON::PP; @@ -173,7 +174,7 @@ sub download } if (! -d "$target") { - system("mkdir", "-p", "$target/"); + make_path($target); } if (! open TMPDLS, "find $mirror -follow -name $filename 2>/dev/null |") { @@ -244,7 +245,7 @@ sub download }; unlink "$target/$filename"; - system("mv", "$target/$filename.dl", "$target/$filename"); + move("$target/$filename.dl", "$target/$filename"); cleanup(); }