mirror of
https://github.com/goreleaser/nfpm
synced 2024-11-19 07:34:48 +01:00
285a6bcaea
* feat: Add initial openpgp signing capability. * refactor: Rename signatures to sigs and expose verify method. * feat: Add debsigs support. * test: Add debsigs acceptance test. * feat: Add RSA signing capability. * feat: Add RPM signature support. * test: Add RPM signature acceptance test. * test: Move acceptance test keys in dedicated folder. * feat: Add APK signature support. * test: Add APK signature acceptance test. * feat: Expose deb signature type in config. * fix: Fix typo and superfluous explicit error check * fix: Fix password env extraction and add tests. * fix: Redirect rpmpack to temporary goreleaser vendoring. * fix: Catch missing maintainer email if no apk key name is set. * refactor: Put signature info in a dedicated struct. * doc: Add signing documentation. * fix: Add trailing newlines to some files and remove unnecessary comment. * fix: Change wrong references from SHA256 to SHA1 in the sign package. * fix: Improve error wording when no passphrase was provided. * fix: Remove another SHA256 reference. * fix: Fix signature errors. * test: Split up environment variable test. * fix: Don't parse passphrase from YAML. * deps: Update redirected rpmpack. * fix: Export and use signature related error type. * doc: Document ErrSigningFailure. * test: Fix apk signature error test. * test: Add rpm signature error test.
245 lines
6.0 KiB
Go
245 lines
6.0 KiB
Go
package nfpm
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestRegister(t *testing.T) {
|
|
format := "TestRegister"
|
|
pkgr := &fakePackager{}
|
|
Register(format, pkgr)
|
|
got, err := Get(format)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pkgr, got)
|
|
}
|
|
|
|
func TestGet(t *testing.T) {
|
|
format := "TestGet"
|
|
got, err := Get(format)
|
|
require.Error(t, err)
|
|
assert.EqualError(t, err, "no packager registered for the format "+format)
|
|
assert.Nil(t, got)
|
|
pkgr := &fakePackager{}
|
|
Register(format, pkgr)
|
|
got, err = Get(format)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, pkgr, got)
|
|
}
|
|
|
|
func TestDefaultsVersion(t *testing.T) {
|
|
info := &Info{
|
|
Version: "v1.0.0",
|
|
}
|
|
info = WithDefaults(info)
|
|
assert.NotEmpty(t, info.Platform)
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
assert.Equal(t, "", info.Release)
|
|
assert.Equal(t, "", info.Prerelease)
|
|
|
|
info = &Info{
|
|
Version: "v1.0.0-rc1",
|
|
}
|
|
info = WithDefaults(info)
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
assert.Equal(t, "", info.Release)
|
|
assert.Equal(t, "rc1", info.Prerelease)
|
|
|
|
info = &Info{
|
|
Version: "v1.0.0-beta1",
|
|
}
|
|
info = WithDefaults(info)
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
assert.Equal(t, "", info.Release)
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
|
|
|
info = &Info{
|
|
Version: "v1.0.0-1",
|
|
Release: "2",
|
|
Prerelease: "beta1",
|
|
}
|
|
info = WithDefaults(info)
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
assert.Equal(t, "2", info.Release)
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
|
|
|
info = &Info{
|
|
Version: "v1.0.0-1+xdg2",
|
|
Release: "2",
|
|
Prerelease: "beta1",
|
|
}
|
|
info = WithDefaults(info)
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
assert.Equal(t, "2", info.Release)
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
|
assert.Equal(t, "", info.Deb.VersionMetadata)
|
|
}
|
|
|
|
func TestDefaults(t *testing.T) {
|
|
info := &Info{
|
|
Platform: "darwin",
|
|
Version: "2.4.1",
|
|
Description: "no description given",
|
|
}
|
|
got := WithDefaults(info)
|
|
assert.Equal(t, info, got)
|
|
}
|
|
|
|
func TestValidate(t *testing.T) {
|
|
require.NoError(t, Validate(&Info{
|
|
Name: "as",
|
|
Arch: "asd",
|
|
Version: "1.2.3",
|
|
Overridables: Overridables{
|
|
Files: map[string]string{
|
|
"asa": "asd",
|
|
},
|
|
},
|
|
}))
|
|
require.NoError(t, Validate(&Info{
|
|
Name: "as",
|
|
Arch: "asd",
|
|
Version: "1.2.3",
|
|
Overridables: Overridables{
|
|
ConfigFiles: map[string]string{
|
|
"asa": "asd",
|
|
},
|
|
},
|
|
}))
|
|
}
|
|
|
|
func TestValidateError(t *testing.T) {
|
|
for err, info := range map[string]Info{
|
|
"package name must be provided": {},
|
|
"package arch must be provided": {
|
|
Name: "fo",
|
|
},
|
|
"package version must be provided": {
|
|
Name: "as",
|
|
Arch: "asd",
|
|
},
|
|
} {
|
|
err := err
|
|
info := info
|
|
t.Run(err, func(t *testing.T) {
|
|
require.EqualError(t, Validate(&info), err)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseFile(t *testing.T) {
|
|
packagers = map[string]Packager{}
|
|
_, err := ParseFile("./testdata/overrides.yaml")
|
|
require.Error(t, err)
|
|
Register("deb", &fakePackager{})
|
|
Register("rpm", &fakePackager{})
|
|
Register("apk", &fakePackager{})
|
|
_, err = ParseFile("./testdata/overrides.yaml")
|
|
require.NoError(t, err)
|
|
_, err = ParseFile("./testdata/doesnotexist.yaml")
|
|
require.Error(t, err)
|
|
config, err := ParseFile("./testdata/versionenv.yaml")
|
|
require.NoError(t, err)
|
|
assert.Equal(t, fmt.Sprintf("v%s", os.Getenv("GOROOT")), config.Version)
|
|
}
|
|
|
|
func TestOptionsFromEnvironment(t *testing.T) {
|
|
const (
|
|
globalPass = "hunter2"
|
|
debPass = "password123"
|
|
rpmPass = "secret"
|
|
apkPass = "foobar"
|
|
release = "3"
|
|
version = "1.0.0"
|
|
)
|
|
|
|
t.Run("version", func(t *testing.T) {
|
|
os.Clearenv()
|
|
os.Setenv("VERSION", version)
|
|
info, err := Parse(strings.NewReader("name: foo\nversion: $VERSION"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, version, info.Version)
|
|
})
|
|
|
|
t.Run("release", func(t *testing.T) {
|
|
os.Clearenv()
|
|
os.Setenv("RELEASE", release)
|
|
info, err := Parse(strings.NewReader("name: foo\nrelease: $RELEASE"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, release, info.Release)
|
|
})
|
|
|
|
t.Run("global passphrase", func(t *testing.T) {
|
|
os.Clearenv()
|
|
os.Setenv("NFPM_PASSPHRASE", globalPass)
|
|
info, err := Parse(strings.NewReader("name: foo"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, globalPass, info.Deb.Signature.KeyPassphrase)
|
|
assert.Equal(t, globalPass, info.RPM.Signature.KeyPassphrase)
|
|
assert.Equal(t, globalPass, info.APK.Signature.KeyPassphrase)
|
|
})
|
|
|
|
t.Run("specific passphrases", func(t *testing.T) {
|
|
os.Clearenv()
|
|
os.Setenv("NFPM_PASSPHRASE", globalPass)
|
|
os.Setenv("NFPM_DEB_PASSPHRASE", debPass)
|
|
os.Setenv("NFPM_RPM_PASSPHRASE", rpmPass)
|
|
os.Setenv("NFPM_APK_PASSPHRASE", apkPass)
|
|
info, err := Parse(strings.NewReader("name: foo"))
|
|
require.NoError(t, err)
|
|
assert.Equal(t, debPass, info.Deb.Signature.KeyPassphrase)
|
|
assert.Equal(t, rpmPass, info.RPM.Signature.KeyPassphrase)
|
|
assert.Equal(t, apkPass, info.APK.Signature.KeyPassphrase)
|
|
})
|
|
}
|
|
|
|
func TestOverrides(t *testing.T) {
|
|
file := "./testdata/overrides.yaml"
|
|
config, err := ParseFile(file)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "foo", config.Name)
|
|
assert.Equal(t, "amd64", config.Arch)
|
|
|
|
// deb overrides
|
|
deb, err := config.Get("deb")
|
|
require.NoError(t, err)
|
|
assert.Contains(t, deb.Depends, "deb_depend")
|
|
assert.NotContains(t, deb.Depends, "rpm_depend")
|
|
assert.Contains(t, deb.ConfigFiles, "deb.conf")
|
|
assert.NotContains(t, deb.ConfigFiles, "rpm.conf")
|
|
assert.Contains(t, deb.ConfigFiles, "whatever.conf")
|
|
assert.Equal(t, "amd64", deb.Arch)
|
|
|
|
// rpm overrides
|
|
rpm, err := config.Get("rpm")
|
|
require.NoError(t, err)
|
|
assert.Contains(t, rpm.Depends, "rpm_depend")
|
|
assert.NotContains(t, rpm.Depends, "deb_depend")
|
|
assert.Contains(t, rpm.ConfigFiles, "rpm.conf")
|
|
assert.NotContains(t, rpm.ConfigFiles, "deb.conf")
|
|
assert.Contains(t, rpm.ConfigFiles, "whatever.conf")
|
|
assert.Equal(t, "amd64", rpm.Arch)
|
|
|
|
// no overrides
|
|
info, err := config.Get("doesnotexist")
|
|
require.NoError(t, err)
|
|
assert.True(t, reflect.DeepEqual(&config.Info, info))
|
|
}
|
|
|
|
type fakePackager struct{}
|
|
|
|
func (*fakePackager) ConventionalFileName(info *Info) string {
|
|
return ""
|
|
}
|
|
|
|
func (*fakePackager) Package(info *Info, w io.Writer) error {
|
|
return nil
|
|
}
|