mirror of
https://github.com/goreleaser/nfpm
synced 2026-11-01 07:30:23 +01:00
Laurent CoustetandLaurent Coustet
edf3552720
rpmbuild runs script.req on the executable files of a package, so a package that ships a "#!/bin/bash" script requires /bin/bash without any work from the packager. nfpm has no such generator, so the interpreter of every script must be listed by hand, which is error-prone. Add the opt-in rpm.script_requires option. Like script.req with the exeonly flag of script.attr, it reads the "#!" line of each executable file and requires its interpreter, and the absolute program run by env, flagged RPMSENSE_FIND_REQUIRES like the dependencies rpmbuild generates. Documentation files, symlinks, directories and ghosts are skipped. The mode checked is the one in the package, so file_info.mode is honored and the option also works when building on Windows. The generated spec sets AutoReqProv: no, so the requires are written to it explicitly and rpmbuild --rebuild keeps them. Add unit tests, a scriptrequires acceptance stage that reads the requires back with rpm, and an executable script to the srpm rebuild acceptance test. Co-authored-by: Laurent Coustet <laurent.coustet@bluemind.net>
260 lines
8.4 KiB
Docker
260 lines
8.4 KiB
Docker
FROM fedora AS test_base
|
|
ARG package
|
|
RUN echo "${package}"
|
|
COPY ${package} /tmp/foo.rpm
|
|
|
|
|
|
# ---- minimal test ----
|
|
FROM test_base AS min
|
|
RUN rpm -ivh /tmp/foo.rpm
|
|
|
|
|
|
# ---- symlink test ----
|
|
FROM min AS symlink
|
|
RUN ls -l /path/to/symlink | grep "/path/to/symlink -> /etc/foo/whatever.conf"
|
|
|
|
|
|
# ---- simple test ----
|
|
FROM min AS simple
|
|
RUN test -e /usr/bin/fake
|
|
RUN test -f /etc/foo/whatever.conf
|
|
RUN echo wat >> /etc/foo/whatever.conf
|
|
RUN rpm -e foo
|
|
RUN test -f /etc/foo/whatever.conf.rpmsave
|
|
RUN test ! -f /usr/bin/fake
|
|
|
|
|
|
# ---- no-glob test ----
|
|
FROM min AS no-glob
|
|
RUN test -d /usr/share/whatever/
|
|
RUN test -f /usr/share/whatever/file1
|
|
RUN test -f /usr/share/whatever/file2
|
|
RUN test -d /usr/share/whatever/folder2
|
|
RUN test -f /usr/share/whatever/folder2/file1
|
|
RUN test -f /usr/share/whatever/folder2/file2
|
|
|
|
|
|
# ---- complex test ----
|
|
FROM test_base AS complex
|
|
RUN rpm --prefix=/opt -ivh /tmp/foo.rpm
|
|
RUN test "$(rpm -qp --recommends /tmp/foo.rpm)" = "fish"
|
|
RUN test "$(rpm -qp --suggests /tmp/foo.rpm)" = "zsh"
|
|
# The package declares a single explicit dependency (bash); the remaining
|
|
# entries are the standard rpmlib() feature requirements.
|
|
RUN rpm -qp --requires /tmp/foo.rpm | grep -E '^bash$'
|
|
RUN test -e /opt/fake
|
|
RUN test -f /etc/foo/whatever.conf
|
|
RUN test -d /usr/share/whatever/folder
|
|
RUN test -f /usr/share/whatever/folder/file1
|
|
RUN test -f /usr/share/whatever/folder/file2
|
|
RUN test -d /usr/share/whatever/folder/folder2
|
|
RUN test -f /usr/share/whatever/folder/folder2/file1
|
|
RUN test -f /usr/share/whatever/folder/folder2/file2
|
|
RUN test -d /var/log/whatever
|
|
RUN test -d /usr/share/foo
|
|
RUN test -d /usr/foo/bar/something
|
|
RUN test -d /etc/something
|
|
RUN test -f /etc/something/a
|
|
RUN test -f /etc/something/b
|
|
RUN test -d /etc/something/c
|
|
RUN test -f /etc/something/c/d
|
|
RUN test $(stat -c %a /opt/fake2) -eq 4755
|
|
RUN test -f /tmp/preinstall-proof
|
|
RUN test -f /tmp/postinstall-proof
|
|
RUN test -f /tmp/pretrans-proof
|
|
RUN test -f /tmp/posttrans-proof
|
|
RUN test ! -f /tmp/preremove-proof
|
|
RUN test ! -f /tmp/postremove-proof
|
|
RUN echo wat >> /etc/foo/whatever.conf
|
|
RUN rpm -e foo
|
|
RUN test -f /etc/foo/whatever.conf.rpmsave
|
|
RUN test ! -f /opt/fake
|
|
RUN test ! -f /opt/fake2
|
|
RUN test -f /tmp/preremove-proof
|
|
RUN test -f /tmp/postremove-proof
|
|
RUN test ! -d /var/log/whatever
|
|
RUN test ! -d /usr/share/foo
|
|
RUN test ! -d /usr/foo/bar/something
|
|
|
|
|
|
# ---- signed test ----
|
|
FROM test_base AS signed
|
|
COPY keys/pubkey.asc /tmp/pubkey.asc
|
|
RUN rpm --import /tmp/pubkey.asc
|
|
RUN rpm -q gpg-pubkey --qf '%{NAME}-%{VERSION}-%{RELEASE}\t%{SUMMARY}\n'
|
|
RUN rpm -K /tmp/foo.rpm
|
|
RUN rpm -K /tmp/foo.rpm | grep -E "(?:pgp|digests signatures) OK"
|
|
RUN rpm -vK /tmp/foo.rpm
|
|
RUN rpm -vK /tmp/foo.rpm | grep "Header OpenPGP V4 RSA/SHA256 signature, key fingerprint: 866f6c83bab3e49381ade4c1bc8acdd415bd80b3: OK"
|
|
|
|
# Test with a repo
|
|
RUN yum install -y createrepo yum-utils
|
|
RUN rm -rf /etc/yum.repos.d/*.repo
|
|
COPY keys/test.rpm.repo /etc/yum.repos.d/test.rpm.repo
|
|
RUN createrepo /tmp
|
|
RUN yum install -y foo
|
|
|
|
|
|
# ---- overrides test ----
|
|
FROM min AS overrides
|
|
RUN test -e /usr/bin/fake
|
|
RUN test -f /etc/foo/whatever.conf
|
|
RUN test -d /usr/share/whatever/folder
|
|
RUN test -f /usr/share/whatever/folder/file1
|
|
RUN test -f /usr/share/whatever/folder/file2
|
|
RUN test -d /usr/share/whatever/folder/folder2
|
|
RUN test -f /usr/share/whatever/folder/folder2/file1
|
|
RUN test -f /usr/share/whatever/folder/folder2/file2
|
|
RUN test -f /tmp/preinstall-proof
|
|
RUN test ! -f /tmp/postinstall-proof
|
|
RUN test ! -f /tmp/preremove-proof
|
|
RUN test ! -f /tmp/postremove-proof
|
|
RUN echo wat >> /etc/foo/whatever.conf
|
|
RUN rpm -e foo
|
|
RUN test -f /etc/foo/whatever.conf.rpmsave
|
|
RUN test ! -f /usr/bin/fake
|
|
RUN test ! -f /tmp/preremove-proof
|
|
RUN test -f /tmp/postremove-proof
|
|
|
|
|
|
# ---- meta test ----
|
|
FROM test_base AS meta
|
|
RUN dnf install -y /tmp/foo.rpm
|
|
RUN command -v zsh
|
|
|
|
|
|
# ---- env-var-version test ----
|
|
FROM min AS env-var-version
|
|
ENV EXPECTVER="Version : 1.0.0~0.1.b1+git.abcdefgh" \
|
|
EXPECTREL="Release : 1"
|
|
RUN rpm -qpi /tmp/foo.rpm | sed -e 's/ \+/ /g' | grep "Version" > found.ver
|
|
RUN rpm -qpi /tmp/foo.rpm | sed -e 's/ \+/ /g' | grep "Release" > found.rel
|
|
RUN export FOUND_VER="$(cat found.ver)" && \
|
|
echo "Expected: ${EXPECTVER}' :: Found: '${FOUND_VER}'" && \
|
|
test "${FOUND_VER}" = "${EXPECTVER}"
|
|
RUN export FOUND_REL="$(cat found.rel)" && \
|
|
echo "Expected: '${EXPECTREL}' :: Found: '${FOUND_REL}'" && \
|
|
test "${FOUND_REL}" = "${EXPECTREL}"
|
|
|
|
|
|
# ---- changelog test ----
|
|
FROM min AS withchangelog
|
|
RUN rpm -qp /tmp/foo.rpm --changelog | grep "Carlos A Becker <pkg@carlosbecker.com>"
|
|
RUN rpm -qp /tmp/foo.rpm --changelog | grep -E "^- note 1$"
|
|
RUN rpm -qp /tmp/foo.rpm --changelog | grep -E "^- note 2$"
|
|
RUN rpm -qp /tmp/foo.rpm --changelog | grep -E "^- note 3$"
|
|
RUN rpm -q foo --changelog | grep "Carlos A Becker <pkg@carlosbecker.com>"
|
|
RUN rpm -q foo --changelog | grep -E "^- note 1$"
|
|
RUN rpm -q foo --changelog | grep -E "^- note 2$"
|
|
RUN rpm -q foo --changelog | grep -E "^- note 3$"
|
|
|
|
|
|
# ---- compression test ----
|
|
FROM min AS compression
|
|
ARG compression
|
|
RUN test "${compression}" = "$(rpm -qp --qf '%{PAYLOADCOMPRESSOR}' /tmp/foo.rpm)"
|
|
RUN test -e /usr/bin/fake
|
|
RUN test -f /etc/foo/whatever.conf
|
|
RUN echo wat >> /etc/foo/whatever.conf
|
|
RUN rpm -e foo
|
|
RUN test -f /etc/foo/whatever.conf.rpmsave
|
|
RUN test ! -f /usr/bin/fake
|
|
|
|
# ---- upgrade test ----
|
|
FROM test_base AS upgrade
|
|
ARG oldpackage
|
|
RUN echo "${oldpackage}"
|
|
COPY ${oldpackage} /tmp/old_foo.rpm
|
|
RUN rpm -ivh /tmp/old_foo.rpm
|
|
|
|
RUN test -f /tmp/preinstall-proof
|
|
RUN cat /tmp/preinstall-proof | grep "Install"
|
|
|
|
RUN test -f /tmp/postinstall-proof
|
|
RUN cat /tmp/postinstall-proof | grep "Install"
|
|
|
|
RUN echo modified > /etc/regular.conf
|
|
RUN echo modified > /etc/noreplace.conf
|
|
|
|
RUN rpm -ivh /tmp/foo.rpm --upgrade
|
|
|
|
RUN test -f /tmp/preremove-proof
|
|
RUN cat /tmp/preremove-proof | grep "Upgrade"
|
|
|
|
RUN test -f /tmp/postremove-proof
|
|
RUN cat /tmp/postremove-proof | grep "Upgrade"
|
|
|
|
RUN test -f /tmp/preinstall-proof
|
|
RUN cat /tmp/preinstall-proof | grep "Upgrade"
|
|
|
|
RUN test -f /tmp/postinstall-proof
|
|
RUN cat /tmp/postinstall-proof | grep "Upgrade"
|
|
|
|
RUN cat /etc/regular.conf | grep foo=baz
|
|
RUN test -f /etc/regular.conf.rpmsave
|
|
RUN cat /etc/regular.conf.rpmsave | grep modified
|
|
|
|
RUN cat /etc/noreplace.conf | grep modified
|
|
RUN test -f /etc/noreplace.conf.rpmnew
|
|
RUN cat /etc/noreplace.conf.rpmnew | grep foo=baz
|
|
|
|
# ---- release test ----
|
|
FROM min AS release
|
|
RUN test -e /usr/bin/fake
|
|
RUN test -f /etc/foo/whatever.conf
|
|
RUN echo wat >> /etc/foo/whatever.conf
|
|
RUN rpm -e foo
|
|
RUN test -f /etc/foo/whatever.conf.rpmsave
|
|
RUN test ! -f /usr/bin/fake
|
|
|
|
# ---- directories test ----
|
|
FROM test_base AS directories
|
|
RUN groupadd test
|
|
RUN rpm -ivh /tmp/foo.rpm
|
|
RUN test -f /etc/foo/file
|
|
RUN test -f /etc/bar/file
|
|
RUN test -d /etc/bar
|
|
RUN test -d /etc/baz
|
|
RUN stat -L -c "%a %U %G" /etc/baz | grep "700 root test"
|
|
RUN rpm -e foo
|
|
RUN test ! -f /etc/foo/file
|
|
RUN test ! -f /etc/bar/file
|
|
RUN test -d /etc/foo
|
|
RUN test ! -d /etc/bar
|
|
RUN test ! -d /etc/baz
|
|
|
|
# ---- verify test ----
|
|
FROM min AS verify
|
|
RUN rpm -V foo
|
|
RUN rm /tmp/postinstall-proof
|
|
RUN ! rpm -V foo
|
|
|
|
# ---- postrequires test ----
|
|
FROM min AS postrequires
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS} %{REQUIREVERSION}\n]' /tmp/foo.rpm
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS} %{REQUIREVERSION}\n]' /tmp/foo.rpm | grep -E '^bash 1024 ?$'
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS} %{REQUIREVERSION}\n]' /tmp/foo.rpm | grep -E '^coreutils 1036 9\.0$'
|
|
|
|
# ---- elfcolors test ----
|
|
FROM min AS elfcolors
|
|
RUN rpm -q --qf '[%{FILECOLORS} %{FILENAMES}\n]' foo
|
|
RUN rpm -q --qf '[%{FILECOLORS} %{FILENAMES}\n]' foo | grep -Fx '1 /usr/lib/foo/elf32'
|
|
RUN rpm -q --qf '[%{FILECOLORS} %{FILENAMES}\n]' foo | grep -Fx '2 /usr/lib/foo/elf64'
|
|
RUN rpm -q --qf '[%{FILECOLORS} %{FILENAMES}\n]' foo | grep -Fx '0 /usr/lib/foo/elf64.so'
|
|
RUN rpm -q --qf '[%{FILECOLORS} %{FILENAMES}\n]' foo | grep -Fx '0 /usr/bin/fake'
|
|
|
|
# ---- isaprovide test ----
|
|
FROM min AS isaprovide
|
|
RUN rpm -qp --provides /tmp/foo.rpm
|
|
RUN rpm -qp --provides /tmp/foo.rpm | grep -Fx "foo = 1:1.2.3-4"
|
|
RUN rpm -qp --provides /tmp/foo.rpm | grep -Fx "foo$(rpm --eval '%{_isa}') = 1:1.2.3-4"
|
|
|
|
# ---- script requires test ----
|
|
FROM min AS scriptrequires
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS}\n]' /tmp/foo.rpm
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS}\n]' /tmp/foo.rpm | grep -Fx '/bin/bash 16384'
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS}\n]' /tmp/foo.rpm | grep -Fx '/usr/bin/env 16384'
|
|
RUN rpm -qp --qf '[%{REQUIRENAME} %{REQUIREFLAGS}\n]' /tmp/foo.rpm | grep -Fx '/bin/sh 16384'
|
|
# Scripts that are not executable are not scanned.
|
|
RUN ! rpm -qp --requires /tmp/foo.rpm | grep -F perl
|