mirror/ nfpm
1
1
Fork 0
mirror of https://github.com/goreleaser/nfpm synced 2024-04-19 12:03:54 +02:00
Code Issues Releases Activity

test: improve test code (#602) 

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker 2023-01-07 16:51:49 -03:00 committed by GitHub
parent c195d93dfb
commit c816571b14
Signed by: GitHub
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 29 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apk/apk_test.go
View File

@ -175,7 +175,7 @@ func TestDefaultWithArch(t *testing.T) {
}
func TestApkPlatform(t *testing.T) {
f, err := os.CreateTemp("", "test*.apk")
f, err := os.CreateTemp(t.TempDir(), "test*.apk")
require.NoError(t, err)
info := exampleInfo()
info.Platform = "darwin"

2
arch/arch_test.go
View File

@ -101,7 +101,7 @@ func TestArch(t *testing.T) {
}
func TestArchPlatform(t *testing.T) {
f, err := os.CreateTemp("", "test*.pkg.tar.zstd")
f, err := os.CreateTemp(t.TempDir(), "test*.pkg.tar.zstd")
require.NoError(t, err)
info := exampleInfo()
info.Platform = "darwin"

2
deb/deb_test.go
View File

@ -108,7 +108,7 @@ func TestDeb(t *testing.T) {
}
func TestDebPlatform(t *testing.T) {
f, err := os.CreateTemp("", "test*.deb")
f, err := os.CreateTemp(t.TempDir(), "test*.deb")
require.NoError(t, err)
info := exampleInfo()
info.Platform = "darwin"

43
nfpm_test.go
View File

@ -191,9 +191,9 @@ func TestParseFile(t *testing.T) {
require.NoError(t, err)
_, err = parseAndValidate("./testdata/doesnotexist.yaml")
require.Error(t, err)
os.Setenv("RPM_KEY_FILE", "my/rpm/key/file")
os.Setenv("TEST_RELEASE_ENV_VAR", "1234")
os.Setenv("TEST_PRERELEASE_ENV_VAR", "beta1")
t.Setenv("RPM_KEY_FILE", "my/rpm/key/file")
t.Setenv("TEST_RELEASE_ENV_VAR", "1234")
t.Setenv("TEST_PRERELEASE_ENV_VAR", "beta1")
config, err := parseAndValidate("./testdata/env-fields.yaml")
require.NoError(t, err)
require.Equal(t, fmt.Sprintf("v%s", os.Getenv("GOROOT")), config.Version)
@ -268,25 +268,22 @@ func TestOptionsFromEnvironment(t *testing.T) {
})
t.Run("version", func(t *testing.T) {
os.Clearenv()
os.Setenv("VERSION", version)
t.Setenv("VERSION", version)
info, err := nfpm.Parse(strings.NewReader("name: foo\nversion: $VERSION"))
require.NoError(t, err)
require.Equal(t, version, info.Version)
})
t.Run("release", func(t *testing.T) {
os.Clearenv()
os.Setenv("RELEASE", release)
t.Setenv("RELEASE", release)
info, err := nfpm.Parse(strings.NewReader("name: foo\nrelease: $RELEASE"))
require.NoError(t, err)
require.Equal(t, release, info.Release)
})
t.Run("maintainer", func(t *testing.T) {
os.Clearenv()
os.Setenv("GIT_COMMITTER_NAME", packager)
os.Setenv("GIT_COMMITTER_EMAIL", maintainerEmail)
t.Setenv("GIT_COMMITTER_NAME", packager)
t.Setenv("GIT_COMMITTER_EMAIL", maintainerEmail)
info, err := nfpm.Parse(strings.NewReader(`
name: foo
maintainer: '"$GIT_COMMITTER_NAME" <$GIT_COMMITTER_EMAIL>'
@ -300,16 +297,14 @@ maintainer: '"$GIT_COMMITTER_NAME" <$GIT_COMMITTER_EMAIL>'
})
t.Run("vendor", func(t *testing.T) {
os.Clearenv()
os.Setenv("VENDOR", vendor)
t.Setenv("VENDOR", vendor)
info, err := nfpm.Parse(strings.NewReader("name: foo\nvendor: $VENDOR"))
require.NoError(t, err)
require.Equal(t, vendor, info.Vendor)
})
t.Run("global passphrase", func(t *testing.T) {
os.Clearenv()
os.Setenv("NFPM_PASSPHRASE", globalPass)
t.Setenv("NFPM_PASSPHRASE", globalPass)
info, err := nfpm.Parse(strings.NewReader("name: foo"))
require.NoError(t, err)
require.Equal(t, globalPass, info.Deb.Signature.KeyPassphrase)
@ -318,11 +313,10 @@ maintainer: '"$GIT_COMMITTER_NAME" <$GIT_COMMITTER_EMAIL>'
})
t.Run("specific passphrases", func(t *testing.T) {
os.Clearenv()
os.Setenv("NFPM_PASSPHRASE", globalPass)
os.Setenv("NFPM_DEB_PASSPHRASE", debPass)
os.Setenv("NFPM_RPM_PASSPHRASE", rpmPass)
os.Setenv("NFPM_APK_PASSPHRASE", apkPass)
t.Setenv("NFPM_PASSPHRASE", globalPass)
t.Setenv("NFPM_DEB_PASSPHRASE", debPass)
t.Setenv("NFPM_RPM_PASSPHRASE", rpmPass)
t.Setenv("NFPM_APK_PASSPHRASE", apkPass)
info, err := nfpm.Parse(strings.NewReader("name: foo"))
require.NoError(t, err)
require.Equal(t, debPass, info.Deb.Signature.KeyPassphrase)
@ -331,16 +325,14 @@ maintainer: '"$GIT_COMMITTER_NAME" <$GIT_COMMITTER_EMAIL>'
})
t.Run("packager", func(t *testing.T) {
os.Clearenv()
os.Setenv("PACKAGER", packager)
t.Setenv("PACKAGER", packager)
info, err := nfpm.Parse(strings.NewReader("name: foo\nrpm:\n packager: $PACKAGER"))
require.NoError(t, err)
require.Equal(t, packager, info.RPM.Packager)
})
t.Run("depends", func(t *testing.T) {
os.Clearenv()
os.Setenv("VERSION", version)
t.Setenv("VERSION", version)
info, err := nfpm.Parse(strings.NewReader(`---
name: foo
overrides:
@ -358,9 +350,8 @@ overrides:
})
t.Run("depends-strips-empty", func(t *testing.T) {
os.Clearenv()
os.Setenv("VERSION", version)
os.Setenv("PKG", "")
t.Setenv("VERSION", version)
t.Setenv("PKG", "")
info, err := nfpm.Parse(strings.NewReader(`---
name: foo
overrides:

18
rpm/rpm_test.go
View File

@ -91,7 +91,7 @@ func TestConventionalExtension(t *testing.T) {
}
func TestRPM(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
require.NoError(t, Default.Package(exampleInfo(), f))
@ -143,7 +143,7 @@ func TestRPM(t *testing.T) {
}
func TestRPMPlatform(t *testing.T) {
f, err := os.CreateTemp("", "test*.rpm")
f, err := os.CreateTemp(t.TempDir(), "test*.rpm")
require.NoError(t, err)
info := exampleInfo()
info.Platform = "darwin"
@ -151,7 +151,7 @@ func TestRPMPlatform(t *testing.T) {
}
func TestRPMGroup(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
info := exampleInfo()
info.RPM.Group = "Unspecified"
@ -185,7 +185,7 @@ func TestRPMCompression(t *testing.T) {
compLevel = "lzma"
}
t.Run(compLevel, func(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
info := exampleInfo()
@ -215,7 +215,7 @@ func TestRPMCompression(t *testing.T) {
}
func TestRPMSummary(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
customSummary := "This is my custom summary"
@ -242,7 +242,7 @@ func TestRPMSummary(t *testing.T) {
}
func TestRPMPackager(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
customPackager := "GoReleaser <staff@goreleaser.com>"
@ -269,7 +269,7 @@ func TestRPMPackager(t *testing.T) {
}
func TestWithRPMTags(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
require.NoError(t, err)
info := exampleInfo()
@ -398,7 +398,7 @@ func TestRPMVersionWithVersionMetadata(t *testing.T) {
}
func TestWithInvalidEpoch(t *testing.T) {
f, err := os.CreateTemp("", "test.rpm")
f, err := os.CreateTemp(t.TempDir(), "test.rpm")
defer func() {
_ = f.Close()
err = os.Remove(f.Name())
@ -417,7 +417,7 @@ func TestWithInvalidEpoch(t *testing.T) {
func TestRPMScripts(t *testing.T) {
info := exampleInfo()
f, err := os.CreateTemp(".", fmt.Sprintf("%s-%s-*.rpm", info.Name, info.Version))
f, err := os.CreateTemp(t.TempDir(), fmt.Sprintf("%s-%s-*.rpm", info.Name, info.Version))
require.NoError(t, err)
err = Default.Package(info, f)
require.NoError(t, err)