diff --git a/acceptance/acceptance.go b/acceptance/acceptance.go index 123b1b4..85eef19 100644 --- a/acceptance/acceptance.go +++ b/acceptance/acceptance.go @@ -1,7 +1,6 @@ package acceptance import ( - "fmt" "io/ioutil" "os" "os/exec" @@ -17,8 +16,8 @@ import ( _ "github.com/goreleaser/nfpm/rpm" ) -func accept(t *testing.T, name, format string) { - var config = fmt.Sprintf("./testdata/%s.yaml", name) +func accept(t *testing.T, name, conf, format, dockerfile string) { + var config = filepath.Join("./testdata", conf) tmp, err := filepath.Abs("./testdata/tmp") require.NoError(t, err) var target = filepath.Join(tmp, name+"."+format) @@ -43,7 +42,7 @@ func accept(t *testing.T, name, format string) { "docker", "build", "-f", - fmt.Sprintf("./testdata/%s.dockerfile", name), + filepath.Join("./testdata", dockerfile), "./testdata", ) t.Log("will exec:", cmd.Args) diff --git a/acceptance/deb_acceptance_test.go b/acceptance/deb_acceptance_test.go index 4c906d8..bc99cf0 100644 --- a/acceptance/deb_acceptance_test.go +++ b/acceptance/deb_acceptance_test.go @@ -3,9 +3,9 @@ package acceptance import "testing" func TestSimpleDeb(t *testing.T) { - accept(t, "simple_deb", "deb") + accept(t, "simple_deb", "simple.yaml", "deb", "deb.dockerfile") } func TestComplexDeb(t *testing.T) { - accept(t, "complex_deb", "deb") + accept(t, "complex_deb", "complex.yaml", "deb", "deb.dockerfile") } diff --git a/acceptance/rpm_acceptance_test.go b/acceptance/rpm_acceptance_test.go index aad3625..f0d2128 100644 --- a/acceptance/rpm_acceptance_test.go +++ b/acceptance/rpm_acceptance_test.go @@ -3,9 +3,9 @@ package acceptance import "testing" func TestSimpleRPM(t *testing.T) { - accept(t, "simple_rpm", "rpm") + accept(t, "simple_rpm", "simple.yaml", "rpm", "rpm.dockerfile") } func TestComplexRPM(t *testing.T) { - accept(t, "complex_rpm", "rpm") + accept(t, "complex_rpm", "complex.yaml", "rpm", "rpm.dockerfile") } diff --git a/acceptance/testdata/complex_deb.yaml b/acceptance/testdata/complex.yaml similarity index 100% rename from acceptance/testdata/complex_deb.yaml rename to acceptance/testdata/complex.yaml diff --git a/acceptance/testdata/complex_deb.dockerfile b/acceptance/testdata/deb.dockerfile similarity index 100% rename from acceptance/testdata/complex_deb.dockerfile rename to acceptance/testdata/deb.dockerfile diff --git a/acceptance/testdata/simple_rpm.dockerfile b/acceptance/testdata/rpm.dockerfile similarity index 100% rename from acceptance/testdata/simple_rpm.dockerfile rename to acceptance/testdata/rpm.dockerfile diff --git a/acceptance/testdata/simple_deb.yaml b/acceptance/testdata/simple.yaml similarity index 100% rename from acceptance/testdata/simple_deb.yaml rename to acceptance/testdata/simple.yaml diff --git a/acceptance/testdata/simple_deb.dockerfile b/acceptance/testdata/simple_deb.dockerfile deleted file mode 100644 index 60dc845..0000000 --- a/acceptance/testdata/simple_deb.dockerfile +++ /dev/null @@ -1,9 +0,0 @@ -FROM ubuntu -COPY tmp/simple_deb.deb /tmp/foo.deb -RUN dpkg -i /tmp/foo.deb && \ - test -e /usr/local/bin/fake && \ - test -f /etc/foo/whatever.conf && \ - echo wat >> /etc/foo/whatever.conf && \ - dpkg -r foo && \ - test -f /etc/foo/whatever.conf && \ - test ! -f /usr/local/bin/fake diff --git a/acceptance/testdata/simple_rpm.yaml b/acceptance/testdata/simple_rpm.yaml deleted file mode 100644 index 11730f5..0000000 --- a/acceptance/testdata/simple_rpm.yaml +++ /dev/null @@ -1,15 +0,0 @@ -name: "foo" -arch: "amd64" -platform: "linux" -version: "v1.2.3" -maintainer: "Foo Bar" -description: | - Foo bar - Multiple lines -vendor: "foobar" -homepage: "https://foobar.org" -license: "MIT" -files: - ../testdata/fake: "/usr/local/bin/fake" -config_files: - ../testdata/whatever.conf: "/etc/foo/whatever.conf"