2018-02-16 02:28:11 +01:00
|
|
|
package nfpm
|
|
|
|
|
|
|
|
import (
|
2018-09-14 15:48:12 +02:00
|
|
|
"fmt"
|
2018-02-16 02:28:11 +01:00
|
|
|
"io"
|
2018-09-14 15:48:12 +02:00
|
|
|
"os"
|
2018-04-10 17:39:43 +02:00
|
|
|
"reflect"
|
2020-09-17 14:18:44 +02:00
|
|
|
"strings"
|
2018-02-16 02:28:11 +01:00
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
2018-04-05 04:13:47 +02:00
|
|
|
"github.com/stretchr/testify/require"
|
2018-02-16 02:28:11 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
func TestRegister(t *testing.T) {
|
|
|
|
format := "TestRegister"
|
|
|
|
pkgr := &fakePackager{}
|
|
|
|
Register(format, pkgr)
|
|
|
|
got, err := Get(format)
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-02-16 02:28:11 +01:00
|
|
|
assert.Equal(t, pkgr, got)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGet(t *testing.T) {
|
|
|
|
format := "TestGet"
|
|
|
|
got, err := Get(format)
|
2020-08-04 19:55:52 +02:00
|
|
|
require.Error(t, err)
|
2018-02-16 02:28:11 +01:00
|
|
|
assert.EqualError(t, err, "no packager registered for the format "+format)
|
|
|
|
assert.Nil(t, got)
|
|
|
|
pkgr := &fakePackager{}
|
|
|
|
Register(format, pkgr)
|
|
|
|
got, err = Get(format)
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-02-16 02:28:11 +01:00
|
|
|
assert.Equal(t, pkgr, got)
|
|
|
|
}
|
|
|
|
|
2019-11-05 13:38:13 +01:00
|
|
|
func TestDefaultsVersion(t *testing.T) {
|
2019-10-11 22:11:28 +02:00
|
|
|
info := &Info{
|
2020-02-18 14:49:10 +01:00
|
|
|
Version: "v1.0.0",
|
2018-02-28 12:26:29 +01:00
|
|
|
}
|
2018-02-16 02:28:11 +01:00
|
|
|
info = WithDefaults(info)
|
|
|
|
assert.NotEmpty(t, info.Platform)
|
2020-02-18 14:49:10 +01:00
|
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
|
|
assert.Equal(t, "", info.Release)
|
|
|
|
assert.Equal(t, "", info.Prerelease)
|
2019-11-05 13:38:13 +01:00
|
|
|
|
2020-02-18 14:49:10 +01:00
|
|
|
info = &Info{
|
|
|
|
Version: "v1.0.0-rc1",
|
2019-11-05 13:38:13 +01:00
|
|
|
}
|
|
|
|
info = WithDefaults(info)
|
2020-02-18 14:49:10 +01:00
|
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
|
|
assert.Equal(t, "", info.Release)
|
|
|
|
assert.Equal(t, "rc1", info.Prerelease)
|
|
|
|
|
|
|
|
info = &Info{
|
2020-08-19 15:20:02 +02:00
|
|
|
Version: "v1.0.0-beta1",
|
2020-02-18 14:49:10 +01:00
|
|
|
}
|
|
|
|
info = WithDefaults(info)
|
|
|
|
assert.Equal(t, "1.0.0", info.Version)
|
2020-08-19 15:20:02 +02:00
|
|
|
assert.Equal(t, "", info.Release)
|
|
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
2020-02-18 14:49:10 +01:00
|
|
|
|
|
|
|
info = &Info{
|
|
|
|
Version: "v1.0.0-1",
|
|
|
|
Release: "2",
|
|
|
|
Prerelease: "beta1",
|
|
|
|
}
|
|
|
|
info = WithDefaults(info)
|
|
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
|
|
assert.Equal(t, "2", info.Release)
|
|
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
|
|
|
|
|
|
|
info = &Info{
|
2020-05-24 21:09:47 +02:00
|
|
|
Version: "v1.0.0-1+xdg2",
|
2020-02-18 14:49:10 +01:00
|
|
|
Release: "2",
|
|
|
|
Prerelease: "beta1",
|
|
|
|
}
|
|
|
|
info = WithDefaults(info)
|
|
|
|
assert.Equal(t, "1.0.0", info.Version)
|
|
|
|
assert.Equal(t, "2", info.Release)
|
|
|
|
assert.Equal(t, "beta1", info.Prerelease)
|
2020-07-30 16:02:55 +02:00
|
|
|
assert.Equal(t, "", info.Deb.VersionMetadata)
|
2018-02-16 02:28:11 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestDefaults(t *testing.T) {
|
2019-10-11 22:11:28 +02:00
|
|
|
info := &Info{
|
2018-03-20 20:06:58 +01:00
|
|
|
Platform: "darwin",
|
|
|
|
Version: "2.4.1",
|
|
|
|
Description: "no description given",
|
2018-02-16 02:28:11 +01:00
|
|
|
}
|
|
|
|
got := WithDefaults(info)
|
|
|
|
assert.Equal(t, info, got)
|
|
|
|
}
|
|
|
|
|
2018-04-05 04:13:47 +02:00
|
|
|
func TestValidate(t *testing.T) {
|
2019-10-11 22:11:28 +02:00
|
|
|
require.NoError(t, Validate(&Info{
|
2018-04-05 04:13:47 +02:00
|
|
|
Name: "as",
|
|
|
|
Arch: "asd",
|
|
|
|
Version: "1.2.3",
|
2018-04-10 17:39:43 +02:00
|
|
|
Overridables: Overridables{
|
|
|
|
Files: map[string]string{
|
|
|
|
"asa": "asd",
|
|
|
|
},
|
2018-04-05 04:13:47 +02:00
|
|
|
},
|
|
|
|
}))
|
2019-10-11 22:11:28 +02:00
|
|
|
require.NoError(t, Validate(&Info{
|
2018-04-05 04:13:47 +02:00
|
|
|
Name: "as",
|
|
|
|
Arch: "asd",
|
|
|
|
Version: "1.2.3",
|
2018-04-10 17:39:43 +02:00
|
|
|
Overridables: Overridables{
|
|
|
|
ConfigFiles: map[string]string{
|
|
|
|
"asa": "asd",
|
|
|
|
},
|
2018-04-05 04:13:47 +02:00
|
|
|
},
|
|
|
|
}))
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestValidateError(t *testing.T) {
|
|
|
|
for err, info := range map[string]Info{
|
2020-05-13 21:24:06 +02:00
|
|
|
"package name must be provided": {},
|
2018-04-09 18:33:51 +02:00
|
|
|
"package arch must be provided": {
|
2018-04-05 04:13:47 +02:00
|
|
|
Name: "fo",
|
|
|
|
},
|
2018-04-09 18:33:51 +02:00
|
|
|
"package version must be provided": {
|
2018-04-05 04:13:47 +02:00
|
|
|
Name: "as",
|
|
|
|
Arch: "asd",
|
|
|
|
},
|
|
|
|
} {
|
2019-03-04 14:14:05 +01:00
|
|
|
err := err
|
|
|
|
info := info
|
2018-04-05 04:13:47 +02:00
|
|
|
t.Run(err, func(t *testing.T) {
|
2019-10-11 22:11:28 +02:00
|
|
|
require.EqualError(t, Validate(&info), err)
|
2018-04-05 04:13:47 +02:00
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-04-10 17:39:43 +02:00
|
|
|
func TestParseFile(t *testing.T) {
|
2018-04-10 21:11:35 +02:00
|
|
|
packagers = map[string]Packager{}
|
|
|
|
_, err := ParseFile("./testdata/overrides.yaml")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.Error(t, err)
|
2018-04-10 21:11:35 +02:00
|
|
|
Register("deb", &fakePackager{})
|
|
|
|
Register("rpm", &fakePackager{})
|
feat: apk support (#207)
* first attempt at apk, built from Issue #39
* inspector cleanups
* read the contrib note, ran linter, fixes made. Noice!
* linter went wonky
* linter went wonky
* fix some lint issues
* fix some lint issues
* lightweight file validation, while I try to refactor method into smaller chunks
* refactorings to get `make ci` to pass. ain't pretty, but hopefully doesn't make things worse.
* add ignore file to get workdir created in CI
* try to get a successful test run on CI (file sizes differ on CI).
* must remember to run liner (make ci) before pushing
* Doh! Detect CI via correct env var name
* tweak CI expected file sizes
* blech. try to get a range of values for CI
* better message if value fails conditions
* better message if value fails conditions
* initial impl of Package interface - just hoping I don't already have the arch mapping backwards.
* missed non-altered arch case
* ci failures
* refactor io.File to Writer
* add note about command to test apk install in docker
* remove absolute paths from test (prep for replacement with info.Files).
* rename test files folder
* get ci file size ranges happy after path changes
* get ci file size ranges happy after path changes
* move COPY towards end, allowing more caching of layers - feedback from @tcurdt
* remove Gz from function name
* rename combine function
* add skipVerify flag to preserve generated .apk file for use in dockerfile manual test. Thanks @tcurdt
* make ci is my friend
* remove useless comment
* start conversion to nfpm.Info
* use base64 encoded string for private signing key
* remove old runit() method, as we can now test using Default.Package.
add some tests lifted from deb_test.go.
* duck and cover: register the apk packager
* use the metadata from nfpm (does not handle scripts/pre/post, etc)
* getting closer to removing size assertions, but not just yet
* getting closer to removing size assertions, but not just yet
* add niffty import for init - Blank identifier comes to the rescue. Thanks @tcurdt.
add apk to overrides parse test.
* I will very much enjoy deleting this assertion...soon, soon.
* add PrivateKeyFile option, which is subordinate to PrivateKey
* move PrivateKey configs to root config struct. expand PrivateKey configs from env vars if set.
* provide the user a hint if privatekey config is missing for .apk packager
* lovin' the linter now. learning language from linter loudness. didn't know switch could work like that.
* add support for 'scripts' in control file
* fix control metadata
* make signing keyname configurable
* goofy size fix
* remove temporary test and related files
* fix template copy/pasta error
* remove old print statements
* first take at integration tests. should remove need for --allow-untrusted in `apk add` command.
* fix: merge issues, remove signature support
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: tests
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: lint issues
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: tests
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: meta
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: datahash seems unused
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: improve test code
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: unused params
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: tests
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: changelog test
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: fix
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: img
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* test: symlink
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: uneeded deletes
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* feat: symlinks
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Co-authored-by: Dan Rollo <danrollo@gmail.com>
2020-08-17 22:28:38 +02:00
|
|
|
Register("apk", &fakePackager{})
|
2018-04-10 21:11:35 +02:00
|
|
|
_, err = ParseFile("./testdata/overrides.yaml")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-04-10 21:11:35 +02:00
|
|
|
_, err = ParseFile("./testdata/doesnotexist.yaml")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.Error(t, err)
|
2018-09-14 15:48:12 +02:00
|
|
|
config, err := ParseFile("./testdata/versionenv.yaml")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-09-14 15:48:12 +02:00
|
|
|
assert.Equal(t, fmt.Sprintf("v%s", os.Getenv("GOROOT")), config.Version)
|
2018-04-10 17:39:43 +02:00
|
|
|
}
|
|
|
|
|
2020-09-17 14:18:44 +02:00
|
|
|
func TestOptionsFromEnvironment(t *testing.T) {
|
|
|
|
const (
|
|
|
|
globalPass = "hunter2"
|
|
|
|
debPass = "password123"
|
|
|
|
rpmPass = "secret"
|
|
|
|
apkPass = "foobar"
|
|
|
|
release = "3"
|
|
|
|
version = "1.0.0"
|
|
|
|
)
|
|
|
|
|
|
|
|
t.Run("version", func(t *testing.T) {
|
|
|
|
os.Clearenv()
|
|
|
|
os.Setenv("VERSION", version)
|
|
|
|
info, err := Parse(strings.NewReader("name: foo\nversion: $VERSION"))
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, version, info.Version)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("release", func(t *testing.T) {
|
|
|
|
os.Clearenv()
|
|
|
|
os.Setenv("RELEASE", release)
|
|
|
|
info, err := Parse(strings.NewReader("name: foo\nrelease: $RELEASE"))
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, release, info.Release)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("global passphrase", func(t *testing.T) {
|
|
|
|
os.Clearenv()
|
|
|
|
os.Setenv("NFPM_PASSPHRASE", globalPass)
|
|
|
|
info, err := Parse(strings.NewReader("name: foo"))
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, globalPass, info.Deb.Signature.KeyPassphrase)
|
|
|
|
assert.Equal(t, globalPass, info.RPM.Signature.KeyPassphrase)
|
|
|
|
assert.Equal(t, globalPass, info.APK.Signature.KeyPassphrase)
|
|
|
|
})
|
|
|
|
|
|
|
|
t.Run("specific passphrases", func(t *testing.T) {
|
|
|
|
os.Clearenv()
|
|
|
|
os.Setenv("NFPM_PASSPHRASE", globalPass)
|
|
|
|
os.Setenv("NFPM_DEB_PASSPHRASE", debPass)
|
|
|
|
os.Setenv("NFPM_RPM_PASSPHRASE", rpmPass)
|
|
|
|
os.Setenv("NFPM_APK_PASSPHRASE", apkPass)
|
|
|
|
info, err := Parse(strings.NewReader("name: foo"))
|
|
|
|
require.NoError(t, err)
|
|
|
|
assert.Equal(t, debPass, info.Deb.Signature.KeyPassphrase)
|
|
|
|
assert.Equal(t, rpmPass, info.RPM.Signature.KeyPassphrase)
|
|
|
|
assert.Equal(t, apkPass, info.APK.Signature.KeyPassphrase)
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2018-04-10 01:04:06 +02:00
|
|
|
func TestOverrides(t *testing.T) {
|
|
|
|
file := "./testdata/overrides.yaml"
|
|
|
|
config, err := ParseFile(file)
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-04-10 01:04:06 +02:00
|
|
|
assert.Equal(t, "foo", config.Name)
|
|
|
|
assert.Equal(t, "amd64", config.Arch)
|
|
|
|
|
|
|
|
// deb overrides
|
|
|
|
deb, err := config.Get("deb")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-04-10 01:04:06 +02:00
|
|
|
assert.Contains(t, deb.Depends, "deb_depend")
|
|
|
|
assert.NotContains(t, deb.Depends, "rpm_depend")
|
|
|
|
assert.Contains(t, deb.ConfigFiles, "deb.conf")
|
|
|
|
assert.NotContains(t, deb.ConfigFiles, "rpm.conf")
|
|
|
|
assert.Contains(t, deb.ConfigFiles, "whatever.conf")
|
|
|
|
assert.Equal(t, "amd64", deb.Arch)
|
|
|
|
|
|
|
|
// rpm overrides
|
|
|
|
rpm, err := config.Get("rpm")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2018-04-10 01:04:06 +02:00
|
|
|
assert.Contains(t, rpm.Depends, "rpm_depend")
|
|
|
|
assert.NotContains(t, rpm.Depends, "deb_depend")
|
|
|
|
assert.Contains(t, rpm.ConfigFiles, "rpm.conf")
|
|
|
|
assert.NotContains(t, rpm.ConfigFiles, "deb.conf")
|
|
|
|
assert.Contains(t, rpm.ConfigFiles, "whatever.conf")
|
|
|
|
assert.Equal(t, "amd64", rpm.Arch)
|
2018-04-10 17:39:43 +02:00
|
|
|
|
|
|
|
// no overrides
|
|
|
|
info, err := config.Get("doesnotexist")
|
2020-08-04 19:55:52 +02:00
|
|
|
require.NoError(t, err)
|
2019-10-11 22:11:28 +02:00
|
|
|
assert.True(t, reflect.DeepEqual(&config.Info, info))
|
2018-04-10 01:04:06 +02:00
|
|
|
}
|
|
|
|
|
2018-02-16 02:28:11 +01:00
|
|
|
type fakePackager struct{}
|
|
|
|
|
2020-07-09 15:16:04 +02:00
|
|
|
func (*fakePackager) ConventionalFileName(info *Info) string {
|
|
|
|
return ""
|
|
|
|
}
|
|
|
|
|
2019-10-11 22:11:28 +02:00
|
|
|
func (*fakePackager) Package(info *Info, w io.Writer) error {
|
2018-02-16 02:28:11 +01:00
|
|
|
return nil
|
|
|
|
}
|