1684 Commits

Author	SHA1	Message	Date
A-Walrus	c15f1ea274	Add cursorcolumn (#4084) ... * Implement cursorcolumn * Add documentation * Separate column style from line with fallback * Fallback to cursorcolumn first * Switch to non-fallback try_get_exact Add new function `try_get_exact`, which doesn't perform fallback, and use that instead because the fallback behaviour is being handled manually.	2022-10-09 03:28:42 +09:00
A-Walrus	c927d61791	Fix bugs in search wraparound message (#4101)	2022-10-04 16:49:43 -05:00
dependabot[bot]	7c33b9c76d	build(deps): bump smallvec from 1.9.0 to 1.10.0 (#4093) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2022-10-03 18:38:24 -05:00
Skyler Hawthorne	27b70696df	Exit gracefully when close operation fails (#4081) ... If the close method fails, the editor will quit before restoring the terminal. This causes the shell to break if, e.g. the LS times out shutting down. This fixes this by always restoring the terminal after closing, and printing out a message to stderr if there is an error.	2022-10-04 00:35:42 +09:00
Michael Davis	6cca7375ec	Automatically track pseudo-pending text (#4077) ... This change automatically tracks pending text for for commands which use on-next-key callbacks. For example, `t` will await the next key event and "t" will be shown in the bottom right-hand corner to show that we're in a pending state. Previously, the text for these on-next-key commands needed to be hard-coded into the command definition which had some drawbacks: * It was easy to forget to write and clear the pending text. * If a command was remapped in a custom config, the pending text would still show the old key. With this change, pending text is automatically tracked based on the key events that lead to the command being executed. This works even when the command is remapped in config and when the on-next-key callback is nested under some key sequence (for example `mi`).	2022-10-04 00:14:57 +09:00
Karsten Gebbert	9124c231f4	respond to SIGUSR1 by reloading config (#3952) ... * respond to SIGUSR1 by reloading config * document USR1 signal handling	2022-10-04 00:08:32 +09:00
Ivan Tham	3d59d3f8be	Keep arrow and special keys in insert (#3915) ... * Keep arrow and special keys in insert Advanced users won't need it and is useful for beginners. Revert part of #3671. * Change text for insert mode section Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> * Remove ctrl-up/down in insert * Reorganize insert keys and docs * Improve page up experience on last tutor The last tutor page can page down multiple times and it will break the heading on the 80x24 screen paging when reaching the last page, this keeps the style the same and make sure page up and down won't break it. Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>	2022-10-04 00:08:15 +09:00
A-Walrus	1d8bb2249b	Change focus to modified docs on quit (#3872) ... * Change focus to modified docs on quit When quitting with modified documents, automatically switch focus to one of them. * Update helix-term/src/commands/typed.rs Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com> * Make it work with buffer-close-all and the like * Cleanup Use Cow instead of String, and rename DoesntExist -> DoesNotExist Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>	2022-10-04 00:07:21 +09:00
Robin	6764744ce9	Add option to skip the first indent guide (#3819) ... * Add option to skip the first indent guide * reorder skip_first option * change indent-guides.skip_first to a number * rename skip -> skip_levels * add skip_levels to the book * Update book/src/configuration.md Co-authored-by: A-Walrus <58790821+A-Walrus@users.noreply.github.com> * Update helix-term/src/ui/editor.rs Co-authored-by: Michael Davis <mcarsondavis@gmail.com> Co-authored-by: Robin <robinvandijk@klippa.com> Co-authored-by: A-Walrus <58790821+A-Walrus@users.noreply.github.com> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2022-10-04 00:07:04 +09:00
Michael Davis	dbec057363	Rename I/A "Insert at start/end of line" (#3753) ... * keymap: Rename A "Insert at end of line" The language for the `A` binding is potentially confusing because `A` behaves like `i` done at the end of the line rather than `a`. This change renames the command to match Kakoune's language[^1]. [^1]: 021da117cf/src/normal.cc (L2229) * keymap: Rename I `insert_at_line_start`	2022-10-04 00:05:08 +09:00
ath3	7c9809eeb2	Find workspace from document path (#3553)	2022-10-04 00:02:49 +09:00
Ivan Tham	66bbba9024	Select inserted space after join (#3549) ... * Select inserted space after join * Split join_selections with space selection to A-J Kakoune does that too and some users may still want to retain their selections. * Update join_selections docs	2022-10-04 00:02:14 +09:00
nuid32	576c34f84e	Add command names to command palette (#4071)	2022-10-03 23:56:43 +09:00
Ivan Tham	93f26a3048	Fix signature help panic when too large (#4030) ... When signature help is too large it may cause a panic when it is too large, now I just make the hover do an intersection with surface to make sure it never overflow.	2022-10-03 23:56:24 +09:00
greg-enbala	63ff9309ce	goto_window_* extends selection (#3985) ... * goto_window_* extends selection * Don't push to the jumplist	2022-10-03 23:55:26 +09:00
Joshua Pauline	c144cc0b04	feat(statusline): add option to show total line numbers in file (#3960) ... * feat(statusline): add option to show total line numbers in file * feat(line numbers): add config to doc book	2022-10-03 23:54:00 +09:00
PeepNSheep	77f33e7b20	Add configureable statusline mode names (#3311) ... * Added 'long-mode' statusline element * Added customizable statusline mode names * Removed a string clone * Added documentation * Updated documentation, moved modenames to a seperate section * Update configuration.md * Documentation update * Documentation update * Documentation update * Update configuration.md * Update configuration.md * Fixed merge error * Update configuration.md * Update configuration.md	2022-10-03 23:45:32 +09:00
ChrHorn	589d17c758	Add ui.gutter.selected option for themes (#3303) ... * add `ui.gutter.selected` * add `ui.gutter`, `ui.gutter.selected` to docs	2022-10-03 23:44:45 +09:00
Michael Davis	6939dd3adb	Add tests for select-mode TS textobjects	2022-10-03 10:44:08 -04:00
Michael Davis	c253139790	Extend textobject selections in select mode	2022-10-03 10:44:08 -04:00
Michael Davis	032d76ccf2	Use Range::with_direction consistently	2022-10-03 10:44:08 -04:00
Michael Davis	274f2ea459	Use requested direction for new textobject selection range ... This changes the behavior of operations like `]f`/`[f` to set the direction of the new range to the direction of the action. The original behavior was to always use the head of the next function. This is inconsistent with the behavior of goto_next_paragraph and makes it impossible to create extend variants of the textobject motions. This causes a behavior change when there are nested functions. The behavior in the parent commit is that repeated uses of `]f` will select every function in the file even if nested. With this commit, functions are skipped. It's notable that it's possible to emulate the original behavior by using the `ensure_selections_forward` (A-:) command between invocations of `]f`.	2022-10-03 10:44:08 -04:00
A-Walrus	f3958aa1fd	Cycled to end/beginning + no more matches msgs (#3176) ... * Show status msg when next/prev cycles around * Add msg when there is no wraparound * Cleanup code * Change msg to "Wrapped around document"	2022-10-03 23:43:26 +09:00
A-Walrus	57dc5fbe3a	Show "Invalid regex" message on enter (Validate) (#3049) ... * Show "Invalid regex" message on enter (Validate) * Reset selection on invalid regex * Add popup for invalid regex * Replace set_position with position * Make popup auto close	2022-10-03 23:33:48 +09:00
Joe	bcba5d67f9	Add goto preview (#2982)	2022-10-03 23:33:20 +09:00
Matt Freitas-Stavola	9d1793c45b	Add pseudo_pending for t/T/f/F (#4062)	2022-10-02 14:32:30 -05:00
zensayyy	c9584251f3	Ensure cursor in view after format (#4047) ... Co-authored-by: Michael Davis <mcarsondavis@gmail.com>	2022-10-01 09:32:09 -05:00
dependabot[bot]	fd4cdf0b1f	build(deps): bump once_cell from 1.14.0 to 1.15.0 (#3987) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2022-09-26 18:19:50 -05:00
Poliorcetics	e8f0886b21	chore: remove unneeded attribute after MSRV bump to 1.61 (#3961)	2022-09-25 08:12:33 -05:00
Riccardo Binetti	888f4fef6f	Split helix_core::find_root and helix_loader::find_local_config_dirs (#3929) ... * Split helix_core::find_root and helix_loader::find_local_config_dirs The documentation of find_root described the following priority for detecting a project root: - Top-most folder containing a root marker in current git repository - Git repository root if no marker detected - Top-most folder containing a root marker if not git repository detected - Current working directory as fallback The commit contained in https://github.com/helix-editor/helix/pull/1249 extracted and changed the implementation of find_root in find_root_impl, actually reversing its result order (since that is the order that made sense for the local configuration merge, from innermost to outermost ancestors). Since the two uses of find_root_impl have different requirements (and it's not a matter of reversing the order of results since, e.g., the top repository dir should be used by find_root only if there's not marker in other dirs), this PR splits the two implementations in two different specialized functions. In doing so, find_root_impl is removed and the implementation is moved back in find_root, moving it closer to the documented behaviour thus making it easier to verify it's actually correct * helix-core: remove Option from find_root return type It always returns some result, so Option is not needed	2022-09-23 17:04:07 +09:00
Pascal Kuthe	4133f1f424	Document MSRV policy (#3913)	2022-09-23 15:58:00 +09:00
A-Walrus	eb6fd283dc	Deduplicate regexes in search_selection command (#3941)	2022-09-22 23:33:30 +08:00
Michael Davis	6e168b5099	Improve keymap errors from command typos (#3931) ... * Improve keymap errors from command typos Currently, opening helix with a config containing a bad command mapping fails with a cryptic error. For example, say we have a config (bad.toml) with a command name that doesn't exist: [keys.normal] b = "buffer_close" # should be ":buffer-close" When we `hx -c bad.toml`, we get... > Bad config: data did not match any variant of untagged enum KeyTrie for key `keys.normal` at line 1 column 1 > Press <ENTER> to continue with default config This is because of the way that Serde tries to deserialize untagged enums such as `helix_term::keymap::KeyTrie`. From the Serde docs[^1]: > Serde will try to match the data against each variant in order and the > first one that deserializes successfully is the one returned. `MappableCommand::deserialize` fails (returns an Err variant) when a command does not exist. Serde interprets this as the `KeyTrie::Leaf` variant failing to match and declares that the input data doesn't "match any variant of untagged enum KeyTrie." Luckily the variants of KeyTrie are orthogonal in structure: we can tell them apart by the type hints from a `serde:🇩🇪:Visitor`. This change uses a custom Deserialize implementation along with a Visitor that discerns which variant of the KeyTrie applies. With this change, the above failure becomes: > Bad config: No command named 'buffer_close' for key `keys.normal.b` at line 2 column 5 > Press <ENTER> to continue with default config We also provide more explicit information about the expectations on the field. A config with an unexpected type produces a message with that information and the expectation: [keys.normal] b = 1 > Bad config: invalid type: integer `1`, expected a command, list of commands, or sub-keymap for key `keys.normal.b` at line 2 column 5 > Press <ENTER> to continue with default config [^1]: https://serde.rs/enum-representations.html#untagged * Update helix-term/src/keymap.rs Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>	2022-09-22 09:30:42 +08:00
Filipe Azevedo	385ccdfc9c	add :lsp-restart command (#3435)	2022-09-20 16:44:36 +09:00
Joe	aa00a470f3	Fix preview bug (#3644) ... * Fix preview bug * Add comment to empty case	2022-09-20 16:40:48 +09:00
Blaž Hrastnik	1df32c917c	diagnostics: Use Vec<Tag> instead of Option<Vec<Tag>>	2022-09-20 16:28:00 +09:00
Luke Cycon	64b0745413	Track source and tags in diagnostics (#3898)	2022-09-20 16:21:15 +09:00
Tobias Hunger	130793dfd0	Add command line parameter to specify log file (#3807) ... * Add command line parameter to specify log file I had the logs of my debug helix mixed in with the logs from the production helix. Add a `--log` command line argument to redirect any logs to other files, making my debugging easier :-) * Update completion files with `--log` argument	2022-09-20 16:11:30 +09:00
A-Walrus	d38950bdf9	Remove border from code actions popup (#3444)	2022-09-13 05:24:48 -04:00
A-Walrus	ac460ac837	Render html <code> tags as code in markdown (#3425)	2022-09-13 05:14:16 -04:00
Blaž Hrastnik	c2e41082e4	Remove the .txt suffix from tutor ... The tutor file is loaded as .txt which can potentially spawn a language server. Then the path is unset, but the LS remains active. This can cause panics since updates are now submitted for a doc with no path. As a quick workaround we remove the extension which should avoid detection. Fixes #3730	2022-09-11 11:11:07 +09:00
A-Walrus	9c627c65e5	Improve error handling for config-reload (#3668) ... * Don't change config to default when refreshing invalid config * Propely handle theme errors with config-reload * Extract refresh theme into seperate function	2022-09-10 22:32:49 +09:00
A-Walrus	75e6a64327	Switch to Result for invalid language	2022-09-10 22:23:38 +09:00
A-Walrus	e8add6f46d	Add error handling to set language command ... If you type a nonexistant language an appropriate message will show, and the language won't be changed.	2022-09-10 22:23:38 +09:00
A-Walrus	cc47d3fb9d	Add text to language completer	2022-09-10 22:23:38 +09:00
Skyler Hawthorne	e12690e2f5	Remove default insert mode movement bindings ... Helix is first and foremost a modal editor. Willingness to support non-modal editing is there, but it is not one that should be encouraged with the default settings. There are an increasing number of users who are stumbling because they are trying to use Helix as a non-modal editor, so this is an effort to encourage new users to stop and take notice that Helix has a different paradigm than VSCode, Sublime, etc. Users can still add these bindings back to their own configs if they wish.	2022-09-08 17:36:04 -05:00
A-Walrus	e14b48af2e	Fix :reflow panic by enusring cursor in view (#3733)	2022-09-07 12:50:54 -05:00
Blaž Hrastnik	a123fb6057	Remove LspNotDefined, instead return an Option<>	2022-09-07 16:42:33 +09:00
dependabot[bot]	5e1296b888	build(deps): bump once_cell from 1.13.1 to 1.14.0 (#3715) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2022-09-05 18:33:01 -05:00
Blaž Hrastnik	1acdfaa073	fix: View needs to retain the original scroll offset on split	2022-09-05 11:58:00 +09:00