1
1
mirror of https://github.com/go-gitea/gitea.git synced 2024-10-01 13:31:30 +02:00
gitea/modules/convert
Gusted ebe569a268
Set correct PR status on 3way on conflict checking (#19457)
* Set correct PR status on 3way on conflict checking

- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.

* Fix linter
2022-04-21 22:55:45 +01:00
..
convert.go
git_commit_test.go
git_commit.go
issue_comment.go
issue_test.go
issue.go
main_test.go
notification.go
package.go
pull_review.go
pull_test.go
pull.go
release.go
repository.go
status.go
user_test.go
user.go
utils_test.go
utils.go
wiki.go