1
1
mirror of https://github.com/go-gitea/gitea.git synced 2024-10-01 12:21:35 +02:00
gitea/services
Gusted ebe569a268
Set correct PR status on 3way on conflict checking (#19457)
* Set correct PR status on 3way on conflict checking

- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.

* Fix linter
2022-04-21 22:55:45 +01:00
..
agit
asymkey
attachment
auth
comments
context
cron
externalaccount
forms
gitdiff
issue
lfs
mailer
migrations
mirror
org
packages
pull
release
repository
task
user
webhook
wiki